)]}'
{"nova/tests/test_migrations.py":[{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"580efa8bf4a2d4792c7523979fa30e9df32116bf","unresolved":false,"context_lines":[{"line_number":384,"context_line":"    # migration 141, update migrations instance uuid"},{"line_number":385,"context_line":"    def _prerun_141(self, engine):"},{"line_number":386,"context_line":"        data \u003d [{"},{"line_number":387,"context_line":"            \u0027id\u0027: 1,"},{"line_number":388,"context_line":"            \u0027instance_uuid\u0027: \u002712345678-1234-1234-123456789012\u0027"},{"line_number":389,"context_line":"            }, {"},{"line_number":390,"context_line":"            # this one is intentionally too long"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FCCQ%3D","line":387,"updated":"2013-02-10 21:48:34.000000000","message":"if this is an auto incrementing integer, for a column, we shouldn\u0027t set it drirectly (I know we do it other places, but it can actually break things on pg). Check out like 426 on the way to do this correctly.","commit_id":"aa732aa60309cbff8949d00a776814f329a5759f"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"580efa8bf4a2d4792c7523979fa30e9df32116bf","unresolved":false,"context_lines":[{"line_number":385,"context_line":"    def _prerun_141(self, engine):"},{"line_number":386,"context_line":"        data \u003d [{"},{"line_number":387,"context_line":"            \u0027id\u0027: 1,"},{"line_number":388,"context_line":"            \u0027instance_uuid\u0027: \u002712345678-1234-1234-123456789012\u0027"},{"line_number":389,"context_line":"            }, {"},{"line_number":390,"context_line":"            # this one is intentionally too long"},{"line_number":391,"context_line":"            # prerun should work as String(255)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FCCM%3D","line":388,"updated":"2013-02-10 21:48:34.000000000","message":"let\u0027s auto generate this with uuid4","commit_id":"aa732aa60309cbff8949d00a776814f329a5759f"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"580efa8bf4a2d4792c7523979fa30e9df32116bf","unresolved":false,"context_lines":[{"line_number":393,"context_line":"            \u0027instance_uuid\u0027: \u002712345678-1234-1234-1234567890123\u0027"},{"line_number":394,"context_line":"            }]"},{"line_number":395,"context_line":"        migrations \u003d get_table(engine, \u0027migrations\u0027)"},{"line_number":396,"context_line":"        engine.execute(migrations.insert(), data)"},{"line_number":397,"context_line":"        return data"},{"line_number":398,"context_line":""},{"line_number":399,"context_line":"    def _check_141(self, engine, data):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FCCE%3D","line":396,"updated":"2013-02-10 21:48:34.000000000","message":"style preference, but I\u0027ve found:\n\nmigrations.insert().values(data).execute() to be more to my liking.","commit_id":"aa732aa60309cbff8949d00a776814f329a5759f"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"580efa8bf4a2d4792c7523979fa30e9df32116bf","unresolved":false,"context_lines":[{"line_number":403,"context_line":"        migrate_items \u003d migrations.select().execute().fetchall()"},{"line_number":404,"context_line":"        self.assertEqual(len(migrate_items), 2)"},{"line_number":405,"context_line":""},{"line_number":406,"context_line":"        m_row \u003d migrations.select("},{"line_number":407,"context_line":"        migrations.c.id \u003d\u003d 1).execute().first()"},{"line_number":408,"context_line":""},{"line_number":409,"context_line":"        # Check that change to String(36) went alright"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FCBw%3D","line":406,"updated":"2013-02-10 21:48:34.000000000","message":"m_row is an odd variable name for python, just make it row, or something else.","commit_id":"aa732aa60309cbff8949d00a776814f329a5759f"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"580efa8bf4a2d4792c7523979fa30e9df32116bf","unresolved":false,"context_lines":[{"line_number":404,"context_line":"        self.assertEqual(len(migrate_items), 2)"},{"line_number":405,"context_line":""},{"line_number":406,"context_line":"        m_row \u003d migrations.select("},{"line_number":407,"context_line":"        migrations.c.id \u003d\u003d 1).execute().first()"},{"line_number":408,"context_line":""},{"line_number":409,"context_line":"        # Check that change to String(36) went alright"},{"line_number":410,"context_line":"        self.assertEqual(data[0][\u0027instance_uuid\u0027], m_row[\u0027instance_uuid\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FCB4%3D","line":407,"updated":"2013-02-10 21:48:34.000000000","message":"Instead of hard coding to 1, make it use data[0][\u0027id\u0027]","commit_id":"aa732aa60309cbff8949d00a776814f329a5759f"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"7dcea46bd52cd7ea144f54598cc1c1ea2ed4b04e","unresolved":false,"context_lines":[{"line_number":404,"context_line":"        self.assertEqual(len(migrate_items), 2)"},{"line_number":405,"context_line":""},{"line_number":406,"context_line":"        m_row \u003d migrations.select("},{"line_number":407,"context_line":"        migrations.c.id \u003d\u003d 1).execute().first()"},{"line_number":408,"context_line":""},{"line_number":409,"context_line":"        # Check that change to String(36) went alright"},{"line_number":410,"context_line":"        self.assertEqual(data[0][\u0027instance_uuid\u0027], m_row[\u0027instance_uuid\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FC%2Bk%3D","line":407,"updated":"2013-02-09 03:24:01.000000000","message":"This indentation looks wrong. I think this will all fit on one line, but if not, the second needs to be indented at least four spaces.","commit_id":"aa732aa60309cbff8949d00a776814f329a5759f"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"580efa8bf4a2d4792c7523979fa30e9df32116bf","unresolved":false,"context_lines":[{"line_number":409,"context_line":"        # Check that change to String(36) went alright"},{"line_number":410,"context_line":"        self.assertEqual(data[0][\u0027instance_uuid\u0027], m_row[\u0027instance_uuid\u0027])"},{"line_number":411,"context_line":"        # this should not equal the original data due to truncation"},{"line_number":412,"context_line":"        self.assertNotEqual(data[1][\u0027instance_uuid\u0027], m_row[\u0027instance_uuid\u0027])"},{"line_number":413,"context_line":""},{"line_number":414,"context_line":"    # migration 146, availability zone transition"},{"line_number":415,"context_line":"    def _prerun_146(self, engine):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FCBs%3D","line":412,"updated":"2013-02-10 21:48:34.000000000","message":"I think I agree with Dan on this one, though I\u0027m mixed on the usefulness of testing long ids, because I feel like we\u0027d have exploded a while ago on those. But if we are going to keep the check, let\u0027s keep it so that it truncates as expected.","commit_id":"aa732aa60309cbff8949d00a776814f329a5759f"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"7dcea46bd52cd7ea144f54598cc1c1ea2ed4b04e","unresolved":false,"context_lines":[{"line_number":409,"context_line":"        # Check that change to String(36) went alright"},{"line_number":410,"context_line":"        self.assertEqual(data[0][\u0027instance_uuid\u0027], m_row[\u0027instance_uuid\u0027])"},{"line_number":411,"context_line":"        # this should not equal the original data due to truncation"},{"line_number":412,"context_line":"        self.assertNotEqual(data[1][\u0027instance_uuid\u0027], m_row[\u0027instance_uuid\u0027])"},{"line_number":413,"context_line":""},{"line_number":414,"context_line":"    # migration 146, availability zone transition"},{"line_number":415,"context_line":"    def _prerun_146(self, engine):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FC%2BQ%3D","line":412,"updated":"2013-02-09 03:24:01.000000000","message":"This is checking that migration 2\u0027s instance_uuid is not equal to migration 1\u0027s. You\u0027re not actually checking that migration 2\u0027s uuid was truncated, truncated as expected, or anything like that (as your commit message states).\n\nIf you were comparing it to migration 2, I would also check that it is actually equal to the truncated original data. \"Not equal\" can mean a lot of things.","commit_id":"aa732aa60309cbff8949d00a776814f329a5759f"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"0fbee75116fe9bb6df50a7c1ad59a0f5d80a7b62","unresolved":false,"context_lines":[{"line_number":409,"context_line":"        # Check that change to String(36) went alright"},{"line_number":410,"context_line":"        self.assertEqual(data[0][\u0027instance_uuid\u0027], m_row[\u0027instance_uuid\u0027])"},{"line_number":411,"context_line":"        # this should not equal the original data due to truncation"},{"line_number":412,"context_line":"        self.assertNotEqual(data[1][\u0027instance_uuid\u0027], m_row[\u0027instance_uuid\u0027])"},{"line_number":413,"context_line":""},{"line_number":414,"context_line":"    # migration 146, availability zone transition"},{"line_number":415,"context_line":"    def _prerun_146(self, engine):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2FBIk%3D","line":412,"in_reply_to":"AAAAM3%2F%2FCBs%3D","updated":"2013-02-11 15:26:41.000000000","message":"IIRC, it turns out that in mysql at least, it doesn\u0027t truncate like we\u0027d expect (off the end), so I think this is valuable since it could differ between engines, I imagine.","commit_id":"aa732aa60309cbff8949d00a776814f329a5759f"}]}