)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14358,"name":"Marian Horban","email":"m.horban@gmail.com","username":"mhorban"},"change_message_id":"e378b25a6bada9ec48a67269590dd11d220303e2","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add some tests for map_dev"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Tests are good."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I593f153575c77b73d187c704b87ee16094a6ada6"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"fa1b9901_53903e43","line":9,"updated":"2015-08-25 14:35:18.000000000","message":"But commit message is not good :)","commit_id":"90f70882780834e52b6d3b3c802975d5759b4c35"},{"author":{"_account_id":8688,"name":"Alexis Lee","email":"openstack@lxsli.co.uk","username":"lxsli"},"change_message_id":"77c22f0b6f2eed60d495c44df2e2f21f7d512a27","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add some tests for map_dev"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Tests are good."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I593f153575c77b73d187c704b87ee16094a6ada6"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"fa1b9901_d73f2cb2","line":9,"in_reply_to":"fa1b9901_53903e43","updated":"2015-08-26 10:00:34.000000000","message":"What do you suggest?","commit_id":"90f70882780834e52b6d3b3c802975d5759b4c35"}],"nova/tests/unit/virt/disk/mount/test_api.py":[{"author":{"_account_id":14819,"name":"Timofey Durakov","email":"timofei.nd@gmail.com","username":"tdurakov"},"change_message_id":"ed0163dc202763066a74a028d168748f1068b743","unresolved":false,"context_lines":[{"line_number":39,"context_line":"    def _test_map_dev_with_trycmd(self, partition, trycmd):"},{"line_number":40,"context_line":"        trycmd.return_value \u003d [None, None]"},{"line_number":41,"context_line":"        mount \u003d self._test_map_dev(partition)"},{"line_number":42,"context_line":"        self.assertEqual(1, trycmd.call_count)  # don\u0027t care about args"},{"line_number":43,"context_line":"        return mount"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    def _exists_effect(self, data):"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa1b9901_f0bb61c2","line":42,"updated":"2015-08-26 07:19:31.000000000","message":"it would be better to use mock\u0027s assert_called_once_with instead","commit_id":"90f70882780834e52b6d3b3c802975d5759b4c35"},{"author":{"_account_id":8688,"name":"Alexis Lee","email":"openstack@lxsli.co.uk","username":"lxsli"},"change_message_id":"77c22f0b6f2eed60d495c44df2e2f21f7d512a27","unresolved":false,"context_lines":[{"line_number":39,"context_line":"    def _test_map_dev_with_trycmd(self, partition, trycmd):"},{"line_number":40,"context_line":"        trycmd.return_value \u003d [None, None]"},{"line_number":41,"context_line":"        mount \u003d self._test_map_dev(partition)"},{"line_number":42,"context_line":"        self.assertEqual(1, trycmd.call_count)  # don\u0027t care about args"},{"line_number":43,"context_line":"        return mount"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    def _exists_effect(self, data):"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa1b9901_975c541a","line":42,"in_reply_to":"fa1b9901_f0bb61c2","updated":"2015-08-26 10:00:34.000000000","message":"That checks the args, which I don\u0027t care about, as I commented. I could use that assert and put mock.ANY for every arg, but that seems a roundabout way of doing exactly what I have here.","commit_id":"90f70882780834e52b6d3b3c802975d5759b4c35"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"4aca50fdebbeee2e816097a808844fba47bb8af2","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    def setUp(self):"},{"line_number":29,"context_line":"        super(MountTestCase, self).setUp()"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    def _test_map_dev(self, partition):"},{"line_number":32,"context_line":"        mount \u003d api.Mount(mock.sentinel.image, mock.sentinel.mount_dir)"},{"line_number":33,"context_line":"        mount.device \u003d ORIG_DEVICE"},{"line_number":34,"context_line":"        mount.partition \u003d partition"}],"source_content_type":"text/x-python","patch_set":3,"id":"da20952f_ba42560d","line":31,"updated":"2015-09-01 12:05:35.000000000","message":"the name is a little confusing here - essentailly this is getting the mount details and not doing any tests","commit_id":"d94722fe6f3fb6f9b4da35748a2c50c9a514d656"},{"author":{"_account_id":8688,"name":"Alexis Lee","email":"openstack@lxsli.co.uk","username":"lxsli"},"change_message_id":"d1ea030ecf36215bb8832d6c4fd44951fef46ba1","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    def setUp(self):"},{"line_number":29,"context_line":"        super(MountTestCase, self).setUp()"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    def _test_map_dev(self, partition):"},{"line_number":32,"context_line":"        mount \u003d api.Mount(mock.sentinel.image, mock.sentinel.mount_dir)"},{"line_number":33,"context_line":"        mount.device \u003d ORIG_DEVICE"},{"line_number":34,"context_line":"        mount.partition \u003d partition"}],"source_content_type":"text/x-python","patch_set":3,"id":"da20952f_3d008001","line":31,"in_reply_to":"da20952f_ba42560d","updated":"2015-09-01 12:40:41.000000000","message":"Line 35 executes the code under test, I call that testing. The checks happen afterwards I\u0027ll grant you.","commit_id":"d94722fe6f3fb6f9b4da35748a2c50c9a514d656"}]}