)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"change_message_id":"fae3459b677023d25d5e0d00e6cd63f91a464b61","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"The NUMATopologyFilter already gives this behaviour, this is just"},{"line_number":13,"context_line":"updating the other filters."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: Ib5f2a5eb69bcfbc4f147be000cba29c0c2d11089"},{"line_number":16,"context_line":"Closes-Bug: #1485631"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fa1b9901_f22f2c3c","line":14,"updated":"2015-08-25 02:02:24.000000000","message":"We need a DocImpact here I think as well, as this is a change of behaviour.","commit_id":"24da44a0d0c6097f8dd7e47cb8770dcfc68cc3a3"}],"nova/scheduler/filters/ram_filter.py":[{"author":{"_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},"change_message_id":"3c2771de0d787a7dc726f77ca394842ba2e19de0","unresolved":false,"context_lines":[{"line_number":48,"context_line":""},{"line_number":49,"context_line":"        # Do not allow an instance to overcommit against itself, only against"},{"line_number":50,"context_line":"        # other instances."},{"line_number":51,"context_line":"        if not total_usable_ram_mb \u003e\u003d requested_ram:"},{"line_number":52,"context_line":"            LOG.debug(\"%(host_state)s does not have %(requested_ram)s MB \""},{"line_number":53,"context_line":"                      \"usable ram before overcommit, it only has \""},{"line_number":54,"context_line":"                      \"%(usable_ram)s MB.\","}],"source_content_type":"text/x-python","patch_set":2,"id":"fa1b9901_4a3df4b9","line":51,"updated":"2015-08-25 08:11:17.000000000","message":"so not sure why you inverted this test, the cpu one is if requested \u003e total, and this one is if not total \u003e\u003d requested... but okay both are technically correct","commit_id":"95940ccbb9cbf0cbf6421b0650bf3e2c4dd12e61"}],"nova/tests/unit/scheduler/filters/test_ram_filters.py":[{"author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"change_message_id":"fae3459b677023d25d5e0d00e6cd63f91a464b61","unresolved":false,"context_lines":[{"line_number":52,"context_line":"                {\u0027free_ram_mb\u0027: 512, \u0027total_usable_ram_mb\u0027: 512})"},{"line_number":53,"context_line":"        self.assertFalse(self.filt_cls.host_passes(host, filter_properties))"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"@mock.patch(\u0027nova.scheduler.filters.utils.aggregate_values_from_key\u0027)"},{"line_number":56,"context_line":"class TestAggregateRamFilter(test.NoDBTestCase):"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    def setUp(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa1b9901_120420be","line":55,"updated":"2015-08-25 02:02:24.000000000","message":"Need a second blank line before this line.","commit_id":"24da44a0d0c6097f8dd7e47cb8770dcfc68cc3a3"}]}