)]}'
{"nova/tests/baremetal/db/test_bm_node.py":[{"author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"change_message_id":"14091bcfacfa5a82b264a080bfe4376ac2dde1da","unresolved":false,"context_lines":[{"line_number":106,"context_line":"        self.assertIn(\u00273\u0027, pmaddrs)"},{"line_number":107,"context_line":"        self.assertIn(\u00274\u0027, pmaddrs)"},{"line_number":108,"context_line":"        self.assertIn(\u00275\u0027, pmaddrs)"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"    def test_destroy(self):"},{"line_number":111,"context_line":"        self._create_nodes()"},{"line_number":112,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAM3%2F%2B2pc%3D","line":109,"updated":"2013-02-16 22:57:11.000000000","message":"Why no test for get_unassociated?","commit_id":"ad0828db5c10924d40ec3972f347310f62e1e0e1"},{"author":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"change_message_id":"5861a5bd73136a09df54cb1e1b7fc8f2398dfa8a","unresolved":false,"context_lines":[{"line_number":106,"context_line":"        self.assertIn(\u00273\u0027, pmaddrs)"},{"line_number":107,"context_line":"        self.assertIn(\u00274\u0027, pmaddrs)"},{"line_number":108,"context_line":"        self.assertIn(\u00275\u0027, pmaddrs)"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"    def test_destroy(self):"},{"line_number":111,"context_line":"        self._create_nodes()"},{"line_number":112,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAM3%2F%2Bzwg%3D","line":109,"in_reply_to":"AAAAM3%2F%2B0FM%3D","updated":"2013-02-18 20:37:01.000000000","message":"I don\u0027t think it is.","commit_id":"ad0828db5c10924d40ec3972f347310f62e1e0e1"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"edc5e340f7d073b52b242ac3cb59a2b577f8f00d","unresolved":false,"context_lines":[{"line_number":106,"context_line":"        self.assertIn(\u00273\u0027, pmaddrs)"},{"line_number":107,"context_line":"        self.assertIn(\u00274\u0027, pmaddrs)"},{"line_number":108,"context_line":"        self.assertIn(\u00275\u0027, pmaddrs)"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"    def test_destroy(self):"},{"line_number":111,"context_line":"        self._create_nodes()"},{"line_number":112,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAM3%2F%2B0FM%3D","line":109,"in_reply_to":"AAAAM3%2F%2B2pc%3D","updated":"2013-02-18 18:35:56.000000000","message":"This test actually tests both methods. I can rename it if it\u0027s worth another revision and rebasing the next two.","commit_id":"ad0828db5c10924d40ec3972f347310f62e1e0e1"},{"author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"change_message_id":"820132cfef10d22346ac0f063e19359e69b52491","unresolved":false,"context_lines":[{"line_number":106,"context_line":"        self.assertIn(\u00273\u0027, pmaddrs)"},{"line_number":107,"context_line":"        self.assertIn(\u00274\u0027, pmaddrs)"},{"line_number":108,"context_line":"        self.assertIn(\u00275\u0027, pmaddrs)"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"    def test_destroy(self):"},{"line_number":111,"context_line":"        self._create_nodes()"},{"line_number":112,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAM3%2F%2BzlY%3D","line":109,"in_reply_to":"AAAAM3%2F%2Bzwg%3D","updated":"2013-02-18 21:37:33.000000000","message":"Oh, that\u0027s just me being lame. My bad.","commit_id":"ad0828db5c10924d40ec3972f347310f62e1e0e1"}],"nova/virt/baremetal/db/sqlalchemy/api.py":[{"author":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"change_message_id":"72a290d030c9c968765d29c2db09829125515fc7","unresolved":false,"context_lines":[{"line_number":85,"context_line":"def bm_node_get_all(context, service_host\u003dNone, associated\u003dNone):"},{"line_number":86,"context_line":"    query \u003d model_query(context, models.BareMetalNode, read_deleted\u003d\"no\")"},{"line_number":87,"context_line":"    if service_host:"},{"line_number":88,"context_line":"        query \u003d query.filter_by(service_host\u003dservice_host)"},{"line_number":89,"context_line":"    if associated \u003d\u003d True:"},{"line_number":90,"context_line":"        query \u003d query.filter(models.BareMetalNode.instance_uuid !\u003d None)"},{"line_number":91,"context_line":"    elif associated \u003d\u003d False:"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAM3%2F%2FAVc%3D","line":88,"updated":"2013-02-11 21:16:20.000000000","message":"Might be an idea to split this into focused methods rather than an if-then that re-infers intent. The main this that this is \u0027get all\u0027 but with flags it doesn\u0027t. Food for thought.","commit_id":"fc6220f332a9f29f091078b72489cca0ed0c0c1b"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"790b5ffb3e716bb6d49ece9f2552a95be82be24d","unresolved":false,"context_lines":[{"line_number":85,"context_line":"def bm_node_get_all(context, service_host\u003dNone, associated\u003dNone):"},{"line_number":86,"context_line":"    query \u003d model_query(context, models.BareMetalNode, read_deleted\u003d\"no\")"},{"line_number":87,"context_line":"    if service_host:"},{"line_number":88,"context_line":"        query \u003d query.filter_by(service_host\u003dservice_host)"},{"line_number":89,"context_line":"    if associated \u003d\u003d True:"},{"line_number":90,"context_line":"        query \u003d query.filter(models.BareMetalNode.instance_uuid !\u003d None)"},{"line_number":91,"context_line":"    elif associated \u003d\u003d False:"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAM3%2F%2B%2BQ8%3D","line":88,"in_reply_to":"AAAAM3%2F%2FAVc%3D","updated":"2013-02-12 20:15:47.000000000","message":"Done","commit_id":"fc6220f332a9f29f091078b72489cca0ed0c0c1b"}],"nova/virt/baremetal/driver.py":[{"author":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"change_message_id":"72a290d030c9c968765d29c2db09829125515fc7","unresolved":false,"context_lines":[{"line_number":81,"context_line":"    firewall.__name__,"},{"line_number":82,"context_line":"    firewall.NoopFirewallDriver.__name__)"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"def _get_baremetal_nodes(context, associated\u003dNone):"},{"line_number":86,"context_line":"    nodes \u003d db.bm_node_get_all(context,"},{"line_number":87,"context_line":"                               service_host\u003dCONF.host,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAM3%2F%2FAU8%3D","line":84,"updated":"2013-02-11 21:16:20.000000000","message":"This method looks fairly uninteresting. What is it for?","commit_id":"fc6220f332a9f29f091078b72489cca0ed0c0c1b"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"790b5ffb3e716bb6d49ece9f2552a95be82be24d","unresolved":false,"context_lines":[{"line_number":81,"context_line":"    firewall.__name__,"},{"line_number":82,"context_line":"    firewall.NoopFirewallDriver.__name__)"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"def _get_baremetal_nodes(context, associated\u003dNone):"},{"line_number":86,"context_line":"    nodes \u003d db.bm_node_get_all(context,"},{"line_number":87,"context_line":"                               service_host\u003dCONF.host,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAM3%2F%2B%2BRE%3D","line":84,"in_reply_to":"AAAAM3%2F%2FAU8%3D","updated":"2013-02-12 20:15:47.000000000","message":"removed","commit_id":"fc6220f332a9f29f091078b72489cca0ed0c0c1b"}]}