)]}'
{"nova/api/openstack/compute/legacy_v2/contrib/server_groups.py":[{"author":{"_account_id":17139,"name":"Chuck Carmack","email":"carmack@us.ibm.com","username":"ccarmack"},"change_message_id":"85e51120af1d90d1d39dc9a0380151986c9b2ee0","unresolved":false,"context_lines":[{"line_number":110,"context_line":"                utils.check_string_length(value, field,"},{"line_number":111,"context_line":"                                          min_length\u003d1, max_length\u003d255)"},{"line_number":112,"context_line":"                if not common.VALID_NAME_REGEX.search(value):"},{"line_number":113,"context_line":"                    msg \u003d _(\"Invalid format for name: \u0027%s\u0027. Names can only \""},{"line_number":114,"context_line":"                            \"contain alphanumeric characters, dashes, \""},{"line_number":115,"context_line":"                            \"underscores, periods, and spaces and cannot \""},{"line_number":116,"context_line":"                            \"begin or end with a space.\") % value"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa1b9901_b94a4226","line":113,"updated":"2015-08-22 16:14:37.000000000","message":"Would it be better to have a function in nova.api.validation.parameter_types return the error message?  That would put the error message in the same module as the regex.","commit_id":"762f5d3403e3761a32ddec67613215ec53a10507"},{"author":{"_account_id":17139,"name":"Chuck Carmack","email":"carmack@us.ibm.com","username":"ccarmack"},"change_message_id":"5cac7b5fad44f47754b7eaa86cd54a43e27063e9","unresolved":false,"context_lines":[{"line_number":111,"context_line":"                                          min_length\u003d1, max_length\u003d255)"},{"line_number":112,"context_line":"                if not common.VALID_NAME_REGEX.search(value):"},{"line_number":113,"context_line":"                    msg \u003d _(\"Invalid format for name: \u0027%s\u0027. Names can only \""},{"line_number":114,"context_line":"                            \"contain alphanumeric characters, dashes, \""},{"line_number":115,"context_line":"                            \"underscores, periods, and spaces and cannot \""},{"line_number":116,"context_line":"                            \"begin or end with a space.\") % value"},{"line_number":117,"context_line":"                    raise nova.exception.InvalidInput(reason\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa1b9901_be5d484a","line":114,"updated":"2015-08-22 15:52:04.000000000","message":"I was reading the code for common.VALID_NAME_REGEX and it seems like more characters are allowed.\n\nhttps://github.com/openstack/nova/blob/master/nova/api/validation/parameter_types.py#L25\n\nFor example, a \u0027:\u0027 would be allowed, along with all printable unicode chars.","commit_id":"762f5d3403e3761a32ddec67613215ec53a10507"}]}