)]}'
{"nova/scheduler/host_manager.py":[{"author":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"change_message_id":"dc10d67b5163d41e464ccb3adeec944630e5e585","unresolved":false,"context_lines":[{"line_number":368,"context_line":"        \"\"\""},{"line_number":369,"context_line":""},{"line_number":370,"context_line":"        # Get resource usage across the available compute nodes:"},{"line_number":371,"context_line":"        compute_nodes \u003d db.compute_node_get_all(context)"},{"line_number":372,"context_line":"        dead_compute_nodes \u003d self.host_state_map.keys()"},{"line_number":373,"context_line":"        for compute in compute_nodes:"},{"line_number":374,"context_line":"            service \u003d compute[\u0027service\u0027]"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAM3%2F%2FAaU%3D","line":371,"updated":"2013-02-11 20:39:14.000000000","message":"This will work but is a bit more computation work. What do you think of:\n\nseen_nodes \u003d set()\n...\nhost_state.update_from_compute_node(compute)\nseen_nodes.add(state_key)\n...\ngone_nodes \u003d set(self.host_state_map.keys()) - seen_nodes\nfor state_key in gone_nodes:\n    ...\n\nThis will avoid a try:except: in the inner loop, and resizing a list on each pass.","commit_id":"dd19bda67eb37424158f28243897c53b1c9b99c4"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"a87c15b6d10942430842aad5798e3dbed0fb1254","unresolved":false,"context_lines":[{"line_number":368,"context_line":"        \"\"\""},{"line_number":369,"context_line":""},{"line_number":370,"context_line":"        # Get resource usage across the available compute nodes:"},{"line_number":371,"context_line":"        compute_nodes \u003d db.compute_node_get_all(context)"},{"line_number":372,"context_line":"        dead_compute_nodes \u003d self.host_state_map.keys()"},{"line_number":373,"context_line":"        for compute in compute_nodes:"},{"line_number":374,"context_line":"            service \u003d compute[\u0027service\u0027]"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAM3%2F%2FAFQ%3D","line":371,"in_reply_to":"AAAAM3%2F%2FAaU%3D","updated":"2013-02-11 22:53:12.000000000","message":"that\u0027s actually how I did it at first... but thought this looked better. I\u0027ll revert.","commit_id":"dd19bda67eb37424158f28243897c53b1c9b99c4"}],"nova/tests/scheduler/test_host_manager.py":[{"author":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"change_message_id":"dc10d67b5163d41e464ccb3adeec944630e5e585","unresolved":false,"context_lines":[{"line_number":283,"context_line":""},{"line_number":284,"context_line":"    def tearDown(self):"},{"line_number":285,"context_line":"        timeutils.clear_time_override()"},{"line_number":286,"context_line":"        super(HostManagerChangedNodesTestCase, self).tearDown()"},{"line_number":287,"context_line":""},{"line_number":288,"context_line":"    def test_get_all_host_states(self):"},{"line_number":289,"context_line":"        context \u003d \u0027fake_context\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAM3%2F%2FAaM%3D","line":286,"updated":"2013-02-11 20:39:14.000000000","message":"Please - no tearDown.\njust put\nself.addCleanup(timeutils.clear_time_override)\n\nto the end of setUp.","commit_id":"dd19bda67eb37424158f28243897c53b1c9b99c4"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"a87c15b6d10942430842aad5798e3dbed0fb1254","unresolved":false,"context_lines":[{"line_number":283,"context_line":""},{"line_number":284,"context_line":"    def tearDown(self):"},{"line_number":285,"context_line":"        timeutils.clear_time_override()"},{"line_number":286,"context_line":"        super(HostManagerChangedNodesTestCase, self).tearDown()"},{"line_number":287,"context_line":""},{"line_number":288,"context_line":"    def test_get_all_host_states(self):"},{"line_number":289,"context_line":"        context \u003d \u0027fake_context\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAM3%2F%2FAE4%3D","line":286,"in_reply_to":"AAAAM3%2F%2FAaM%3D","updated":"2013-02-11 22:53:12.000000000","message":"was just copied from elsewhere in this file. Will fix both ...","commit_id":"dd19bda67eb37424158f28243897c53b1c9b99c4"}]}