)]}'
{"nova/compute/resource_tracker.py":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"c0e7a086fdcf19123d603811204322e1f4b83c6a","unresolved":false,"context_lines":[{"line_number":55,"context_line":""},{"line_number":56,"context_line":"allocation_ratio_opts \u003d ["},{"line_number":57,"context_line":"    cfg.FloatOpt(\u0027cpu_allocation_ratio\u0027,"},{"line_number":58,"context_line":"        default\u003d16.0,"},{"line_number":59,"context_line":"        help\u003d\u0027Virtual CPU to physical CPU allocation ratio which affects \u0027"},{"line_number":60,"context_line":"             \u0027all CPU filters. This configuration specifies a global ratio \u0027"},{"line_number":61,"context_line":"             \u0027for CoreFilter. For AggregateCoreFilter, it will fall back to \u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"da20952f_8d65a846","line":58,"updated":"2015-08-27 10:42:38.000000000","message":"I have a feeling we should default this to None, so we can tell when this config is being set or not.","commit_id":"a7c91430261f2f534e0eef1cbea5749c99e1ccaa"},{"author":{"_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},"change_message_id":"26742b6b3e6a73e2fe70c0fd88ae1ef64df980df","unresolved":false,"context_lines":[{"line_number":55,"context_line":""},{"line_number":56,"context_line":"allocation_ratio_opts \u003d ["},{"line_number":57,"context_line":"    cfg.FloatOpt(\u0027cpu_allocation_ratio\u0027,"},{"line_number":58,"context_line":"        default\u003d16.0,"},{"line_number":59,"context_line":"        help\u003d\u0027Virtual CPU to physical CPU allocation ratio which affects \u0027"},{"line_number":60,"context_line":"             \u0027all CPU filters. This configuration specifies a global ratio \u0027"},{"line_number":61,"context_line":"             \u0027for CoreFilter. For AggregateCoreFilter, it will fall back to \u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"da20952f_a862dad6","line":58,"in_reply_to":"da20952f_8d65a846","updated":"2015-08-27 10:47:13.000000000","message":"can we change the default just like that? We need to make sure that we are handling None in the scheduler too then at the very least.","commit_id":"a7c91430261f2f534e0eef1cbea5749c99e1ccaa"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"c0e7a086fdcf19123d603811204322e1f4b83c6a","unresolved":false,"context_lines":[{"line_number":100,"context_line":"        self.old_resources \u003d objects.ComputeNode()"},{"line_number":101,"context_line":"        self.scheduler_client \u003d scheduler_client.SchedulerClient()"},{"line_number":102,"context_line":"        self.ram_allocation_ratio \u003d CONF.ram_allocation_ratio"},{"line_number":103,"context_line":"        self.cpu_allocation_ratio \u003d CONF.cpu_allocation_ratio"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"    @utils.synchronized(COMPUTE_RESOURCE_SEMAPHORE)"},{"line_number":106,"context_line":"    def instance_claim(self, context, instance_ref, limits\u003dNone):"}],"source_content_type":"text/x-python","patch_set":3,"id":"da20952f_4dbb1073","line":103,"updated":"2015-08-27 10:42:38.000000000","message":"here we are then sending None, unless the config has been set.\n\nSo on the scheduler side, it can keep the defaults (just for this release), so we can know if the config is set on the compute node.\n\nWhen we drop that compat code, we can move the defaults back into here, so it make sense.","commit_id":"a7c91430261f2f534e0eef1cbea5749c99e1ccaa"},{"author":{"_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},"change_message_id":"42316cbdb4e12c613685fceefd1b8383c5ee4276","unresolved":false,"context_lines":[{"line_number":350,"context_line":""},{"line_number":351,"context_line":"        # update the allocation ratios for the related ComputeNode object"},{"line_number":352,"context_line":"        self.compute_node.ram_allocation_ratio \u003d self.ram_allocation_ratio"},{"line_number":353,"context_line":"        self.compute_node.cpu_allocation_ratio \u003d self.cpu_allocation_ratio"},{"line_number":354,"context_line":""},{"line_number":355,"context_line":"        # now copy rest to compute_node"},{"line_number":356,"context_line":"        self.compute_node.update_from_virt_driver(resources)"}],"source_content_type":"text/x-python","patch_set":3,"id":"da20952f_2d449c72","line":353,"updated":"2015-08-27 10:43:51.000000000","message":"So the problem with this is that we have to roll out the conf change at the same time with the code update.\n\nOtherwise the compute nodes will start reporting a random value (default?) that was in their conf.\n\nNot sure if this is in line with our upgrade policy. definitely needs a massive Upgrade impact release not. I am not cool with this hand-wavey approach really.","commit_id":"a7c91430261f2f534e0eef1cbea5749c99e1ccaa"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"2b853a2303d629a2163efe238f48b77042199c8f","unresolved":false,"context_lines":[{"line_number":55,"context_line":""},{"line_number":56,"context_line":"allocation_ratio_opts \u003d ["},{"line_number":57,"context_line":"    cfg.FloatOpt(\u0027cpu_allocation_ratio\u0027,"},{"line_number":58,"context_line":"        default\u003d0.0,"},{"line_number":59,"context_line":"        help\u003d\u0027Virtual CPU to physical CPU allocation ratio which affects \u0027"},{"line_number":60,"context_line":"             \u0027all CPU filters. This configuration specifies a global ratio \u0027"},{"line_number":61,"context_line":"             \u0027for CoreFilter. For AggregateCoreFilter, it will fall back to \u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"da20952f_56d153cc","line":58,"updated":"2015-08-27 15:31:02.000000000","message":"I had assumed we would update the defaults in this change, but this is fine.","commit_id":"9c4e0e55aebf2ea14b23d15bfc72e73850be02e2"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"62e70b9e695d0cf86bc85b68201511c1810c0fd9","unresolved":false,"context_lines":[{"line_number":55,"context_line":""},{"line_number":56,"context_line":"allocation_ratio_opts \u003d ["},{"line_number":57,"context_line":"    cfg.FloatOpt(\u0027cpu_allocation_ratio\u0027,"},{"line_number":58,"context_line":"        default\u003d0.0,"},{"line_number":59,"context_line":"        help\u003d\u0027Virtual CPU to physical CPU allocation ratio which affects \u0027"},{"line_number":60,"context_line":"             \u0027all CPU filters. This configuration specifies a global ratio \u0027"},{"line_number":61,"context_line":"             \u0027for CoreFilter. For AggregateCoreFilter, it will fall back to \u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"da20952f_098139c3","line":58,"in_reply_to":"da20952f_56d153cc","updated":"2015-08-28 17:02:45.000000000","message":"I think we had to do it in the previous patch, otherwise we could be writing the new default into the database as soon as we add that behavior, and before we start reporting it.","commit_id":"9c4e0e55aebf2ea14b23d15bfc72e73850be02e2"}]}