)]}'
{"nova/scheduler/filters/core_filter.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"642300ae96398d3b1d450219c5551c3325ff7c56","unresolved":false,"context_lines":[{"line_number":98,"context_line":"    def _get_cpu_allocation_ratio(self, host_state, filter_properties):"},{"line_number":99,"context_line":"        cpu_ratio \u003d (host_state.cpu_allocation_ratio"},{"line_number":100,"context_line":"                     if host_state.cpu_allocation_ratio"},{"line_number":101,"context_line":"                     else CONF.cpu_allocation_ratio)"},{"line_number":102,"context_line":"        aggregate_vals \u003d utils.aggregate_values_from_key("},{"line_number":103,"context_line":"            host_state,"},{"line_number":104,"context_line":"            \u0027cpu_allocation_ratio\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa1b9901_871e896e","line":101,"updated":"2015-08-25 16:29:53.000000000","message":"See, you could drop this sort of logic if you default the values during load...","commit_id":"99a7ffdbc164feceb904f0c201706ab831dbfd02"},{"author":{"_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},"change_message_id":"e652b43841ac6456d20d3a062d066696c6e8c9f0","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":"# TODO(sbauza): Remove the import once all compute nodes are reporting the"},{"line_number":30,"context_line":"# allocation ratio to the HostState"},{"line_number":31,"context_line":"CONF.import_opt(\u0027cpu_allocation_ratio\u0027, \u0027nova.compute.resource_tracker\u0027)"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"class BaseCoreFilter(filters.BaseHostFilter):"}],"source_content_type":"text/x-python","patch_set":3,"id":"da20952f_33774804","side":"PARENT","line":31,"updated":"2015-08-26 17:31:10.000000000","message":"As commented on the first patch - this is really not backwards compatible.\n\nAt the very least it needs a massive DocImpact saying - THIS CONFIG NOW NEEDS TO BE ON COMPUTE NODES INSTEAD","commit_id":"a7c91430261f2f534e0eef1cbea5749c99e1ccaa"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"96594fc1222d99c95fde3021c3d0a296f0e8db33","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":"# TODO(sbauza): Remove the import once all compute nodes are reporting the"},{"line_number":30,"context_line":"# allocation ratio to the HostState"},{"line_number":31,"context_line":"CONF.import_opt(\u0027cpu_allocation_ratio\u0027, \u0027nova.compute.resource_tracker\u0027)"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"class BaseCoreFilter(filters.BaseHostFilter):"}],"source_content_type":"text/x-python","patch_set":3,"id":"da20952f_6755f11b","side":"PARENT","line":31,"in_reply_to":"da20952f_33774804","updated":"2015-08-26 21:15:49.000000000","message":"As said in the other change, this is identified in the ReleaseNotes :\n\nhttps://wiki.openstack.org/wiki/ReleaseNotes/Liberty#Upgrade_Notes\n\nFor sure, I can leave UpgradeImpact and DocImpact if that makes the operators more happy.","commit_id":"a7c91430261f2f534e0eef1cbea5749c99e1ccaa"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"9aee944a0fd6d2b499fe3e719ec8d2b4a75d2f5b","unresolved":false,"context_lines":[{"line_number":77,"context_line":"    \"\"\"CoreFilter filters based on CPU core utilization.\"\"\""},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    def _get_cpu_allocation_ratio(self, host_state, filter_properties):"},{"line_number":80,"context_line":"        return host_state.cpu_allocation_ratio"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"class AggregateCoreFilter(BaseCoreFilter):"}],"source_content_type":"text/x-python","patch_set":3,"id":"da20952f_8d4fe891","line":80,"updated":"2015-08-27 10:43:48.000000000","message":"I think we should check to see if host_state.cpu_allocation_ratio \u003d\u003d None, and in that case, still use: CONF.cpu_allocation_ratio","commit_id":"f635f2975d990d298b9be35f31321817ee55e555"}],"nova/scheduler/ironic_host_manager.py":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"7c7cadab49b8f719b349dc5be26c4d1a6c3863ba","unresolved":false,"context_lines":[{"line_number":84,"context_line":""},{"line_number":85,"context_line":"        # update allocation ratios given by the ComputeNode object"},{"line_number":86,"context_line":"        self.cpu_allocation_ratio \u003d compute.cpu_allocation_ratio"},{"line_number":87,"context_line":"        self.ram_allocation_ratio \u003d compute.ram_allocation_ratio"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"        self.updated \u003d compute.updated_at"},{"line_number":90,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"da20952f_7ab76c86","line":87,"updated":"2015-08-28 10:41:27.000000000","message":"Nit: it would be nicer if this happened in a base class, but this is locally consistent, so lets go with it.","commit_id":"add881205aea33909a619a1b215dea247a15ca04"}]}