)]}'
{"nova/objects/base.py":[{"author":{"_account_id":11803,"name":"Ryan Rossiter","email":"rlrossit@us.ibm.com","username":"rlrossiter"},"change_message_id":"1970c0c4e58ee782148b2bc79cf528fd06a01882","unresolved":false,"context_lines":[{"line_number":49,"context_line":"        if not hasattr(objects, cls.obj_name()):"},{"line_number":50,"context_line":"            setattr(objects, cls.obj_name(), cls)"},{"line_number":51,"context_line":"        else:"},{"line_number":52,"context_line":"            # NOTE(danms): Set the *latest* version of this class"},{"line_number":53,"context_line":"            cur_version \u003d utils.convert_version_to_tuple("},{"line_number":54,"context_line":"                getattr(objects, cls.obj_name()).VERSION)"},{"line_number":55,"context_line":"            if version \u003e\u003d cur_version:"}],"source_content_type":"text/x-python","patch_set":3,"id":"da20952f_8d2ebaf8","line":52,"updated":"2015-09-03 18:03:04.000000000","message":"I originally read this comment and did not understand what was going on below (I didn\u0027t realize that this comment existed in the old version). I would update the comment to say something like \"Set the class to the version being registered only if it is newer than the existing version.\"","commit_id":"a0f371d3ca0a7f8fe7628d6cdd5dbd2c3f618698"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"636391f0f20e0cdc57f409d303d3219f5e85205f","unresolved":false,"context_lines":[{"line_number":49,"context_line":"        if not hasattr(objects, cls.obj_name()):"},{"line_number":50,"context_line":"            setattr(objects, cls.obj_name(), cls)"},{"line_number":51,"context_line":"        else:"},{"line_number":52,"context_line":"            # NOTE(danms): Set the *latest* version of this class"},{"line_number":53,"context_line":"            cur_version \u003d utils.convert_version_to_tuple("},{"line_number":54,"context_line":"                getattr(objects, cls.obj_name()).VERSION)"},{"line_number":55,"context_line":"            if version \u003e\u003d cur_version:"}],"source_content_type":"text/x-python","patch_set":3,"id":"da20952f_6966b552","line":52,"in_reply_to":"da20952f_8d2ebaf8","updated":"2015-09-03 18:31:10.000000000","message":"Well, that detail is in the code and fairly non-obvious. I don\u0027t think this comment is wrong, although maybe there should just be a comment at the top of this that explains what we\u0027re doing in general here. The code is certainly follow-able otherwise.","commit_id":"a0f371d3ca0a7f8fe7628d6cdd5dbd2c3f618698"},{"author":{"_account_id":11803,"name":"Ryan Rossiter","email":"rlrossit@us.ibm.com","username":"rlrossiter"},"change_message_id":"1970c0c4e58ee782148b2bc79cf528fd06a01882","unresolved":false,"context_lines":[{"line_number":52,"context_line":"            # NOTE(danms): Set the *latest* version of this class"},{"line_number":53,"context_line":"            cur_version \u003d utils.convert_version_to_tuple("},{"line_number":54,"context_line":"                getattr(objects, cls.obj_name()).VERSION)"},{"line_number":55,"context_line":"            if version \u003e\u003d cur_version:"},{"line_number":56,"context_line":"                setattr(objects, cls.obj_name(), cls)"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"da20952f_595e24ea","line":55,"updated":"2015-09-03 18:03:04.000000000","message":"should this be version \u003e cur_version? I don\u0027t know what situation we would be getting into if we\u0027re registering a version that is the same version, but do we want to bulldoze the already registered class?","commit_id":"a0f371d3ca0a7f8fe7628d6cdd5dbd2c3f618698"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"7cc91aa559b055b4617cee267d523483978c41d3","unresolved":false,"context_lines":[{"line_number":52,"context_line":"            # NOTE(danms): Set the *latest* version of this class"},{"line_number":53,"context_line":"            cur_version \u003d utils.convert_version_to_tuple("},{"line_number":54,"context_line":"                getattr(objects, cls.obj_name()).VERSION)"},{"line_number":55,"context_line":"            if version \u003e\u003d cur_version:"},{"line_number":56,"context_line":"                setattr(objects, cls.obj_name(), cls)"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"da20952f_29843d09","line":55,"in_reply_to":"da20952f_595e24ea","updated":"2015-09-03 18:28:13.000000000","message":"We would have this if we\u0027re registering an alternate implementation of a class, in which case, yeah, we\u0027d want to blow away the existing one of the same version.","commit_id":"a0f371d3ca0a7f8fe7628d6cdd5dbd2c3f618698"}]}