)]}'
{"nova/virt/driver.py":[{"author":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"change_message_id":"966788292e2e8f4a1cc4a2171efc442d9e45987f","unresolved":false,"context_lines":[{"line_number":873,"context_line":"        The queue can later be dispatched by a call to the"},{"line_number":874,"context_line":"        emit_queued_events method, from a green thread.\"\"\""},{"line_number":875,"context_line":""},{"line_number":876,"context_line":"        if not self._compute_event_callback:"},{"line_number":877,"context_line":"            return"},{"line_number":878,"context_line":""},{"line_number":879,"context_line":"        if not isinstance(event, virtevent.Event):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2B%2BP0%3D","line":876,"updated":"2013-02-12 20:29:02.000000000","message":"Looks like we don\u0027t want to queue events if no one is listening for it. can we log/debug that we are dropping the event? do we need a test for enforcing this behavior?","commit_id":"4965471aef52ce2a3af54b199d4849ab26d3d94a"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"6c6d959bdc874838cf101a78bc17124d1a095d94","unresolved":false,"context_lines":[{"line_number":880,"context_line":"        try:"},{"line_number":881,"context_line":"            LOG.debug(\"Emitting event %s\" % str(event))"},{"line_number":882,"context_line":"            self._compute_event_callback(event)"},{"line_number":883,"context_line":"        except Exception, ex:"},{"line_number":884,"context_line":"            LOG.error(_(\"Exception dispatching event %(event)s: %(ex)s\")"},{"line_number":885,"context_line":"                        % locals())"},{"line_number":886,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAM3%2F%2Bx2c%3D","line":883,"updated":"2013-02-19 13:58:16.000000000","message":"shouldn\u0027t this be \nexcept Exception as ex:","commit_id":"9cf52c227058145b1bca941d19d7991aafcb4947"},{"author":{"_account_id":1812,"name":"p-draigbrady","email":"P@draigBrady.com","username":"p-draigbrady"},"change_message_id":"b1954840de25a630fbb0e255d1fbbb47430eb4ba","unresolved":false,"context_lines":[{"line_number":880,"context_line":"        try:"},{"line_number":881,"context_line":"            LOG.debug(\"Emitting event %s\" % str(event))"},{"line_number":882,"context_line":"            self._compute_event_callback(event)"},{"line_number":883,"context_line":"        except Exception, ex:"},{"line_number":884,"context_line":"            LOG.error(_(\"Exception dispatching event %(event)s: %(ex)s\")"},{"line_number":885,"context_line":"                        % locals())"},{"line_number":886,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAM3%2F%2Bx0Y%3D","line":883,"in_reply_to":"AAAAM3%2F%2Bx2c%3D","updated":"2013-02-19 14:03:30.000000000","message":"I noticed that, but using \"as\" is only the preferred more modern style.\nThere are many other cases of Exception, in the source.\nSomething for a large change + pep addition I think","commit_id":"9cf52c227058145b1bca941d19d7991aafcb4947"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"4c638c84e6c43fd89ec0880158472d5e4be912bd","unresolved":false,"context_lines":[{"line_number":880,"context_line":"        try:"},{"line_number":881,"context_line":"            LOG.debug(\"Emitting event %s\" % str(event))"},{"line_number":882,"context_line":"            self._compute_event_callback(event)"},{"line_number":883,"context_line":"        except Exception, ex:"},{"line_number":884,"context_line":"            LOG.error(_(\"Exception dispatching event %(event)s: %(ex)s\")"},{"line_number":885,"context_line":"                        % locals())"},{"line_number":886,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAM3%2F%2Bx0A%3D","line":883,"in_reply_to":"AAAAM3%2F%2Bx2c%3D","updated":"2013-02-19 14:06:53.000000000","message":"Why ? Nova code seems to have a good mixture of \u0027,\u0027 and \u0027as\u0027 for separators \u0026 AFAIK they both work fine \u0026 our PEP checks don\u0027t seem to enforce one style.","commit_id":"9cf52c227058145b1bca941d19d7991aafcb4947"}]}