)]}'
{"nova/tests/test_migrations.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"89ca7bdcb7797234d421e4afe9d20699cec2e5fd","unresolved":false,"context_lines":[{"line_number":549,"context_line":"        task_log \u003d get_table(engine, \u0027task_log\u0027)"},{"line_number":550,"context_line":"        row \u003d task_log.select(task_log.c.id \u003d\u003d data[\u0027id\u0027]).execute().first()"},{"line_number":551,"context_line":"        self.assertEqual("},{"line_number":552,"context_line":"            data[\u0027period_beginning\u0027], str(row[\u0027period_beginning\u0027]))"},{"line_number":553,"context_line":"        self.assertEqual(data[\u0027period_ending\u0027], str(row[\u0027period_ending\u0027]))"},{"line_number":554,"context_line":""},{"line_number":555,"context_line":"    # migration 152 - convert deleted from boolean to int"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAM3%2F%2B%2BGw%3D","line":552,"updated":"2013-02-12 21:24:45.000000000","message":"This doesn\u0027t test that it\u0027s a datetime, right? It tests that whatever we got back, when converted to string (which could be a unity operation), matches what we put in. Since we put in a string, wouldn\u0027t this still pass if I were to remove the migration entirely?\n\nIMHO, at the very least you should check that the two elements are instances of the right class.","commit_id":"7df2bb783972c3ca089960865fceb3adddb00b57"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"864ec7f4fc71f8c692fec0e6cfced3c8b36280f2","unresolved":false,"context_lines":[{"line_number":550,"context_line":"        row \u003d task_log.select(task_log.c.id \u003d\u003d data[\u0027id\u0027]).execute().first()"},{"line_number":551,"context_line":"        self.assertFalse("},{"line_number":552,"context_line":"            isinstance(row[\u0027period_beginning\u0027], datetime.datetime))"},{"line_number":553,"context_line":"        self.assertFalse(isinstance(row[\u0027period_ending\u0027], datetime.datetime))"},{"line_number":554,"context_line":"        self.assertEqual("},{"line_number":555,"context_line":"                data[\u0027period_beginning\u0027], str(row[\u0027period_beginning\u0027]))"},{"line_number":556,"context_line":"        self.assertEqual(data[\u0027period_ending\u0027], str(row[\u0027period_ending\u0027]))"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAM3%2F%2B92k%3D","line":553,"updated":"2013-02-12 23:26:49.000000000","message":"I\u0027m confused, aren\u0027t they *supposed* to be datetimes? Your comment above indicates that they are.","commit_id":"c1480fe0473eef4a1a4e78590a9d1a8e818cb5e3"},{"author":{"_account_id":5660,"name":"Kurt Taylor","email":"kurt.r.taylor@gmail.com","username":"krtaylor"},"change_message_id":"69e4937e4ab945d233f6254ab00a559622fe8a6e","unresolved":false,"context_lines":[{"line_number":550,"context_line":"        row \u003d task_log.select(task_log.c.id \u003d\u003d data[\u0027id\u0027]).execute().first()"},{"line_number":551,"context_line":"        self.assertFalse("},{"line_number":552,"context_line":"            isinstance(row[\u0027period_beginning\u0027], datetime.datetime))"},{"line_number":553,"context_line":"        self.assertFalse(isinstance(row[\u0027period_ending\u0027], datetime.datetime))"},{"line_number":554,"context_line":"        self.assertEqual("},{"line_number":555,"context_line":"                data[\u0027period_beginning\u0027], str(row[\u0027period_beginning\u0027]))"},{"line_number":556,"context_line":"        self.assertEqual(data[\u0027period_ending\u0027], str(row[\u0027period_ending\u0027]))"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAM3%2F%2B91c%3D","line":553,"in_reply_to":"AAAAM3%2F%2B92k%3D","updated":"2013-02-13 00:01:19.000000000","message":"They should be DateTime, and not str(datetime.datetime()) if migrated properly, this is not what I meant in either case, fixing. \n\nI\u0027ll just assertTrue for DateTime instead.\n\nAlso, I had an incorrect indent below.","commit_id":"c1480fe0473eef4a1a4e78590a9d1a8e818cb5e3"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"c01f7496d8c9b6215a7101be68661170e622af0e","unresolved":false,"context_lines":[{"line_number":550,"context_line":"        # note(krtaylor): postgres does not support explicit casting in the"},{"line_number":551,"context_line":"        # migration"},{"line_number":552,"context_line":"        dialect \u003d engine.url.get_dialect()"},{"line_number":553,"context_line":"        if dialect is not sqlalchemy.dialects.postgresql.dialect:"},{"line_number":554,"context_line":"            self.assertTrue(isinstance(row[\u0027period_beginning\u0027],"},{"line_number":555,"context_line":"                datetime.datetime))"},{"line_number":556,"context_line":"            self.assertTrue(isinstance(row[\u0027period_ending\u0027],"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAM3%2F%2B8pA%3D","line":553,"updated":"2013-02-13 16:38:01.000000000","message":"I don\u0027t think this is right. I think postgres should be on datetime columns, but just that the migration had to be done differently for it (i.e. not using the migrate_engine) right?","commit_id":"c7b8058bd00c492a50ba51c82bf371dc1697333e"}]}