)]}'
{"nova/objects/block_device.py":[{"author":{"_account_id":10224,"name":"Feodor Tersin","email":"ftersin@hotmail.com","username":"ftersin"},"change_message_id":"833d2cf35ac93a0576ce020ab25c33759e7dbbac","unresolved":false,"context_lines":[{"line_number":195,"context_line":"            # likely does not exist in the parent cell and we should create it."},{"line_number":196,"context_line":"            # If this is a modification of the device name we should update"},{"line_number":197,"context_line":"            # rather than create which is why None is used here instead of True"},{"line_number":198,"context_line":"            if \u0027device_name\u0027 in updates:"},{"line_number":199,"context_line":"                create \u003d None"},{"line_number":200,"context_line":"            cells_api \u003d cells_rpcapi.CellsAPI()"},{"line_number":201,"context_line":"            cells_api.bdm_update_or_create_at_top(self._context, self,"}],"source_content_type":"text/x-python","patch_set":1,"id":"da20952f_d11bd671","line":198,"updated":"2015-08-29 06:08:55.000000000","message":"I hope there is no case when device_name has been updated to None and bdm.save() is called","commit_id":"5e7dc40041d2870560b96b48f90a75f26642a234"},{"author":{"_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},"change_message_id":"25cf7136b917aeae3e282881602f2b71259d3ca8","unresolved":false,"context_lines":[{"line_number":195,"context_line":"            # likely does not exist in the parent cell and we should create it."},{"line_number":196,"context_line":"            # If this is a modification of the device name we should update"},{"line_number":197,"context_line":"            # rather than create which is why None is used here instead of True"},{"line_number":198,"context_line":"            if \u0027device_name\u0027 in updates:"},{"line_number":199,"context_line":"                create \u003d None"},{"line_number":200,"context_line":"            cells_api \u003d cells_rpcapi.CellsAPI()"},{"line_number":201,"context_line":"            cells_api.bdm_update_or_create_at_top(self._context, self,"}],"source_content_type":"text/x-python","patch_set":1,"id":"da20952f_d2adf384","line":198,"in_reply_to":"da20952f_d11bd671","updated":"2015-08-31 09:48:22.000000000","message":"There isn\u0027t - but there is a save now when defaulting device names on boot (basically it happens every time with the libvirt driver because of this https://review.openstack.org/#/c/189632/) so the race we are hitting here may have been made worse by that fact.","commit_id":"5e7dc40041d2870560b96b48f90a75f26642a234"}]}
