)]}'
{"nova/compute/api.py":[{"author":{"_account_id":20223,"name":"zhaolihui","email":"zhaolh@awcloud.com","username":"zhaolihui"},"change_message_id":"40d06558c452130a55c202a014d4fba816562d4f","unresolved":false,"context_lines":[{"line_number":121,"context_line":"                    attr\u003d\u0027vm_state\u0027,"},{"line_number":122,"context_line":"                    instance_uuid\u003dinstance.uuid,"},{"line_number":123,"context_line":"                    state\u003dinstance.vm_state,"},{"line_number":124,"context_line":"                    method\u003df.__name__)"},{"line_number":125,"context_line":"            if (task_state is not None and"},{"line_number":126,"context_line":"                    instance.task_state not in task_state):"},{"line_number":127,"context_line":"                raise exception.InstanceInvalidState("}],"source_content_type":"text/x-python","patch_set":6,"id":"da0c15f0_6664e0e3","side":"PARENT","line":124,"range":{"start_line":124,"start_character":20,"end_line":124,"end_character":37},"updated":"2016-03-28 09:34:51.000000000","message":"When it raise exception, the method name will show to user, otherwise it will not.\nEven the exception was raised, user would not care about that. User only notice that there is a error, and not care about the detail information.\nSo it is no influence to remove the \u0027method\u0027 or not.","commit_id":"b5e65b4356f022d999482bfcc35bbf5c8cc42f8d"}],"nova/compute/manager.py":[{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"3e7ca5df21f33a69bf180377e48a41771a7f91e2","unresolved":false,"context_lines":[{"line_number":3978,"context_line":"                attr\u003d\u0027power_state\u0027,"},{"line_number":3979,"context_line":"                instance_uuid\u003dinstance.uuid,"},{"line_number":3980,"context_line":"                state\u003dinstance.power_state,"},{"line_number":3981,"context_line":"                method\u003d\u0027get_instance_diagnostics\u0027)"},{"line_number":3982,"context_line":""},{"line_number":3983,"context_line":"    @wrap_exception()"},{"line_number":3984,"context_line":"    @reverts_task_state"}],"source_content_type":"text/x-python","patch_set":1,"id":"da20952f_9857a859","line":3981,"updated":"2015-08-31 02:21:40.000000000","message":"I prefer move the \u0027method\u0027. As this will return the end user. The user needn\u0027t know the code detail","commit_id":"25379e6c4271d2202bee13efef3eacdb8d89028f"}],"nova/exception.py":[{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"3e660abb812883a971e935a5b9c64aafca4e333e","unresolved":false,"context_lines":[{"line_number":391,"context_line":""},{"line_number":392,"context_line":"class InstanceInvalidState(Invalid):"},{"line_number":393,"context_line":"    msg_fmt \u003d _(\"Instance %(instance_uuid)s in %(attr)s %(state)s. Cannot \""},{"line_number":394,"context_line":"                \"%(method)s while the instance is in this state.\")"},{"line_number":395,"context_line":""},{"line_number":396,"context_line":""},{"line_number":397,"context_line":"class InstanceNotRunning(Invalid):"}],"source_content_type":"text/x-python","patch_set":2,"id":"da20952f_4e712a0e","side":"PARENT","line":394,"updated":"2015-08-31 15:50:43.000000000","message":"I agree we can\u0027t expose internal method\nbut why we can\u0027t expose operations? such as reboot, start etc\nwhich is operation instead of function method.. we only use function name to represent the operation.","commit_id":"858114bb6b30c872a59bbc6da2bddb56c40af354"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"08fb22146b0bbb2758c68e06025006455ebbb3ad","unresolved":false,"context_lines":[{"line_number":391,"context_line":""},{"line_number":392,"context_line":"class InstanceInvalidState(Invalid):"},{"line_number":393,"context_line":"    msg_fmt \u003d _(\"Instance %(instance_uuid)s in %(attr)s %(state)s. Cannot \""},{"line_number":394,"context_line":"                \"%(method)s while the instance is in this state.\")"},{"line_number":395,"context_line":""},{"line_number":396,"context_line":""},{"line_number":397,"context_line":"class InstanceNotRunning(Invalid):"}],"source_content_type":"text/x-python","patch_set":2,"id":"da20952f_ad9e6c61","side":"PARENT","line":394,"in_reply_to":"da20952f_4e712a0e","updated":"2015-09-02 08:08:00.000000000","message":"i do not understand your comment. the function name at times is not useful to the end user. the end user tried to do X today it may be call X tomorrow we may change it to Y. If this fails and the exception reports X then it will be confusing to the user","commit_id":"858114bb6b30c872a59bbc6da2bddb56c40af354"}]}