)]}'
{"nova/compute/manager.py":[{"author":{"_account_id":14819,"name":"Timofey Durakov","email":"timofei.nd@gmail.com","username":"tdurakov"},"change_message_id":"75977278c7f4b4d96637ec0d1788810b2e9c1e1d","unresolved":false,"context_lines":[{"line_number":6384,"context_line":"                context, inst_filters, expected_attrs\u003dattrs, use_slave\u003dTrue)"},{"line_number":6385,"context_line":""},{"line_number":6386,"context_line":"        for instance in instances:"},{"line_number":6387,"context_line":"            if instance.host !\u003d CONF.host:"},{"line_number":6388,"context_line":"                for migration in migrations:"},{"line_number":6389,"context_line":"                    if instance.uuid \u003d\u003d migration.instance_uuid:"},{"line_number":6390,"context_line":"                        # Delete instance files if not cleanup properly either"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a1a9d01_536feec4","line":6387,"updated":"2015-09-28 15:38:03.000000000","message":"Why are  you cleaning only instances which host field differs from current host?","commit_id":"fa72fb8b51d59e04913c871539cee98a3da79058"}],"nova/tests/compute/test_compute_mgr.py":[{"author":{"_account_id":8213,"name":"Claudiu Belu","email":"claudiu.belu@canonical.com","username":"claudiub"},"change_message_id":"15746e24f4bd537874eb90c35e38b5f4bb417782","unresolved":false,"context_lines":[{"line_number":1177,"context_line":""},{"line_number":1178,"context_line":"        fake_instances \u003d [fake_inst(self.context, \u0027111\u0027, inst_host),"},{"line_number":1179,"context_line":"                          fake_inst(self.context, \u0027222\u0027, inst_host),"},{"line_number":1180,"context_line":"                          fake_inst(self.context, \u0027333\u0027, inst_host)]"},{"line_number":1181,"context_line":""},{"line_number":1182,"context_line":"        fake_migrations \u003d [fake_migration(\u0027123\u0027, \u0027error\u0027, \u0027111\u0027,"},{"line_number":1183,"context_line":"                                          \u0027fake-host\u0027, \u0027fake-mini\u0027),"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba15a1d1_c0f939ca","line":1180,"updated":"2015-09-14 12:04:01.000000000","message":"fake_inst(self.context, \u0027333\u0027, inst_host) is not present in kilo or master. I see no point in adding it here either.","commit_id":"cf59f33c6cdd21bc1591973816d57d5016c50d21"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"43184726eb224f0e67016a1fa7be5d91e42769c6","unresolved":false,"context_lines":[{"line_number":1177,"context_line":""},{"line_number":1178,"context_line":"        fake_instances \u003d [fake_inst(self.context, \u0027111\u0027, inst_host),"},{"line_number":1179,"context_line":"                          fake_inst(self.context, \u0027222\u0027, inst_host),"},{"line_number":1180,"context_line":"                          fake_inst(self.context, \u0027333\u0027, inst_host)]"},{"line_number":1181,"context_line":""},{"line_number":1182,"context_line":"        fake_migrations \u003d [fake_migration(\u0027123\u0027, \u0027error\u0027, \u0027111\u0027,"},{"line_number":1183,"context_line":"                                          \u0027fake-host\u0027, \u0027fake-mini\u0027),"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba15a1d1_203812a0","line":1180,"in_reply_to":"ba15a1d1_c0f939ca","updated":"2015-09-15 05:11:21.000000000","message":"Done","commit_id":"cf59f33c6cdd21bc1591973816d57d5016c50d21"},{"author":{"_account_id":8213,"name":"Claudiu Belu","email":"claudiu.belu@canonical.com","username":"claudiub"},"change_message_id":"15746e24f4bd537874eb90c35e38b5f4bb417782","unresolved":false,"context_lines":[{"line_number":1208,"context_line":"        # instance files could be present on destination node."},{"line_number":1209,"context_line":"        #"},{"line_number":1210,"context_line":"        # This test ensures that `_cleanup_incomplete_migration` periodic"},{"line_number":1211,"context_line":"        # task deletes orphaned instance files from destination compute node."},{"line_number":1212,"context_line":"        self.flags(host\u003d\u0027fake-mini\u0027)"},{"line_number":1213,"context_line":"        self._test_cleanup_incomplete_migrations(\u0027fake-host\u0027)"},{"line_number":1214,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"ba15a1d1_0041710b","line":1211,"updated":"2015-09-14 12:04:01.000000000","message":"these comments should be docstrings, just like in master and kilo.","commit_id":"cf59f33c6cdd21bc1591973816d57d5016c50d21"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"43184726eb224f0e67016a1fa7be5d91e42769c6","unresolved":false,"context_lines":[{"line_number":1208,"context_line":"        # instance files could be present on destination node."},{"line_number":1209,"context_line":"        #"},{"line_number":1210,"context_line":"        # This test ensures that `_cleanup_incomplete_migration` periodic"},{"line_number":1211,"context_line":"        # task deletes orphaned instance files from destination compute node."},{"line_number":1212,"context_line":"        self.flags(host\u003d\u0027fake-mini\u0027)"},{"line_number":1213,"context_line":"        self._test_cleanup_incomplete_migrations(\u0027fake-host\u0027)"},{"line_number":1214,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"ba15a1d1_403bc69c","line":1211,"in_reply_to":"ba15a1d1_0041710b","updated":"2015-09-15 05:11:21.000000000","message":"Done","commit_id":"cf59f33c6cdd21bc1591973816d57d5016c50d21"},{"author":{"_account_id":8213,"name":"Claudiu Belu","email":"claudiu.belu@canonical.com","username":"claudiub"},"change_message_id":"15746e24f4bd537874eb90c35e38b5f4bb417782","unresolved":false,"context_lines":[{"line_number":1221,"context_line":"        # present on source node."},{"line_number":1222,"context_line":"        #"},{"line_number":1223,"context_line":"        # This test ensures that `_cleanup_incomplete_migration` periodic"},{"line_number":1224,"context_line":"        # task deletes orphaned instance files from source compute node."},{"line_number":1225,"context_line":"        self.flags(host\u003d\u0027fake-host\u0027)"},{"line_number":1226,"context_line":"        self._test_cleanup_incomplete_migrations(\u0027fake-mini\u0027)"},{"line_number":1227,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"ba15a1d1_c04b792a","line":1224,"updated":"2015-09-14 12:04:01.000000000","message":"ditto.","commit_id":"cf59f33c6cdd21bc1591973816d57d5016c50d21"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"43184726eb224f0e67016a1fa7be5d91e42769c6","unresolved":false,"context_lines":[{"line_number":1221,"context_line":"        # present on source node."},{"line_number":1222,"context_line":"        #"},{"line_number":1223,"context_line":"        # This test ensures that `_cleanup_incomplete_migration` periodic"},{"line_number":1224,"context_line":"        # task deletes orphaned instance files from source compute node."},{"line_number":1225,"context_line":"        self.flags(host\u003d\u0027fake-host\u0027)"},{"line_number":1226,"context_line":"        self._test_cleanup_incomplete_migrations(\u0027fake-mini\u0027)"},{"line_number":1227,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"ba15a1d1_e041ba0c","line":1224,"in_reply_to":"ba15a1d1_c04b792a","updated":"2015-09-15 05:11:21.000000000","message":"Done","commit_id":"cf59f33c6cdd21bc1591973816d57d5016c50d21"}]}