)]}'
{"nova/compute/manager.py":[{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"258573d90dc14b7587267159d7150ce1bf714e7e","unresolved":false,"context_lines":[{"line_number":2819,"context_line":"        if reboot_type \u003d\u003d \"SOFT\":"},{"line_number":2820,"context_line":"            instance.task_state \u003d task_states.REBOOT_PENDING"},{"line_number":2821,"context_line":"            expected_states \u003d (task_states.REBOOTING,"},{"line_number":2822,"context_line":"                               task_states.REBOOT_PENDING,"},{"line_number":2823,"context_line":"                               task_states.REBOOT_STARTED)"},{"line_number":2824,"context_line":"        else:"},{"line_number":2825,"context_line":"            instance.task_state \u003d task_states.REBOOT_PENDING_HARD"}],"source_content_type":"text/x-python","patch_set":1,"id":"da20952f_d875d297","line":2822,"updated":"2015-09-08 07:04:56.000000000","message":"we can use soft_reboot_states at here also.","commit_id":"6e8834fec82ea3c3430a9ffc87bd3fafa2672a0b"},{"author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"change_message_id":"0a8b83eb4a9e4244e2eb7d622d29e317c6758937","unresolved":false,"context_lines":[{"line_number":2819,"context_line":"        if reboot_type \u003d\u003d \"SOFT\":"},{"line_number":2820,"context_line":"            instance.task_state \u003d task_states.REBOOT_PENDING"},{"line_number":2821,"context_line":"            expected_states \u003d (task_states.REBOOTING,"},{"line_number":2822,"context_line":"                               task_states.REBOOT_PENDING,"},{"line_number":2823,"context_line":"                               task_states.REBOOT_STARTED)"},{"line_number":2824,"context_line":"        else:"},{"line_number":2825,"context_line":"            instance.task_state \u003d task_states.REBOOT_PENDING_HARD"}],"source_content_type":"text/x-python","patch_set":1,"id":"dada55a8_cf78482e","line":2822,"in_reply_to":"9a8ffd7b_4164d020","updated":"2016-07-19 17:34:40.000000000","message":"Done","commit_id":"6e8834fec82ea3c3430a9ffc87bd3fafa2672a0b"},{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"cc16369a0f3826ac5ea1b2de3b1324cb436863bc","unresolved":false,"context_lines":[{"line_number":2819,"context_line":"        if reboot_type \u003d\u003d \"SOFT\":"},{"line_number":2820,"context_line":"            instance.task_state \u003d task_states.REBOOT_PENDING"},{"line_number":2821,"context_line":"            expected_states \u003d (task_states.REBOOTING,"},{"line_number":2822,"context_line":"                               task_states.REBOOT_PENDING,"},{"line_number":2823,"context_line":"                               task_states.REBOOT_STARTED)"},{"line_number":2824,"context_line":"        else:"},{"line_number":2825,"context_line":"            instance.task_state \u003d task_states.REBOOT_PENDING_HARD"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a8ffd7b_4164d020","line":2822,"in_reply_to":"da20952f_d875d297","updated":"2015-12-03 03:53:32.000000000","message":"nice catch","commit_id":"6e8834fec82ea3c3430a9ffc87bd3fafa2672a0b"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"258573d90dc14b7587267159d7150ce1bf714e7e","unresolved":false,"context_lines":[{"line_number":2824,"context_line":"        else:"},{"line_number":2825,"context_line":"            instance.task_state \u003d task_states.REBOOT_PENDING_HARD"},{"line_number":2826,"context_line":"            expected_states \u003d (task_states.REBOOTING_HARD,"},{"line_number":2827,"context_line":"                               task_states.REBOOT_PENDING_HARD,"},{"line_number":2828,"context_line":"                               task_states.REBOOT_STARTED_HARD)"},{"line_number":2829,"context_line":"        context \u003d context.elevated()"},{"line_number":2830,"context_line":"        LOG.info(_LI(\"Rebooting instance\"), context\u003dcontext, instance\u003dinstance)"}],"source_content_type":"text/x-python","patch_set":1,"id":"da20952f_f878d690","line":2827,"updated":"2015-09-08 07:04:56.000000000","message":"we can improve this with similar way.","commit_id":"6e8834fec82ea3c3430a9ffc87bd3fafa2672a0b"},{"author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"change_message_id":"0a8b83eb4a9e4244e2eb7d622d29e317c6758937","unresolved":false,"context_lines":[{"line_number":2824,"context_line":"        else:"},{"line_number":2825,"context_line":"            instance.task_state \u003d task_states.REBOOT_PENDING_HARD"},{"line_number":2826,"context_line":"            expected_states \u003d (task_states.REBOOTING_HARD,"},{"line_number":2827,"context_line":"                               task_states.REBOOT_PENDING_HARD,"},{"line_number":2828,"context_line":"                               task_states.REBOOT_STARTED_HARD)"},{"line_number":2829,"context_line":"        context \u003d context.elevated()"},{"line_number":2830,"context_line":"        LOG.info(_LI(\"Rebooting instance\"), context\u003dcontext, instance\u003dinstance)"}],"source_content_type":"text/x-python","patch_set":1,"id":"dada55a8_2f78042a","line":2827,"in_reply_to":"da20952f_f878d690","updated":"2016-07-19 17:34:40.000000000","message":"Done","commit_id":"6e8834fec82ea3c3430a9ffc87bd3fafa2672a0b"}],"nova/compute/task_states.py":[{"author":{"_account_id":6802,"name":"Joel Coffman","email":"jmc7tp@gmail.com","username":"joel-coffman"},"change_message_id":"647e7089e94ccd0bc938743f67c3674826da702e","unresolved":false,"context_lines":[{"line_number":118,"context_line":""},{"line_number":119,"context_line":"# These states indicate a reboot"},{"line_number":120,"context_line":"soft_reboot_states \u003d (REBOOTING, REBOOT_PENDING, REBOOT_STARTED)"},{"line_number":121,"context_line":"hard_reboot_states \u003d (REBOOTING_HARD, REBOOT_PENDING_HARD, REBOOT_STARTED_HARD)"}],"source_content_type":"text/x-python","patch_set":2,"id":"dada55a8_cfcb1f52","line":121,"updated":"2016-07-19 20:52:48.000000000","message":"For my own edification, why did you use a tuple rather than a list or set?","commit_id":"bb6b7711a1611f6964bd6e23a107075968a832cc"},{"author":{"_account_id":7069,"name":"Joshua Hesketh","email":"josh@nitrotech.org","username":"jhesketh"},"change_message_id":"7db99e41c7d283c10c814adf2205d3b0f8533870","unresolved":false,"context_lines":[{"line_number":118,"context_line":""},{"line_number":119,"context_line":"# These states indicate a reboot"},{"line_number":120,"context_line":"soft_reboot_states \u003d (REBOOTING, REBOOT_PENDING, REBOOT_STARTED)"},{"line_number":121,"context_line":"hard_reboot_states \u003d (REBOOTING_HARD, REBOOT_PENDING_HARD, REBOOT_STARTED_HARD)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a74a57a_be361450","line":121,"in_reply_to":"dada55a8_cfcb1f52","updated":"2016-11-25 03:05:02.000000000","message":"The rest of these globals are  capitalised. Should these be too?","commit_id":"bb6b7711a1611f6964bd6e23a107075968a832cc"}]}