)]}'
{"nova/tests/unit/api/openstack/compute/test_security_groups.py":[{"author":{"_account_id":8688,"name":"Alexis Lee","email":"openstack@lxsli.co.uk","username":"lxsli"},"change_message_id":"b6739baae87c179a98c67947102b0a69fe919b1d","unresolved":false,"context_lines":[{"line_number":829,"context_line":"        res_dict \u003d self.controller.create(self.req,"},{"line_number":830,"context_line":"            {\u0027security_group_rule\u0027: rule})"},{"line_number":831,"context_line":"        security_group_rule \u003d res_dict[\u0027security_group_rule\u0027]"},{"line_number":832,"context_line":"        self.assertNotEqual(security_group_rule[\u0027id\u0027], 0)"},{"line_number":833,"context_line":"        self.assertEqual(self.sg2[\u0027id\u0027],"},{"line_number":834,"context_line":"                         security_group_rule[\u0027parent_group_id\u0027])"},{"line_number":835,"context_line":"        self.assertEqual(\"10.2.3.124/24\","}],"source_content_type":"text/x-python","patch_set":1,"id":"da20952f_763ed7db","line":832,"range":{"start_line":832,"start_character":28,"end_line":832,"end_character":53},"updated":"2015-09-09 14:09:11.000000000","message":"missed one, I think?","commit_id":"730106cc6ba5e12f332aff06263d637e50424a34"},{"author":{"_account_id":8688,"name":"Alexis Lee","email":"openstack@lxsli.co.uk","username":"lxsli"},"change_message_id":"b6739baae87c179a98c67947102b0a69fe919b1d","unresolved":false,"context_lines":[{"line_number":843,"context_line":"            {\u0027security_group_rule\u0027: rule})"},{"line_number":844,"context_line":""},{"line_number":845,"context_line":"        security_group_rule \u003d res_dict[\u0027security_group_rule\u0027]"},{"line_number":846,"context_line":"        self.assertNotEqual(security_group_rule[\u0027id\u0027], 0)"},{"line_number":847,"context_line":"        self.assertEqual(self.sg2[\u0027id\u0027],"},{"line_number":848,"context_line":"                         security_group_rule[\u0027parent_group_id\u0027])"},{"line_number":849,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"da20952f_56107359","line":846,"range":{"start_line":846,"start_character":28,"end_line":846,"end_character":53},"updated":"2015-09-09 14:09:11.000000000","message":"again","commit_id":"730106cc6ba5e12f332aff06263d637e50424a34"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"89d28c7639c6a5df8d51242a5d01f259cf90c4bb","unresolved":false,"context_lines":[{"line_number":861,"context_line":"            {\u0027security_group_rule\u0027: rule2})"},{"line_number":862,"context_line":""},{"line_number":863,"context_line":"        security_group_rule \u003d res_dict[\u0027security_group_rule\u0027]"},{"line_number":864,"context_line":"        self.assertNotEqual(security_group_rule[\u0027id\u0027], 0)"},{"line_number":865,"context_line":"        self.assertEqual(self.sg2[\u0027id\u0027],"},{"line_number":866,"context_line":"                         security_group_rule[\u0027parent_group_id\u0027])"},{"line_number":867,"context_line":"        self.assertEqual(81, security_group_rule[\u0027from_port\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"da20952f_c90dab90","line":864,"updated":"2015-09-09 23:59:15.000000000","message":"this can change also","commit_id":"730106cc6ba5e12f332aff06263d637e50424a34"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"89d28c7639c6a5df8d51242a5d01f259cf90c4bb","unresolved":false,"context_lines":[{"line_number":1062,"context_line":"            {\u0027security_group_rule\u0027: rule})"},{"line_number":1063,"context_line":""},{"line_number":1064,"context_line":"        security_group_rule \u003d res_dict[\u0027security_group_rule\u0027]"},{"line_number":1065,"context_line":"        self.assertNotEqual(security_group_rule[\u0027id\u0027], 0)"},{"line_number":1066,"context_line":"        self.assertEqual(self.parent_security_group[\u0027id\u0027],"},{"line_number":1067,"context_line":"                         security_group_rule[\u0027parent_group_id\u0027])"},{"line_number":1068,"context_line":"        self.assertEqual(\"0.0.0.0/0\","}],"source_content_type":"text/x-python","patch_set":1,"id":"da20952f_0914039d","line":1065,"updated":"2015-09-09 23:59:15.000000000","message":"ditto","commit_id":"730106cc6ba5e12f332aff06263d637e50424a34"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"89d28c7639c6a5df8d51242a5d01f259cf90c4bb","unresolved":false,"context_lines":[{"line_number":1095,"context_line":"        res_dict \u003d self.controller.create(self.req,"},{"line_number":1096,"context_line":"            {\u0027security_group_rule\u0027: rule})"},{"line_number":1097,"context_line":"        security_group_rule \u003d res_dict[\u0027security_group_rule\u0027]"},{"line_number":1098,"context_line":"        self.assertNotEqual(security_group_rule[\u0027id\u0027], 0)"},{"line_number":1099,"context_line":"        self.assertEqual(self.sg1[\u0027id\u0027],"},{"line_number":1100,"context_line":"                         security_group_rule[\u0027parent_group_id\u0027])"},{"line_number":1101,"context_line":"        self.assertEqual(self.sg1[\u0027name\u0027],"}],"source_content_type":"text/x-python","patch_set":1,"id":"da20952f_8939f341","line":1098,"updated":"2015-09-09 23:59:15.000000000","message":"ditto","commit_id":"730106cc6ba5e12f332aff06263d637e50424a34"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"89d28c7639c6a5df8d51242a5d01f259cf90c4bb","unresolved":false,"context_lines":[{"line_number":1220,"context_line":"            {\u0027security_group_rule\u0027: rule})"},{"line_number":1221,"context_line":""},{"line_number":1222,"context_line":"        security_group_rule \u003d res_dict[\u0027security_group_rule\u0027]"},{"line_number":1223,"context_line":"        self.assertNotEqual(security_group_rule[\u0027id\u0027], 0)"},{"line_number":1224,"context_line":"        self.assertEqual(self.parent_security_group[\u0027id\u0027],"},{"line_number":1225,"context_line":"                         security_group_rule[\u0027parent_group_id\u0027])"},{"line_number":1226,"context_line":"        self.assertEqual(\"0.0.0.0/0\","}],"source_content_type":"text/x-python","patch_set":1,"id":"da20952f_89f2539a","line":1223,"updated":"2015-09-09 23:59:15.000000000","message":"ditto","commit_id":"730106cc6ba5e12f332aff06263d637e50424a34"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"89d28c7639c6a5df8d51242a5d01f259cf90c4bb","unresolved":false,"context_lines":[{"line_number":1234,"context_line":"            {\u0027security_group_rule\u0027: rule})"},{"line_number":1235,"context_line":""},{"line_number":1236,"context_line":"        security_group_rule \u003d res_dict[\u0027security_group_rule\u0027]"},{"line_number":1237,"context_line":"        self.assertNotEqual(security_group_rule[\u0027id\u0027], 0)"},{"line_number":1238,"context_line":"        self.assertEqual(self.parent_security_group[\u0027id\u0027],"},{"line_number":1239,"context_line":"                         security_group_rule[\u0027parent_group_id\u0027])"},{"line_number":1240,"context_line":"        self.assertEqual(\"::/0\","}],"source_content_type":"text/x-python","patch_set":1,"id":"da20952f_092de3fc","line":1237,"updated":"2015-09-09 23:59:15.000000000","message":"ditto","commit_id":"730106cc6ba5e12f332aff06263d637e50424a34"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"89d28c7639c6a5df8d51242a5d01f259cf90c4bb","unresolved":false,"context_lines":[{"line_number":1248,"context_line":"            {\u0027security_group_rule\u0027: rule})"},{"line_number":1249,"context_line":""},{"line_number":1250,"context_line":"        security_group_rule \u003d res_dict[\u0027security_group_rule\u0027]"},{"line_number":1251,"context_line":"        self.assertNotEqual(security_group_rule[\u0027id\u0027], 0)"},{"line_number":1252,"context_line":"        self.assertEqual(self.parent_security_group[\u0027id\u0027],"},{"line_number":1253,"context_line":"                         security_group_rule[\u0027parent_group_id\u0027])"},{"line_number":1254,"context_line":"        self.assertEqual(\"15.0.0.0/8\","}],"source_content_type":"text/x-python","patch_set":1,"id":"da20952f_a9339761","line":1251,"updated":"2015-09-09 23:59:15.000000000","message":"ditto","commit_id":"730106cc6ba5e12f332aff06263d637e50424a34"}],"nova/tests/unit/api/openstack/compute/test_server_actions.py":[{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"89d28c7639c6a5df8d51242a5d01f259cf90c4bb","unresolved":false,"context_lines":[{"line_number":658,"context_line":""},{"line_number":659,"context_line":"        self.controller._action_resize(self.req, FAKE_UUID, body\u003dbody)"},{"line_number":660,"context_line":""},{"line_number":661,"context_line":"        self.assertEqual(True, self.resize_called)"},{"line_number":662,"context_line":""},{"line_number":663,"context_line":"    def test_resize_server_no_flavor(self):"},{"line_number":664,"context_line":"        body \u003d dict(resize\u003ddict())"}],"source_content_type":"text/x-python","patch_set":1,"id":"da20952f_892013fa","line":661,"updated":"2015-09-09 23:59:15.000000000","message":"just use assertTrue","commit_id":"730106cc6ba5e12f332aff06263d637e50424a34"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"89d28c7639c6a5df8d51242a5d01f259cf90c4bb","unresolved":false,"context_lines":[{"line_number":880,"context_line":"        body \u003d self.controller._action_revert_resize(self.req, FAKE_UUID,"},{"line_number":881,"context_line":"                                                     body\u003dbody)"},{"line_number":882,"context_line":""},{"line_number":883,"context_line":"        self.assertEqual(True, self.revert_resize_called)"},{"line_number":884,"context_line":""},{"line_number":885,"context_line":"    def test_revert_resize_raises_conflict_on_invalid_state(self):"},{"line_number":886,"context_line":"        body \u003d dict(revertResize\u003dNone)"}],"source_content_type":"text/x-python","patch_set":1,"id":"da20952f_291f87b8","line":883,"updated":"2015-09-09 23:59:15.000000000","message":"just use assertTrue","commit_id":"730106cc6ba5e12f332aff06263d637e50424a34"}],"nova/tests/unit/api/openstack/compute/test_server_groups.py":[{"author":{"_account_id":8688,"name":"Alexis Lee","email":"openstack@lxsli.co.uk","username":"lxsli"},"change_message_id":"b6739baae87c179a98c67947102b0a69fe919b1d","unresolved":false,"context_lines":[{"line_number":278,"context_line":"                                           members\u003dmembers,"},{"line_number":279,"context_line":"                                           metadata\u003dmetadata)"},{"line_number":280,"context_line":"        groups \u003d [sg1, sg2]"},{"line_number":281,"context_line":"        expected \u003d {\u0027server_groups\u0027: groups}"},{"line_number":282,"context_line":""},{"line_number":283,"context_line":"        def return_server_groups(context, project_id):"},{"line_number":284,"context_line":"            return [server_group_db(sg) for sg in groups]"}],"source_content_type":"text/x-python","patch_set":1,"id":"da20952f_812ec28a","line":281,"range":{"start_line":281,"start_character":8,"end_line":281,"end_character":44},"updated":"2015-09-09 14:09:11.000000000","message":"nit: could inline this","commit_id":"730106cc6ba5e12f332aff06263d637e50424a34"},{"author":{"_account_id":8688,"name":"Alexis Lee","email":"openstack@lxsli.co.uk","username":"lxsli"},"change_message_id":"b6739baae87c179a98c67947102b0a69fe919b1d","unresolved":false,"context_lines":[{"line_number":309,"context_line":"        tenant_groups \u003d [sg2]"},{"line_number":310,"context_line":"        all_groups \u003d [sg1, sg2]"},{"line_number":311,"context_line":""},{"line_number":312,"context_line":"        all \u003d {\u0027server_groups\u0027: all_groups}"},{"line_number":313,"context_line":"        tenant_specific \u003d {\u0027server_groups\u0027: tenant_groups}"},{"line_number":314,"context_line":""},{"line_number":315,"context_line":"        def return_all_server_groups(context):"}],"source_content_type":"text/x-python","patch_set":1,"id":"da20952f_81456244","line":312,"range":{"start_line":312,"start_character":8,"end_line":312,"end_character":43},"updated":"2015-09-09 14:09:11.000000000","message":"nit: only used once afaict? inlineable","commit_id":"730106cc6ba5e12f332aff06263d637e50424a34"}],"nova/tests/unit/api/openstack/compute/test_services.py":[{"author":{"_account_id":8688,"name":"Alexis Lee","email":"openstack@lxsli.co.uk","username":"lxsli"},"change_message_id":"b6739baae87c179a98c67947102b0a69fe919b1d","unresolved":false,"context_lines":[{"line_number":193,"context_line":""},{"line_number":194,"context_line":"        self.req \u003d fakes.HTTPRequest.blank(\u0027\u0027)"},{"line_number":195,"context_line":""},{"line_number":196,"context_line":"    def _process_output(self, services, has_disabled\u003dFalse, has_id\u003dFalse):"},{"line_number":197,"context_line":"        return services"},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"    def test_services_list(self):"},{"line_number":200,"context_line":"        req \u003d FakeRequest()"}],"source_content_type":"text/x-python","patch_set":1,"id":"da20952f_61612ed3","line":197,"range":{"start_line":196,"start_character":4,"end_line":197,"end_character":23},"updated":"2015-09-09 14:09:11.000000000","message":"what? why on earth...","commit_id":"730106cc6ba5e12f332aff06263d637e50424a34"}]}