)]}'
{"nova/compute/api.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"cec22d9d1e1487be815f7b24718027a7ae553376","unresolved":false,"context_lines":[{"line_number":122,"context_line":"                    \u0027any other ephemeral and swap disks). 0 does not mean \u0027"},{"line_number":123,"context_line":"                    \u0027that images will be automatically converted to volumes \u0027"},{"line_number":124,"context_line":"                    \u0027and boot instances from volumes - it just means that all \u0027"},{"line_number":125,"context_line":"                    \u0027requests that attempt to create a local disk will fail.\u0027),"},{"line_number":126,"context_line":"]"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"ephemeral_storage_encryption_group \u003d cfg.OptGroup("}],"source_content_type":"text/x-python","patch_set":1,"id":"da20952f_428ef62e","line":125,"updated":"2015-09-04 20:59:25.000000000","message":"Apparently if you\u0027re using RBD, however, setting this option to 0 does prevent anything from booting that isn\u0027t using volumes:\n\n(3:54:38 PM) cburgess: mriedem I confirmed that the bug doesn\u0027t impact me because of using RBD for nova root storage. Those use the same BDM code so that setting gettins applied.","commit_id":"6ef48140999e6fe2d23e6e0c61dfdd41e07359e9"},{"author":{"_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},"change_message_id":"fc47a02d00a9b75d90870219d578676588cf5a64","unresolved":false,"context_lines":[{"line_number":122,"context_line":"                    \u0027any other ephemeral and swap disks). 0 does not mean \u0027"},{"line_number":123,"context_line":"                    \u0027that images will be automatically converted to volumes \u0027"},{"line_number":124,"context_line":"                    \u0027and boot instances from volumes - it just means that all \u0027"},{"line_number":125,"context_line":"                    \u0027requests that attempt to create a local disk will fail.\u0027),"},{"line_number":126,"context_line":"]"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"ephemeral_storage_encryption_group \u003d cfg.OptGroup("}],"source_content_type":"text/x-python","patch_set":1,"id":"ba15a1d1_bc04db49","line":125,"in_reply_to":"da20952f_428ef62e","updated":"2015-09-17 09:40:18.000000000","message":"Yeah so looking back at the commit that introduced this - it may have been a bit of a knee-jerk reaction to a potential security issue. The thing this is supposed to guard against is in case we specify more than one local disk that is neither: root disk, ephemeral or swap (since those are limited by their respective flavor attributes). The thing is - currently, we don\u0027t really support image-\u003elocal bdms other than the root image, so this won\u0027t ever happen.\n\nMaybe a better way to do this limiting would be to add another attr on the flavor called \u0027local_gb\u0027 that sets a total cap on how much disk space an instance will burn on the hypervisor, but this is also not without it\u0027s problems.\n\nBy accident we got a (miss-)feature, that now you can set this to 0 and prevent boot from volume, but in a fairly limited way (you can\u0027t really have any swaps or ephemeral disks either).\n\nIn the long run we probably want to remove and depracate this but for now it\u0027s a crude safeguard against accidentally introducing the issue if we do implement \u0027image\u0027-\u003e\u0027local\u0027.\n\nOne final note: RBD kind of breaks this assumptions since it\u0027s really not on the local disk. It also breaks all the stuff related to local disk accounting and oversubscription. That is a separate issue imho.","commit_id":"6ef48140999e6fe2d23e6e0c61dfdd41e07359e9"}]}