)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"b100b0ef75520c66cefa3b7c75c43fb226ab9147","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     He Jie Xu \u003chejie.xu@intel.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-09-04 11:55:02 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Reject the cell name include \u0027!\u0027 and \u0027.\u0027"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The original v2 API didn\u0027t accept name include \u0027!\u0027 and \u0027.\u0027. But the"},{"line_number":10,"context_line":"v2.1 accept them, those special characters break the cell functionality."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"da20952f_b9ef2486","line":7,"updated":"2015-09-04 10:37:34.000000000","message":"Maybe:\nReject cell names with \u0027!\u0027 \u0027.\u0027 or \u0027@\u0027","commit_id":"187083fd7823958bf8a228fd916c0bbcd7cbc733"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"ed6356c72c4cfaf947ed2adb516fe936c3035b63","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     He Jie Xu \u003chejie.xu@intel.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-09-04 18:43:37 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Reject the cell name include \u0027!\u0027, \u0027.\u0027 and \u0027@\u0027 for Nova API"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Nova cells use \u0027!\u0027, \u0027.\u0027 and \u0027@\u0027 for routing the instance in cells."},{"line_number":10,"context_line":"So those special characters can\u0027t include in the cell name."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"da20952f_544a4f27","line":7,"updated":"2015-09-04 10:48:21.000000000","message":"Nit: I think this is too long, but I am not too worried.","commit_id":"db44432871896b265f6b15a9087962056e48c6c9"}],"nova/api/validation/parameter_types.py":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"b100b0ef75520c66cefa3b7c75c43fb226ab9147","unresolved":false,"context_lines":[{"line_number":62,"context_line":"    re.escape(_printable_ws), re.escape(_get_printable()),"},{"line_number":63,"context_line":"    re.escape(_printable_ws))"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"# cell\u0027s name disallow \u0027!\u0027 and \u0027.\u0027."},{"line_number":66,"context_line":"valid_cell_name_regex \u003d \u0027^(?![%s])[%s]*(?\u003c![%s])$\u0027 % ("},{"line_number":67,"context_line":"    re.escape(_printable_ws),"},{"line_number":68,"context_line":"    re.escape(_get_printable(exclude\u003d[\u0027!\u0027, \u0027.\u0027])),"}],"source_content_type":"text/x-python","patch_set":1,"id":"da20952f_19d650f1","line":65,"updated":"2015-09-04 10:37:34.000000000","message":"I have a feeling we should also include @ given thats also used as a separator.\n\nBut this is consistent with:\nhttps://github.com/openstack/nova/blob/master/nova/api/openstack/compute/legacy_v2/contrib/cells.py#L194","commit_id":"187083fd7823958bf8a228fd916c0bbcd7cbc733"}],"nova/tests/unit/api/openstack/compute/test_cells.py":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"b100b0ef75520c66cefa3b7c75c43fb226ab9147","unresolved":false,"context_lines":[{"line_number":695,"context_line":"    def _get_cell_controller(self, ext_mgr):"},{"line_number":696,"context_line":"        return cells_ext_v2.Controller(ext_mgr)"},{"line_number":697,"context_line":""},{"line_number":698,"context_line":"    def test_cell_create_name_with_invalid_character_raises(self):"},{"line_number":699,"context_line":"        pass"},{"line_number":700,"context_line":""},{"line_number":701,"context_line":"    def test_cell_create_rpc_port_with_null(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"da20952f_f9e27c9f","line":698,"updated":"2015-09-04 10:37:34.000000000","message":"Why is this here?","commit_id":"187083fd7823958bf8a228fd916c0bbcd7cbc733"}]}
