)]}'
{"id":"openstack%2Fnova~22061","triplet_id":"openstack%2Fnova~master~Ib183515a0418203c8bcc88176e3a1498d7333300","project":"openstack/nova","branch":"master","topic":"master","hashtags":[],"change_id":"Ib183515a0418203c8bcc88176e3a1498d7333300","subject":"Make nova security groups more pluggable","status":"MERGED","created":"2013-02-15 19:31:59.000000000","updated":"2013-02-21 00:14:32.000000000","submitted":"2013-02-21 00:14:30.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":96,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"93e5e40468b8e5af0b7d480c0067a2931267e9a9","_number":22061,"virtual_id_number":22061,"owner":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},{"value":0,"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},{"value":2,"date":"2013-02-21 00:14:30.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},{"value":0,"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},{"value":0,"_account_id":105,"name":"Kyle Mestery","email":"mestery@mestery.com","username":"mestery"},{"value":0,"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},{"value":0,"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},{"value":0,"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},{"value":0,"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},{"value":1,"date":"2013-02-20 20:29:23.000000000","_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},{"value":0,"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},{"value":0,"_account_id":1501,"name":"Phil Day","email":"philip.day@hp.com","username":"philip-day"},{"value":0,"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},{"value":0,"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},{"value":0,"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"all":[{"value":0,"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},{"value":2,"date":"2013-02-20 20:48:11.000000000","_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},{"value":2,"date":"2013-02-20 19:47:40.000000000","_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},{"value":0,"_account_id":105,"name":"Kyle Mestery","email":"mestery@mestery.com","username":"mestery"},{"value":0,"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},{"value":0,"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},{"value":0,"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},{"value":0,"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},{"value":0,"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},{"value":0,"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},{"value":0,"_account_id":1501,"name":"Phil Day","email":"philip.day@hp.com","username":"philip-day"},{"value":0,"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},{"value":0,"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},{"value":0,"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"all":[{"value":0,"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},{"value":1,"date":"2013-02-20 20:48:11.000000000","_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},{"value":0,"date":"2013-02-20 19:47:40.000000000","_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},{"value":0,"_account_id":105,"name":"Kyle Mestery","email":"mestery@mestery.com","username":"mestery"},{"value":0,"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},{"value":0,"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},{"value":0,"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},{"value":0,"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},{"value":0,"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},{"value":0,"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},{"value":0,"_account_id":1501,"name":"Phil Day","email":"philip.day@hp.com","username":"philip-day"},{"value":0,"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},{"value":0,"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},{"value":0,"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},{"value":0,"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},{"value":0,"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},{"value":0,"_account_id":105,"name":"Kyle Mestery","email":"mestery@mestery.com","username":"mestery"},{"value":0,"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},{"value":0,"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},{"value":0,"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},{"value":0,"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},{"value":0,"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},{"value":0,"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},{"value":0,"_account_id":1501,"name":"Phil Day","email":"philip.day@hp.com","username":"philip-day"},{"value":0,"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},{"value":0,"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},{"value":0,"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},{"_account_id":105,"name":"Kyle Mestery","email":"mestery@mestery.com","username":"mestery"},{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},{"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},{"_account_id":1501,"name":"Phil Day","email":"philip.day@hp.com","username":"philip-day"},{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2013-02-15 19:42:11.000000000","updated_by":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"reviewer":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"state":"REVIEWER"},{"updated":"2013-02-15 19:42:18.000000000","updated_by":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"reviewer":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"state":"REVIEWER"},{"updated":"2013-02-15 19:42:22.000000000","updated_by":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"reviewer":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"state":"REVIEWER"},{"updated":"2013-02-15 19:42:30.000000000","updated_by":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"reviewer":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"state":"REVIEWER"},{"updated":"2013-02-15 19:42:42.000000000","updated_by":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"reviewer":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"state":"REVIEWER"},{"updated":"2013-02-15 19:42:49.000000000","updated_by":{"_account_id":1501,"name":"Phil Day","email":"philip.day@hp.com","username":"philip-day"},"reviewer":{"_account_id":1501,"name":"Phil Day","email":"philip.day@hp.com","username":"philip-day"},"state":"REVIEWER"},{"updated":"2013-02-15 19:42:52.000000000","updated_by":{"_account_id":105,"name":"Kyle Mestery","email":"mestery@mestery.com","username":"mestery"},"reviewer":{"_account_id":105,"name":"Kyle Mestery","email":"mestery@mestery.com","username":"mestery"},"state":"REVIEWER"},{"updated":"2013-02-15 19:42:56.000000000","updated_by":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"reviewer":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"state":"REVIEWER"},{"updated":"2013-02-15 19:43:10.000000000","updated_by":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"reviewer":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"state":"REVIEWER"},{"updated":"2013-02-15 19:43:16.000000000","updated_by":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"reviewer":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"state":"REVIEWER"},{"updated":"2013-02-18 21:34:34.000000000","updated_by":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"reviewer":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"state":"REVIEWER"},{"updated":"2013-02-20 08:20:41.000000000","updated_by":{"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},"reviewer":{"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},"state":"REVIEWER"},{"updated":"2013-02-20 19:47:40.000000000","updated_by":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"reviewer":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"state":"REVIEWER"},{"updated":"2013-02-20 20:29:23.000000000","updated_by":{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},"reviewer":{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2013-02-20 20:48:11.000000000","updated_by":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"reviewer":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"state":"REVIEWER"},{"updated":"2013-02-21 00:14:30.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"56c9693baf781e7576ad47be0904fcdef02a7ef2","author":{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},"date":"2013-02-15 19:53:42.000000000","message":"Patch Set 1: Works for me\n\nSmokeStack Results (patch set 1):\n\tLibvirt (Fedora 17) Success: http://smokestack.openstack.org/?go\u003d/jobs/72475\n\tXenServer 5.6 (F17 domU) Success: http://smokestack.openstack.org/?go\u003d/jobs/72476\n","accounts_in_message":[],"_revision_number":1},{"id":"6edb88ae103160af099a072ca5be84a8585fe039","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-02-15 22:11:17.000000000","message":"Patch Set 1: Works for me\n\nBuild succeeded.\n\n- http://logs.openstack.org/22061/1/check/gate-nova-pep8/20413 : SUCCESS\n- http://logs.openstack.org/22061/1/check/gate-nova-docs/15050 : SUCCESS\n- http://logs.openstack.org/22061/1/check/gate-nova-python26/16491 : SUCCESS\n- http://logs.openstack.org/22061/1/check/gate-nova-python27/16555 : SUCCESS\n- http://logs.openstack.org/22061/1/check/gate-tempest-devstack-vm-full/3135 : SUCCESS\n- http://logs.openstack.org/22061/1/check/gate-tempest-devstack-vm-postgres-full/2859 : SUCCESS\n- http://logs.openstack.org/22061/1/check/gate-tempest-devstack-vm-quantum/7426 : SUCCESS\n- http://logs.openstack.org/22061/1/check/gate-nova-pylint/8273 : SUCCESS (non-voting)\n","accounts_in_message":[],"_revision_number":1},{"id":"bd21bbe6e4dc1f05533a8999889d9d84f13dc874","author":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"date":"2013-02-15 22:19:28.000000000","message":"Patch Set 1: Looks good to me, but someone else must approve\n\nThe commit message could be a little bit nicer.  shorter first line and a bit of detail about what was refactored. That said the code looks good to me.","accounts_in_message":[],"_revision_number":1},{"id":"7d57a5e35ae288342042adc4dab051396df00c0b","author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"date":"2013-02-15 22:25:50.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"75d98165101399d3ae3d74091ab03458de6f549e","author":{"_account_id":5494,"name":"Trivial Rebase","email":"trivial-rebase@review.openstack.org","username":"trivial-rebase"},"date":"2013-02-15 22:26:04.000000000","message":"Patch Set 2:\n\nNew patchset patch-id matches previous patchset, but commit message has changed.","accounts_in_message":[],"_revision_number":2},{"id":"97bc3febf8a42a94588c9b0d2f25dbb7b3a23cba","author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"date":"2013-02-15 22:26:21.000000000","message":"Patch Set 2:\n\nThanks for the review Vish!  Updated the commit message.","accounts_in_message":[],"_revision_number":2},{"id":"17ae5efefdc7a7287d1a4e30425abe711efe1a24","author":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"date":"2013-02-15 22:29:43.000000000","message":"Patch Set 2: Looks good to me (core reviewer)\n\nlgtm thanks","accounts_in_message":[],"_revision_number":2},{"id":"19bf51f8d79a98b97dd906049b8a127ff929413b","author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"date":"2013-02-15 22:37:31.000000000","message":"Patch Set 2:\n\ncrap miss spelled pluggable in the commit...","accounts_in_message":[],"_revision_number":2},{"id":"c11c5c42839deda84df7a4eb66b217816f61904b","author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"date":"2013-02-15 22:38:21.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"167331e4a3a6d8057974db2c745f5a704572eaf1","author":{"_account_id":5494,"name":"Trivial Rebase","email":"trivial-rebase@review.openstack.org","username":"trivial-rebase"},"date":"2013-02-15 22:38:36.000000000","message":"Patch Set 3:\n\nNew patchset patch-id matches previous patchset, but commit message has changed.","accounts_in_message":[],"_revision_number":3},{"id":"c731f5bfb8d0e4ec7f1738799e5dcd8daa55f343","author":{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},"date":"2013-02-15 22:58:27.000000000","message":"Patch Set 3: Works for me\n\nSmokeStack Results (patch set 3):\n\tLibvirt (Fedora 17) Success: http://smokestack.openstack.org/?go\u003d/jobs/72530\n\tXenServer 5.6 (F17 domU) Success: http://smokestack.openstack.org/?go\u003d/jobs/72531\n","accounts_in_message":[],"_revision_number":3},{"id":"d8c70f90de8b9b45b9ddc475afd408f13da17af6","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-02-15 23:37:02.000000000","message":"Patch Set 3: Works for me\n\nBuild succeeded.\n\n- http://logs.openstack.org/22061/3/check/gate-nova-pep8/20431 : SUCCESS\n- http://logs.openstack.org/22061/3/check/gate-nova-docs/15064 : SUCCESS\n- http://logs.openstack.org/22061/3/check/gate-nova-python26/16505 : SUCCESS\n- http://logs.openstack.org/22061/3/check/gate-nova-python27/16569 : SUCCESS\n- http://logs.openstack.org/22061/3/check/gate-tempest-devstack-vm-full/3179 : SUCCESS\n- http://logs.openstack.org/22061/3/check/gate-tempest-devstack-vm-postgres-full/2903 : SUCCESS\n- http://logs.openstack.org/22061/3/check/gate-tempest-devstack-vm-quantum/7479 : SUCCESS\n- http://logs.openstack.org/22061/3/check/gate-nova-pylint/8287 : SUCCESS (non-voting)\n","accounts_in_message":[],"_revision_number":3},{"id":"1e716a6006eead1586a26c2cfae250ded8d18d42","author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"date":"2013-02-16 05:29:35.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"923f0e3940b4aa90570f675914cb83b13c7a83b6","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-02-16 06:35:08.000000000","message":"Patch Set 4: Works for me\n\nBuild succeeded.\n\n- http://logs.openstack.org/22061/4/check/gate-nova-pep8/20469 : SUCCESS\n- http://logs.openstack.org/22061/4/check/gate-nova-docs/15096 : SUCCESS\n- http://logs.openstack.org/22061/4/check/gate-nova-python26/16537 : SUCCESS\n- http://logs.openstack.org/22061/4/check/gate-nova-python27/16601 : SUCCESS\n- http://logs.openstack.org/22061/4/check/gate-tempest-devstack-vm-full/3243 : SUCCESS\n- http://logs.openstack.org/22061/4/check/gate-tempest-devstack-vm-postgres-full/2967 : SUCCESS\n- http://logs.openstack.org/22061/4/check/gate-tempest-devstack-vm-quantum/7551 : SUCCESS\n- http://logs.openstack.org/22061/4/check/gate-nova-pylint/8304 : SUCCESS (non-voting)\n","accounts_in_message":[],"_revision_number":4},{"id":"d4a8debc3ec338eecec55b509265b650ca1e22ab","author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"date":"2013-02-16 21:48:59.000000000","message":"Uploaded patch set 5.","accounts_in_message":[],"_revision_number":5},{"id":"be3ce8e9fcf5e2317a0d3922cc23754acdf1b8ab","author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"date":"2013-02-16 21:50:12.000000000","message":"Patch Set 5:\n\n(No change, just rebase...)","accounts_in_message":[],"_revision_number":5},{"id":"abfa3cebfb264430de25492421c074ad3dd2dae8","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-02-16 23:05:40.000000000","message":"Patch Set 5: Works for me\n\nBuild succeeded.\n\n- http://logs.openstack.org/22061/5/check/gate-nova-pep8/20500 : SUCCESS\n- http://logs.openstack.org/22061/5/check/gate-nova-docs/15124 : SUCCESS\n- http://logs.openstack.org/22061/5/check/gate-nova-python26/16565 : SUCCESS\n- http://logs.openstack.org/22061/5/check/gate-nova-python27/16629 : SUCCESS\n- http://logs.openstack.org/22061/5/check/gate-tempest-devstack-vm-full/3380 : SUCCESS\n- http://logs.openstack.org/22061/5/check/gate-tempest-devstack-vm-postgres-full/3103 : SUCCESS\n- http://logs.openstack.org/22061/5/check/gate-tempest-devstack-vm-quantum/7713 : SUCCESS\n- http://logs.openstack.org/22061/5/check/gate-nova-pylint/8317 : SUCCESS (non-voting)\n","accounts_in_message":[],"_revision_number":5},{"id":"41df07ac28191dcfd422f15c598930e4a54f0482","author":{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},"date":"2013-02-17 00:17:34.000000000","message":"Patch Set 5: Works for me\n\nSmokeStack Results (patch set 5):\n\tLibvirt (Fedora 17) Success: http://smokestack.openstack.org/?go\u003d/jobs/72648\n\tXenServer 5.6 (F17 domU) Success: http://smokestack.openstack.org/?go\u003d/jobs/72649\n","accounts_in_message":[],"_revision_number":5},{"id":"26922888dfd24c0bc393881b86b24906a36598c4","author":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"date":"2013-02-17 20:56:31.000000000","message":"Patch Set 5: Looks good to me (core reviewer)\n\n","accounts_in_message":[],"_revision_number":5},{"id":"a45085fb9d836762e0666289e9014102c7fb287b","author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"date":"2013-02-18 10:55:02.000000000","message":"Patch Set 5: Looks good to me, but someone else must approve\n\n(1 inline comment)\n\n","accounts_in_message":[],"_revision_number":5},{"id":"dcc98a8b4beb827927e327f1ddc3549cad889f8a","author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"date":"2013-02-18 18:27:12.000000000","message":"Patch Set 5: (1 inline comment)\n\n","accounts_in_message":[],"_revision_number":5},{"id":"a7022afac271a7cf4e07a07d998c0e03acfb8ccf","author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"date":"2013-02-18 18:27:23.000000000","message":"Uploaded patch set 6.","accounts_in_message":[],"_revision_number":6},{"id":"25da32888c399a0e863372fa33703d52c9842590","author":{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},"date":"2013-02-18 18:52:12.000000000","message":"Patch Set 6: Works for me\n\nSmokeStack Results (patch set 6):\n\tLibvirt (Fedora 17) Success: http://smokestack.openstack.org/?go\u003d/jobs/73104\n\tXenServer 5.6 (F17 domU) Success: http://smokestack.openstack.org/?go\u003d/jobs/73105\n","accounts_in_message":[],"_revision_number":6},{"id":"26f5973048b0d97d13925aa20b2b9149247561db","author":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"date":"2013-02-18 18:54:28.000000000","message":"Patch Set 6: Looks good to me (core reviewer)\n\n","accounts_in_message":[],"_revision_number":6},{"id":"043b49e95f8b384aec03a32e4fc67cc32cb9b00f","author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"date":"2013-02-18 19:07:59.000000000","message":"Uploaded patch set 7.","accounts_in_message":[],"_revision_number":7},{"id":"4618fda6ba7b487a004949fd3bb7807043fda6b8","author":{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},"date":"2013-02-18 19:29:57.000000000","message":"Patch Set 7: Works for me\n\nSmokeStack Results (patch set 7):\n\tLibvirt (Fedora 17) Success: http://smokestack.openstack.org/?go\u003d/jobs/73116\n\tXenServer 5.6 (F17 domU) Success: http://smokestack.openstack.org/?go\u003d/jobs/73117\n","accounts_in_message":[],"_revision_number":7},{"id":"0aa7e6d196faa800a260615c720fb4e5244c6360","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-02-18 20:28:01.000000000","message":"Patch Set 7: Works for me\n\nBuild succeeded.\n\n- http://logs.openstack.org/22061/7/check/gate-nova-pep8/20572 : SUCCESS\n- http://logs.openstack.org/22061/7/check/gate-nova-docs/15189 : SUCCESS\n- http://logs.openstack.org/22061/7/check/gate-nova-python26/16630 : SUCCESS\n- http://logs.openstack.org/22061/7/check/gate-nova-python27/16694 : SUCCESS\n- http://logs.openstack.org/22061/7/check/gate-tempest-devstack-vm-full/3608 : SUCCESS\n- http://logs.openstack.org/22061/7/check/gate-tempest-devstack-vm-postgres-full/3331 : SUCCESS\n- http://logs.openstack.org/22061/7/check/gate-tempest-devstack-vm-quantum/8018 : SUCCESS\n- http://logs.openstack.org/22061/7/check/gate-nova-pylint/8368 : SUCCESS (non-voting)\n","accounts_in_message":[],"_revision_number":7},{"id":"c183bf89106404fb8f449579335fc47bab72774d","author":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"date":"2013-02-18 21:31:44.000000000","message":"Patch Set 7: Looks good to me (core reviewer)\n\n","accounts_in_message":[],"_revision_number":7},{"id":"486187ef31d556dfef8c7f0aa1d5a62b3184dc82","author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"date":"2013-02-18 21:34:34.000000000","message":"Patch Set 7: Looks good to me, but someone else must approve\n\nThanks Aaron for addressing the comment","accounts_in_message":[],"_revision_number":7},{"id":"89f6dff959f464f05634427773fac427aff444ea","author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"date":"2013-02-18 21:47:00.000000000","message":"Uploaded patch set 8.","accounts_in_message":[],"_revision_number":8},{"id":"2fe64108a429bf871c8694bb203c5b3951ea0a41","author":{"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},"date":"2013-02-18 22:01:20.000000000","message":"Patch Set 7: (3 inline comments)\n\nSome initial issues inline ... I\u0027m only getting started reviewing it, but see you\u0027re working on it right now so ...\n\nLet\u0027s not use the full python class path in security_group_api\n\nRetain original copyright headers\n\nUnused cfg.CONF","accounts_in_message":[],"_revision_number":7},{"id":"2ab55a1c2a66c9bc97c8e11831b44289f408f349","author":{"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},"date":"2013-02-18 22:01:37.000000000","message":"Patch Set 8: I would prefer that you didn\u0027t merge this\n\nSee inline comments on patch set 7","accounts_in_message":[],"_revision_number":8},{"id":"22105c85984c7c454be9ce70db3749f001842d45","author":{"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},"date":"2013-02-18 22:06:00.000000000","message":"Patch Set 7: (1 inline comment)\n\n","accounts_in_message":[],"_revision_number":7},{"id":"6cb444e1327846dd7ffaeddbc38a098a1c8186fb","author":{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},"date":"2013-02-18 22:13:12.000000000","message":"Patch Set 8: Works for me\n\nSmokeStack Results (patch set 8):\n\tLibvirt (Fedora 17) Success: http://smokestack.openstack.org/?go\u003d/jobs/73164\n\tXenServer 5.6 (F17 domU) Success: http://smokestack.openstack.org/?go\u003d/jobs/73165\n","accounts_in_message":[],"_revision_number":8},{"id":"8e500a85a22d481a802f0a0642ab8539c0722855","author":{"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},"date":"2013-02-18 22:46:16.000000000","message":"Patch Set 8: (13 inline comments)\n\n","accounts_in_message":[],"_revision_number":8},{"id":"4afadf4575688b6b11f143529071a9e935eeb45a","author":{"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},"date":"2013-02-18 22:47:05.000000000","message":"Patch Set 8:\n\nDespite all the comments, this looks like a reasonable direction ... the devil is in the details though! :(","accounts_in_message":[],"_revision_number":8},{"id":"19c15de4e84656a54fcd2f2cf17f6f44a27a6592","author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"date":"2013-02-18 22:51:28.000000000","message":"Patch Set 7: (4 inline comments)\n\n","accounts_in_message":[],"_revision_number":7},{"id":"e20a553e3e7bfbdaded15e72fd5b0adb396ce443","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-02-18 22:58:27.000000000","message":"Patch Set 8: Works for me\n\nBuild succeeded.\n\n- http://logs.openstack.org/22061/8/check/gate-nova-pep8/20608 : SUCCESS\n- http://logs.openstack.org/22061/8/check/gate-nova-docs/15223 : SUCCESS\n- http://logs.openstack.org/22061/8/check/gate-nova-python26/16664 : SUCCESS\n- http://logs.openstack.org/22061/8/check/gate-nova-python27/16727 : SUCCESS\n- http://logs.openstack.org/22061/8/check/gate-tempest-devstack-vm-full/3685 : SUCCESS\n- http://logs.openstack.org/22061/8/check/gate-tempest-devstack-vm-postgres-full/3407 : SUCCESS\n- http://logs.openstack.org/22061/8/check/gate-tempest-devstack-vm-quantum/8101 : SUCCESS\n- http://logs.openstack.org/22061/8/check/gate-nova-pylint/8381 : SUCCESS (non-voting)\n","accounts_in_message":[],"_revision_number":8},{"id":"df5eb2d34e155a6c57ae09d1925876314a3f49fa","author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"date":"2013-02-18 23:21:19.000000000","message":"Patch Set 8: (11 inline comments)\n\nThanks for the view mark a  lot of good comments.","accounts_in_message":[],"_revision_number":8},{"id":"048c0df98c3b6e24c293465f6f270d3d80a10f9d","author":{"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},"date":"2013-02-18 23:47:26.000000000","message":"Patch Set 8: (3 inline comments)\n\n","accounts_in_message":[],"_revision_number":8},{"id":"69169a7d0a908aef7592bb356c298806a4f39d06","author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"date":"2013-02-19 06:12:57.000000000","message":"Uploaded patch set 9.","accounts_in_message":[],"_revision_number":9},{"id":"e8c0d09c33e77a2878b4ede6a02a745587a1e702","author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"date":"2013-02-19 06:13:46.000000000","message":"Patch Set 9: Work In Progress","accounts_in_message":[],"_revision_number":9},{"id":"a247946e167cf8d80e5c8bf1e93c9024f8e61b74","author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"date":"2013-02-19 07:20:00.000000000","message":"Uploaded patch set 10.","accounts_in_message":[],"_revision_number":10},{"id":"f3407cba83a61f4048056d17016723f045adfd3e","author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"date":"2013-02-19 07:28:59.000000000","message":"Patch Set 10:\n\nHi Mark, \n\nI hope I addressed all your comments. I decided to move the security group api that belonged to nova and ec2 back to their original location in nova/api  as before. Regarding the removal of _format_security_group/_rule() I moved these to their driver classes. The reason why I did this is because this function is called from get() and in the quantum scenario the values quantum returns differ slightly from nova\u0027s. Pulling this into the security group driver allows me to remove an extra method in order to convert from quantum to nova just to be able to pass values into format_security_group/_rule() . Thanks for the review.","accounts_in_message":[],"_revision_number":10},{"id":"a4be3f37bd71243d1f5c669c8f190eddda3f5e78","author":{"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},"date":"2013-02-19 08:18:37.000000000","message":"Patch Set 10: I would prefer that you didn\u0027t merge this\n\n(16 inline comments)\n\n","accounts_in_message":[],"_revision_number":10},{"id":"cff62d45e53143f33d0a70aede89d7b21c8854fd","author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"date":"2013-02-19 08:32:50.000000000","message":"Patch Set 8: (1 inline comment)\n\n","accounts_in_message":[],"_revision_number":8},{"id":"f50af2adb990c98eb38a1a8a841937f6bad788f6","author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"date":"2013-02-19 08:45:09.000000000","message":"Patch Set 8: (1 inline comment)\n\n","accounts_in_message":[],"_revision_number":8},{"id":"4c94abf8427216f7ffa8b208055bdaef01bc8f31","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-02-19 08:52:34.000000000","message":"Patch Set 10: Works for me\n\nBuild succeeded.\n\n- http://logs.openstack.org/22061/10/check/gate-nova-pep8/20765 : SUCCESS\n- http://logs.openstack.org/22061/10/check/gate-nova-docs/15368 : SUCCESS\n- http://logs.openstack.org/22061/10/check/gate-nova-python26/16808 : SUCCESS\n- http://logs.openstack.org/22061/10/check/gate-nova-python27/16872 : SUCCESS\n- http://logs.openstack.org/22061/10/check/gate-tempest-devstack-vm-full/3887 : SUCCESS\n- http://logs.openstack.org/22061/10/check/gate-tempest-devstack-vm-postgres-full/3609 : SUCCESS\n- http://logs.openstack.org/22061/10/check/gate-tempest-devstack-vm-quantum/8320 : SUCCESS\n- http://logs.openstack.org/22061/10/check/gate-nova-pylint/8440 : FAILURE (non-voting)\n","accounts_in_message":[],"_revision_number":10},{"id":"f3af5c3ca0b1409832994c70087d9c09ab8fabae","author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"date":"2013-02-19 17:34:26.000000000","message":"Patch Set 10: (16 inline comments)\n\nThanks for the review mark.","accounts_in_message":[],"_revision_number":10},{"id":"38eb6d6a8bd9c3074360b88b050f7f48ced3ed47","author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"date":"2013-02-19 19:26:54.000000000","message":"Uploaded patch set 11.","accounts_in_message":[],"_revision_number":11},{"id":"93b2f33627ce10624361c1add0cf9d305ba461fc","author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"date":"2013-02-19 19:27:26.000000000","message":"Patch Set 11: Work In Progress","accounts_in_message":[],"_revision_number":11},{"id":"28e8e7355d1c23b5437dd661d069dd5c813d3e2c","author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"date":"2013-02-19 19:31:58.000000000","message":"Patch Set 11: (6 inline comments)\n\n","accounts_in_message":[],"_revision_number":11},{"id":"ab3954c61284c28772cbe082c4fb94c97ec7f53f","author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"date":"2013-02-19 19:38:25.000000000","message":"Patch Set 11: (2 inline comments)\n\n","accounts_in_message":[],"_revision_number":11},{"id":"a27edd496c16a80587c7a65414685e078a34d7ba","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-02-19 20:55:05.000000000","message":"Patch Set 11: Works for me\n\nBuild succeeded.\n\n- http://logs.openstack.org/22061/11/check/gate-nova-pep8/20894 : SUCCESS\n- http://logs.openstack.org/22061/11/check/gate-nova-docs/15481 : SUCCESS\n- http://logs.openstack.org/22061/11/check/gate-nova-python26/16921 : SUCCESS\n- http://logs.openstack.org/22061/11/check/gate-nova-python27/16984 : SUCCESS\n- http://logs.openstack.org/22061/11/check/gate-tempest-devstack-vm-full/4170 : SUCCESS\n- http://logs.openstack.org/22061/11/check/gate-tempest-devstack-vm-postgres-full/3889 : SUCCESS\n- http://logs.openstack.org/22061/11/check/gate-tempest-devstack-vm-quantum/8652 : SUCCESS\n- http://logs.openstack.org/22061/11/check/gate-nova-pylint/8474 : FAILURE (non-voting)\n","accounts_in_message":[],"_revision_number":11},{"id":"f03006719b5235da07a8a399123558c439490de5","author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"date":"2013-02-19 21:38:30.000000000","message":"Uploaded patch set 12.","accounts_in_message":[],"_revision_number":12},{"id":"f7c26fce00e25d4dd3b547e28d08c8457f1d9850","author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"date":"2013-02-19 21:44:46.000000000","message":"Patch Set 12: Work In Progress","accounts_in_message":[],"_revision_number":12},{"id":"a4d5a47378cf1eac68e0edbc2477fa483eb3a649","author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"date":"2013-02-19 21:46:30.000000000","message":"Uploaded patch set 13.","accounts_in_message":[],"_revision_number":13},{"id":"2a124da5c5e4f64245d427e71511915936df4d9f","author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"date":"2013-02-19 21:52:06.000000000","message":"Patch Set 13: (1 inline comment)\n\n","accounts_in_message":[],"_revision_number":13},{"id":"4e060986089e875dccecdfe2c994bfe81128aa39","author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"date":"2013-02-19 21:53:38.000000000","message":"Uploaded patch set 14.","accounts_in_message":[],"_revision_number":14},{"id":"0c29c36f93e0fc368a43bbac8e0d898921089851","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-02-19 23:35:08.000000000","message":"Patch Set 14: Works for me\n\nBuild succeeded.\n\n- http://logs.openstack.org/22061/14/check/gate-nova-pep8/20929 : SUCCESS\n- http://logs.openstack.org/22061/14/check/gate-nova-docs/15514 : SUCCESS\n- http://logs.openstack.org/22061/14/check/gate-nova-python26/16956 : SUCCESS\n- http://logs.openstack.org/22061/14/check/gate-nova-python27/17018 : SUCCESS\n- http://logs.openstack.org/22061/14/check/gate-tempest-devstack-vm-full/4240 : SUCCESS\n- http://logs.openstack.org/22061/14/check/gate-tempest-devstack-vm-postgres-full/3959 : SUCCESS\n- http://logs.openstack.org/22061/14/check/gate-tempest-devstack-vm-quantum/8730 : SUCCESS\n- http://logs.openstack.org/22061/14/check/gate-nova-pylint/8495 : FAILURE (non-voting)\n","accounts_in_message":[],"_revision_number":14},{"id":"704dbcb38badaa8d345c63d7fd082ee4241ef9c5","author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"date":"2013-02-19 23:46:42.000000000","message":"Patch Set 14: (1 inline comment)\n\n","accounts_in_message":[],"_revision_number":14},{"id":"d5138a82a4ab591787fdc4424fbe6f1670660d34","author":{"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},"date":"2013-02-20 00:06:30.000000000","message":"Patch Set 14: I would prefer that you didn\u0027t merge this\n\n(4 inline comments)\n\nThe issue inline is the POST body re-parsing thing in _extend_servers()\n\nI suspect it\u0027s actually an API behaviour change, which is concerning. If you could somehow allow the code to work as before when using the nova driver, that would be ideal. Otherwise I need some convincing on this aspect\n\nBut again, this change is only required when you add quantum, rather than required to make it more pluggable. If it was in the patch with the quantum driver, it would make more sense even just from a code review standpoint","accounts_in_message":[],"_revision_number":14},{"id":"5a87fbcb3eb86f0d52df768308fe89bb4f38c9cc","author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"date":"2013-02-20 00:31:18.000000000","message":"Patch Set 14: (2 inline comments)\n\n","accounts_in_message":[],"_revision_number":14},{"id":"bae8a20e302d6834fd015f4df05f97326b44fb0c","author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"date":"2013-02-20 01:30:27.000000000","message":"Uploaded patch set 15.","accounts_in_message":[],"_revision_number":15},{"id":"4fe7423c4368a02a1f5a771d825ecec653ed601d","author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"date":"2013-02-20 02:06:44.000000000","message":"Uploaded patch set 16.","accounts_in_message":[],"_revision_number":16},{"id":"a4ecf9f8b0957d5811a9df32c45e24a951265859","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-02-20 03:20:15.000000000","message":"Patch Set 16: Works for me\n\nBuild succeeded.\n\n- http://logs.openstack.org/22061/16/check/gate-nova-pep8/21024 : SUCCESS\n- http://logs.openstack.org/22061/16/check/gate-nova-docs/15602 : SUCCESS\n- http://logs.openstack.org/22061/16/check/gate-nova-python26/17047 : SUCCESS\n- http://logs.openstack.org/22061/16/check/gate-nova-python27/17102 : SUCCESS\n- http://logs.openstack.org/22061/16/check/gate-tempest-devstack-vm-full/4355 : SUCCESS\n- http://logs.openstack.org/22061/16/check/gate-tempest-devstack-vm-postgres-full/4074 : SUCCESS\n- http://logs.openstack.org/22061/16/check/gate-tempest-devstack-vm-quantum/8858 : SUCCESS\n- http://logs.openstack.org/22061/16/check/gate-nova-pylint/8553 : FAILURE (non-voting)\n","accounts_in_message":[],"_revision_number":16},{"id":"75fc60f35beb02b8e6ef221a146571157256ec32","author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"date":"2013-02-20 03:44:50.000000000","message":"Uploaded patch set 17.","accounts_in_message":[],"_revision_number":17},{"id":"0a467e8400ac49ce90798c51d99f036c6fc4b607","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-02-20 04:45:03.000000000","message":"Patch Set 17: Works for me\n\nBuild succeeded.\n\n- http://logs.openstack.org/22061/17/check/gate-nova-pep8/21041 : SUCCESS\n- http://logs.openstack.org/22061/17/check/gate-nova-docs/15619 : SUCCESS\n- http://logs.openstack.org/22061/17/check/gate-nova-python26/17064 : SUCCESS\n- http://logs.openstack.org/22061/17/check/gate-nova-python27/17119 : SUCCESS\n- http://logs.openstack.org/22061/17/check/gate-tempest-devstack-vm-full/4391 : SUCCESS\n- http://logs.openstack.org/22061/17/check/gate-tempest-devstack-vm-postgres-full/4110 : SUCCESS\n- http://logs.openstack.org/22061/17/check/gate-tempest-devstack-vm-quantum/8898 : SUCCESS\n- http://logs.openstack.org/22061/17/check/gate-nova-pylint/8566 : FAILURE (non-voting)\n","accounts_in_message":[],"_revision_number":17},{"id":"d7e0345215cec4629a99f206f6604bc136b92afa","author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"date":"2013-02-20 05:25:02.000000000","message":"Patch Set 17:\n\nJust wanted to add a comment that the pylint errors are not actually an error. The reason why they are complaining is because SecurityGroupAPI() doesn\u0027t have any of the raise_*() functions but SecurityGroupAPI() is never used directly. In this patch one would use: \n\nclass NativeNovaSecurityGroupAPI(compute_api.SecurityGroupAPI,NativeSecurityGroupExceptions): which provides the raise_*() methods.","accounts_in_message":[],"_revision_number":17},{"id":"635962987c505e808e0abfc6245222c9f6c17fc5","author":{"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},"date":"2013-02-20 08:20:41.000000000","message":"Patch Set 17: Looks good to me (core reviewer)\n\nThanks Aaron","accounts_in_message":[],"_revision_number":17},{"id":"a32bfb259fbb2f3fcd8dabaaf0a65ead14501327","author":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"date":"2013-02-20 16:16:22.000000000","message":"Patch Set 17: Looks good to me (core reviewer); Approved\n\n","accounts_in_message":[],"_revision_number":17},{"id":"4fb18ed7e296949f849ba86a9da51b947364a38d","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-02-20 16:16:27.000000000","message":"Patch Set 17: No score\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":17},{"id":"34a186c5194124cb1aaec38251b00267700bf14a","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-02-20 16:57:25.000000000","message":"Patch Set 17: Fails\n\nBuild failed.  For information on how to proceed, see http://wiki.openstack.org/GerritJenkinsGithub#Test_Failures\n\nThis change was unable to be automatically merged with the current state of the repository. Please rebase your change and upload a new patchset.","accounts_in_message":[],"_revision_number":17},{"id":"0b86be17a3331c124a052bf493ec5b697f654987","author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"date":"2013-02-20 17:48:49.000000000","message":"Uploaded patch set 18.","accounts_in_message":[],"_revision_number":18},{"id":"aa5aa78c5f0cf7ddbd5488d79b8176de972f5de6","author":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"date":"2013-02-20 17:56:58.000000000","message":"Patch Set 18: Looks good to me (core reviewer); Approved\n\nretry after rebase","accounts_in_message":[],"_revision_number":18},{"id":"1c56c1e4c2e67329d65c04f2d77949597b88b37e","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-02-20 17:57:00.000000000","message":"Patch Set 18:\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":18},{"id":"12f995b94e4a7cbfd416f654aa47b461ebbcc3e4","author":{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},"date":"2013-02-20 18:16:13.000000000","message":"Patch Set 18: Works for me\n\nSmokeStack Results (patch set 18):\n\tLibvirt (Fedora 17) Success: http://smokestack.openstack.org/?go\u003d/jobs/73425\n\tXenServer 5.6 (F17 domU) Success: http://smokestack.openstack.org/?go\u003d/jobs/73426\n","accounts_in_message":[],"_revision_number":18},{"id":"6c6e5efde03d405ee8469a3eca6363c319c1d9b9","author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"date":"2013-02-20 18:36:40.000000000","message":"Uploaded patch set 19.","accounts_in_message":[],"_revision_number":19},{"id":"faeb812d623d9cf5a958867ef74bf59b646bbb92","author":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"date":"2013-02-20 18:37:04.000000000","message":"Patch Set 19: Looks good to me (core reviewer)\n\nAutomatically re-added by Gerrit trivial rebase detection script.","accounts_in_message":[],"_revision_number":19},{"id":"47b445a338350e02cc68d152aafbd7cd90bb741a","author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"date":"2013-02-20 18:38:14.000000000","message":"Patch Set 19:\n\nI made a change to my proxy patch which depends on this which does a rebase on this one too since I have these stacked. No changes happened here just rebase....","accounts_in_message":[],"_revision_number":19},{"id":"47abce465c008eee2f91e937157a8e065b0be8c4","author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"date":"2013-02-20 19:11:45.000000000","message":"Patch Set 19: I would prefer that you didn\u0027t merge this\n\n(5 inline comments)\n\nNova has switched from nova.openstack.common.cfg to oslo.config.cfg; there are a few places where you\u0027re shadowing oslo.config.cfg, presumably due to a bad merge, and others where you\u0027re using the deprecated cfg instead of the new one.","accounts_in_message":[],"_revision_number":19},{"id":"6cb97c236b500bc190e3998ee386e4d6df6ec3d6","author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"date":"2013-02-20 19:22:18.000000000","message":"Patch Set 19: (4 inline comments)\n\nthanks, good catch on the oslo.config.cfg","accounts_in_message":[],"_revision_number":19},{"id":"16400358e283d0a6e19cfef89a90f3626583c510","author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"date":"2013-02-20 19:31:17.000000000","message":"Uploaded patch set 20.","accounts_in_message":[],"_revision_number":20},{"id":"5a52fbecb4b362ca1dc610863c2f6f12bf3616ba","author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"date":"2013-02-20 19:47:40.000000000","message":"Patch Set 20: Looks good to me (core reviewer)\n\n","accounts_in_message":[],"_revision_number":20},{"id":"351948c9e857747ec2f0ae52f222500f2fdfaffb","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-02-20 20:19:06.000000000","message":"Patch Set 20: Works for me\n\nBuild succeeded.\n\n- http://logs.openstack.org/22061/20/check/gate-nova-pep8/21161 : SUCCESS\n- http://logs.openstack.org/22061/20/check/gate-nova-docs/15728 : SUCCESS\n- http://logs.openstack.org/22061/20/check/gate-nova-python26/17169 : SUCCESS\n- http://logs.openstack.org/22061/20/check/gate-nova-python27/17228 : SUCCESS\n- http://logs.openstack.org/22061/20/check/gate-tempest-devstack-vm-full/4601 : SUCCESS\n- http://logs.openstack.org/22061/20/check/gate-tempest-devstack-vm-postgres-full/4320 : SUCCESS\n- http://logs.openstack.org/22061/20/check/gate-tempest-devstack-vm-quantum/9130 : SUCCESS\n- http://logs.openstack.org/22061/20/check/gate-nova-pylint/8630 : FAILURE (non-voting)\n","accounts_in_message":[],"_revision_number":20},{"id":"24d82288ea8d732f54804239c75a2f3385632e4a","author":{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},"date":"2013-02-20 20:29:23.000000000","message":"Patch Set 20: Works for me\n\nSmokeStack Results (patch set 20):\n\tLibvirt (Fedora 17) Success: http://smokestack.openstack.org/?go\u003d/jobs/73475\n\tXenServer 5.6 (F17 domU) Success: http://smokestack.openstack.org/?go\u003d/jobs/73476\n","accounts_in_message":[],"_revision_number":20},{"id":"8e6408cebab45a25adbc6eb55ec04ef996cc77a3","author":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"date":"2013-02-20 20:48:11.000000000","message":"Patch Set 20: Looks good to me (core reviewer); Approved\n\n","accounts_in_message":[],"_revision_number":20},{"id":"c9db569bdc3a821f17594e514e13d5aecf60b98d","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-02-20 20:48:16.000000000","message":"Patch Set 20: No score\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":20},{"id":"535510669da4931d9916981a3d52311721d5438e","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-02-21 00:14:30.000000000","message":"Patch Set 20: Verified\n\nBuild succeeded.\n\n- http://logs.openstack.org/22061/20/gate/gate-nova-docs/15808 : SUCCESS\n- http://logs.openstack.org/22061/20/gate/gate-nova-pep8/21243 : SUCCESS\n- http://logs.openstack.org/22061/20/gate/gate-nova-python26/17238 : SUCCESS\n- http://logs.openstack.org/22061/20/gate/gate-nova-python27/17307 : SUCCESS\n- http://logs.openstack.org/22061/20/gate/gate-tempest-devstack-vm-full/4726 : SUCCESS\n- http://logs.openstack.org/22061/20/gate/gate-tempest-devstack-vm-postgres-full/4445 : SUCCESS\n- http://logs.openstack.org/22061/20/gate/gate-tempest-devstack-vm-quantum/9266 : SUCCESS\n","accounts_in_message":[],"_revision_number":20},{"id":"c8d58bcb86823cc2996263f03c17930c13ea2c6d","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-02-21 00:14:32.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":20}],"current_revision_number":20,"current_revision":"d562012f34eadfe6b68dd5ebe06a2fa565de3b2e","revisions":{"cde1228a4b8f308c85dbe4983c00a62d89823ccc":{"kind":"REWORK","_number":1,"created":"2013-02-15 19:31:59.000000000","uploader":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"ref":"refs/changes/61/22061/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/61/22061/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/61/22061/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/61/22061/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/61/22061/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/61/22061/1"}}},"commit":{"parents":[{"commit":"fa0498bd246b5e97b8a9b18f33a8d16ce08e2f8a","subject":"Merge \"Harmonize PEP8 checking between tox and run_tests.sh\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/fa0498bd246b5e97b8a9b18f33a8d16ce08e2f8a"}]}],"author":{"name":"Aaron Rosen","email":"arosen@nicira.com","date":"2013-02-15 18:41:00.000000000","tz":-480},"committer":{"name":"Aaron Rosen","email":"arosen@nicira.com","date":"2013-02-15 19:28:17.000000000","tz":-480},"subject":"Refactor nova security groups to allow to them to be more plugable","message":"Refactor nova security groups to allow to them to be more plugable\n\nChange-Id: Ib183515a0418203c8bcc88176e3a1498d7333300\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/cde1228a4b8f308c85dbe4983c00a62d89823ccc"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/cde1228a4b8f308c85dbe4983c00a62d89823ccc"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"fa0498bd246b5e97b8a9b18f33a8d16ce08e2f8a","is_merged_in_target_branch":true}],"branch":"refs/heads/master"},"d5a74a55d97384894e0147e498639a7c50beab4a":{"kind":"TRIVIAL_REBASE_WITH_MESSAGE_UPDATE","_number":2,"created":"2013-02-15 22:25:50.000000000","uploader":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"ref":"refs/changes/61/22061/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/61/22061/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/61/22061/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/61/22061/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/61/22061/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/61/22061/2"}}},"commit":{"parents":[{"commit":"596e0b392a961c28c5d8f81ec45dc6e2b28578e2","subject":"Merge \"relocatable roots doesn\u0027t handle testr args/opts\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/596e0b392a961c28c5d8f81ec45dc6e2b28578e2"}]}],"author":{"name":"Aaron Rosen","email":"arosen@nicira.com","date":"2013-02-15 18:41:00.000000000","tz":-480},"committer":{"name":"Aaron Rosen","email":"arosen@nicira.com","date":"2013-02-15 22:22:09.000000000","tz":-480},"subject":"Make nova security groups more plugable","message":"Make nova security groups more plugable\n\nThis patch moves the nova security group code out of nova/compute/api.py\ninto nova/network/security_group. It also removes any query to the database\nfrom security group api into the nova security group driver. This allows\nsecurity group drivers the ability to decouple themselves from storing\nsecurity group information in the nova_db.\n\nChange-Id: Ib183515a0418203c8bcc88176e3a1498d7333300\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/d5a74a55d97384894e0147e498639a7c50beab4a"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/d5a74a55d97384894e0147e498639a7c50beab4a"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"596e0b392a961c28c5d8f81ec45dc6e2b28578e2","is_merged_in_target_branch":true}],"branch":"refs/heads/master"},"e8551388cbd6b16547c315b89c227a328d7b86a3":{"kind":"NO_CODE_CHANGE","_number":3,"created":"2013-02-15 22:38:21.000000000","uploader":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"ref":"refs/changes/61/22061/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/61/22061/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/61/22061/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/61/22061/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/61/22061/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/61/22061/3"}}},"commit":{"parents":[{"commit":"596e0b392a961c28c5d8f81ec45dc6e2b28578e2","subject":"Merge \"relocatable roots doesn\u0027t handle testr args/opts\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/596e0b392a961c28c5d8f81ec45dc6e2b28578e2"}]}],"author":{"name":"Aaron Rosen","email":"arosen@nicira.com","date":"2013-02-15 18:41:00.000000000","tz":-480},"committer":{"name":"Aaron Rosen","email":"arosen@nicira.com","date":"2013-02-15 22:34:29.000000000","tz":-480},"subject":"Make nova security groups more pluggable","message":"Make nova security groups more pluggable\n\nThis patch moves the nova security group code out of nova/compute/api.py\ninto nova/network/security_group. It also removes any query to the database\nfrom security group api into the nova security group driver. This allows\nsecurity group drivers the ability to decouple themselves from storing\nsecurity group information in the nova_db.\n\nChange-Id: Ib183515a0418203c8bcc88176e3a1498d7333300\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/e8551388cbd6b16547c315b89c227a328d7b86a3"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/e8551388cbd6b16547c315b89c227a328d7b86a3"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"596e0b392a961c28c5d8f81ec45dc6e2b28578e2","is_merged_in_target_branch":true}],"branch":"refs/heads/master"},"bef8e030685cf0f0c4630dba7e4165eedf07a83d":{"kind":"TRIVIAL_REBASE","_number":4,"created":"2013-02-16 05:29:35.000000000","uploader":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"ref":"refs/changes/61/22061/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/61/22061/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/61/22061/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/61/22061/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/61/22061/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/61/22061/4"}}},"commit":{"parents":[{"commit":"cc4cb69d02d42d1d52266d7273ad18d0ab757063","subject":"Merge \"Only dhcp the first ip for each mac address.\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/cc4cb69d02d42d1d52266d7273ad18d0ab757063"}]}],"author":{"name":"Aaron Rosen","email":"arosen@nicira.com","date":"2013-02-15 18:41:00.000000000","tz":-480},"committer":{"name":"Aaron Rosen","email":"arosen@nicira.com","date":"2013-02-16 05:25:52.000000000","tz":-480},"subject":"Make nova security groups more pluggable","message":"Make nova security groups more pluggable\n\nThis patch moves the nova security group code out of nova/compute/api.py\ninto nova/network/security_group. It also removes any query to the database\nfrom security group api into the nova security group driver. This allows\nsecurity group drivers the ability to decouple themselves from storing\nsecurity group information in the nova_db.\n\nChange-Id: Ib183515a0418203c8bcc88176e3a1498d7333300\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/bef8e030685cf0f0c4630dba7e4165eedf07a83d"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/bef8e030685cf0f0c4630dba7e4165eedf07a83d"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"cc4cb69d02d42d1d52266d7273ad18d0ab757063","is_merged_in_target_branch":true}],"branch":"refs/heads/master"},"bb29eeecc60d799af858d061b19314588f63ed1a":{"kind":"TRIVIAL_REBASE","_number":5,"created":"2013-02-16 21:48:59.000000000","uploader":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"ref":"refs/changes/61/22061/5","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/61/22061/5","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/61/22061/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/61/22061/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/61/22061/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/61/22061/5"}}},"commit":{"parents":[{"commit":"574eae99dcd0c0ca809d11053dd83f3616b97e70","subject":"Merge \"Rename \u0027connection\u0027 to \u0027driver\u0027 in libvirt HostState\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/574eae99dcd0c0ca809d11053dd83f3616b97e70"}]}],"author":{"name":"Aaron Rosen","email":"arosen@nicira.com","date":"2013-02-15 18:41:00.000000000","tz":-480},"committer":{"name":"Aaron Rosen","email":"arosen@nicira.com","date":"2013-02-16 21:45:12.000000000","tz":-480},"subject":"Make nova security groups more pluggable","message":"Make nova security groups more pluggable\n\nThis patch moves the nova security group code out of nova/compute/api.py\ninto nova/network/security_group. It also removes any query to the database\nfrom security group api into the nova security group driver. This allows\nsecurity group drivers the ability to decouple themselves from storing\nsecurity group information in the nova_db.\n\nChange-Id: Ib183515a0418203c8bcc88176e3a1498d7333300\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/bb29eeecc60d799af858d061b19314588f63ed1a"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/bb29eeecc60d799af858d061b19314588f63ed1a"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"574eae99dcd0c0ca809d11053dd83f3616b97e70","is_merged_in_target_branch":true}],"branch":"refs/heads/master"},"dc6a7ada7750d01d3aab8d4272ca52d6bc0d0758":{"kind":"REWORK","_number":6,"created":"2013-02-18 18:27:23.000000000","uploader":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"ref":"refs/changes/61/22061/6","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/61/22061/6","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/61/22061/6 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/61/22061/6 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/61/22061/6 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/61/22061/6"}}},"commit":{"parents":[{"commit":"9e2b990f2260dbbe1b207e853b37f6261e594fbd","subject":"Merge \"Fix script argument parsing.\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/9e2b990f2260dbbe1b207e853b37f6261e594fbd"}]}],"author":{"name":"Aaron Rosen","email":"arosen@nicira.com","date":"2013-02-15 18:41:00.000000000","tz":-480},"committer":{"name":"Aaron Rosen","email":"arosen@nicira.com","date":"2013-02-18 18:23:06.000000000","tz":-480},"subject":"Make nova security groups more pluggable","message":"Make nova security groups more pluggable\n\nThis patch moves the nova security group code out of nova/compute/api.py\ninto nova/network/security_group. It also removes any query to the database\nfrom security group api into the nova security group driver. This allows\nsecurity group drivers the ability to decouple themselves from storing\nsecurity group information in the nova_db.\n\nChange-Id: Ib183515a0418203c8bcc88176e3a1498d7333300\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/dc6a7ada7750d01d3aab8d4272ca52d6bc0d0758"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/dc6a7ada7750d01d3aab8d4272ca52d6bc0d0758"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"9e2b990f2260dbbe1b207e853b37f6261e594fbd","is_merged_in_target_branch":true}],"branch":"refs/heads/master"},"be3081f0bba9814923912c1a123be32de1b17628":{"kind":"REWORK","_number":7,"created":"2013-02-18 19:07:59.000000000","uploader":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"ref":"refs/changes/61/22061/7","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/61/22061/7","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/61/22061/7 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/61/22061/7 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/61/22061/7 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/61/22061/7"}}},"commit":{"parents":[{"commit":"9e2b990f2260dbbe1b207e853b37f6261e594fbd","subject":"Merge \"Fix script argument parsing.\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/9e2b990f2260dbbe1b207e853b37f6261e594fbd"}]}],"author":{"name":"Aaron Rosen","email":"arosen@nicira.com","date":"2013-02-15 18:41:00.000000000","tz":-480},"committer":{"name":"Aaron Rosen","email":"arosen@nicira.com","date":"2013-02-18 19:04:08.000000000","tz":-480},"subject":"Make nova security groups more pluggable","message":"Make nova security groups more pluggable\n\nThis patch moves the nova security group code out of nova/compute/api.py\ninto nova/network/security_group. It also removes any query to the database\nfrom security group api into the nova security group driver. This allows\nsecurity group drivers the ability to decouple themselves from storing\nsecurity group information in the nova_db.\n\nChange-Id: Ib183515a0418203c8bcc88176e3a1498d7333300\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/be3081f0bba9814923912c1a123be32de1b17628"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/be3081f0bba9814923912c1a123be32de1b17628"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"9e2b990f2260dbbe1b207e853b37f6261e594fbd","is_merged_in_target_branch":true}],"branch":"refs/heads/master"},"f4a6388ba5f0d8d735a47604ca0b6d0d57851f6d":{"kind":"REWORK","_number":8,"created":"2013-02-18 21:47:00.000000000","uploader":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"ref":"refs/changes/61/22061/8","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/61/22061/8","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/61/22061/8 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/61/22061/8 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/61/22061/8 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/61/22061/8"}}},"commit":{"parents":[{"commit":"9e2b990f2260dbbe1b207e853b37f6261e594fbd","subject":"Merge \"Fix script argument parsing.\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/9e2b990f2260dbbe1b207e853b37f6261e594fbd"}]}],"author":{"name":"Aaron Rosen","email":"arosen@nicira.com","date":"2013-02-15 18:41:00.000000000","tz":-480},"committer":{"name":"Aaron Rosen","email":"arosen@nicira.com","date":"2013-02-18 21:32:37.000000000","tz":-480},"subject":"Make nova security groups more pluggable","message":"Make nova security groups more pluggable\n\nThis patch moves the nova security group code out of nova/compute/api.py\ninto nova/network/security_group. It also removes any query to the database\nfrom security group api into the nova security group driver. This allows\nsecurity group drivers the ability to decouple themselves from storing\nsecurity group information in the nova_db.\n\nChange-Id: Ib183515a0418203c8bcc88176e3a1498d7333300\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/f4a6388ba5f0d8d735a47604ca0b6d0d57851f6d"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/f4a6388ba5f0d8d735a47604ca0b6d0d57851f6d"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"9e2b990f2260dbbe1b207e853b37f6261e594fbd","is_merged_in_target_branch":true}],"branch":"refs/heads/master"},"c986df7a4929f744f88144f75a4d41e4ffc79f5f":{"kind":"REWORK","_number":9,"created":"2013-02-19 06:12:57.000000000","uploader":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"ref":"refs/changes/61/22061/9","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/61/22061/9","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/61/22061/9 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/61/22061/9 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/61/22061/9 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/61/22061/9"}}},"commit":{"parents":[{"commit":"3e1e38f9a5b5550ea91b93040bc2d9c020aa7659","subject":"Merge \"Fixes a race condition on updating security group rules\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/3e1e38f9a5b5550ea91b93040bc2d9c020aa7659"}]}],"author":{"name":"Aaron Rosen","email":"arosen@nicira.com","date":"2013-02-15 18:41:00.000000000","tz":-480},"committer":{"name":"Aaron Rosen","email":"arosen@nicira.com","date":"2013-02-19 06:09:05.000000000","tz":-480},"subject":"Make nova security groups more pluggable","message":"Make nova security groups more pluggable\n\nThis patch moves the nova security group code out of nova/compute/api.py\ninto nova/network/security_group. It also removes any query to the database\nfrom security group api into the nova security group driver. This allows\nsecurity group drivers the ability to decouple themselves from storing\nsecurity group information in the nova_db.\n\nChange-Id: Ib183515a0418203c8bcc88176e3a1498d7333300\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/c986df7a4929f744f88144f75a4d41e4ffc79f5f"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/c986df7a4929f744f88144f75a4d41e4ffc79f5f"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"3e1e38f9a5b5550ea91b93040bc2d9c020aa7659","is_merged_in_target_branch":true}],"branch":"refs/heads/master"},"0f48ea33f3a06ec8163e283f81d79051ffc1200f":{"kind":"REWORK","_number":10,"created":"2013-02-19 07:20:00.000000000","uploader":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"ref":"refs/changes/61/22061/10","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/61/22061/10","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/61/22061/10 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/61/22061/10 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/61/22061/10 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/61/22061/10"}}},"commit":{"parents":[{"commit":"90ac3270a8bfe4b94e49cd4c2504b6c85dca14a5","subject":"Merge \"Add support for instance vif traffic control.\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/90ac3270a8bfe4b94e49cd4c2504b6c85dca14a5"}]}],"author":{"name":"Aaron Rosen","email":"arosen@nicira.com","date":"2013-02-15 18:41:00.000000000","tz":-480},"committer":{"name":"Aaron Rosen","email":"arosen@nicira.com","date":"2013-02-19 07:16:06.000000000","tz":-480},"subject":"Make nova security groups more pluggable","message":"Make nova security groups more pluggable\n\nThis patch moves the nova security group code out of nova/compute/api.py\ninto nova/network/security_group. It also removes any query to the database\nfrom security group api into the nova security group driver. This allows\nsecurity group drivers the ability to decouple themselves from storing\nsecurity group information in the nova_db.\n\nChange-Id: Ib183515a0418203c8bcc88176e3a1498d7333300\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/0f48ea33f3a06ec8163e283f81d79051ffc1200f"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/0f48ea33f3a06ec8163e283f81d79051ffc1200f"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"90ac3270a8bfe4b94e49cd4c2504b6c85dca14a5","is_merged_in_target_branch":true}],"branch":"refs/heads/master"},"b6a6bf6a388dc4ee1539515157e488b44d009879":{"kind":"REWORK","_number":11,"created":"2013-02-19 19:26:54.000000000","uploader":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"ref":"refs/changes/61/22061/11","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/61/22061/11","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/61/22061/11 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/61/22061/11 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/61/22061/11 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/61/22061/11"}}},"commit":{"parents":[{"commit":"59933249054bf71ec963585198583fe78050c9d6","subject":"Add a safe_minidom_parse_string function.","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/59933249054bf71ec963585198583fe78050c9d6"}]}],"author":{"name":"Aaron Rosen","email":"arosen@nicira.com","date":"2013-02-15 18:41:00.000000000","tz":-480},"committer":{"name":"Aaron Rosen","email":"arosen@nicira.com","date":"2013-02-19 19:22:46.000000000","tz":-480},"subject":"Make nova security groups more pluggable","message":"Make nova security groups more pluggable\n\nThis patch moves the nova security group code out of nova/compute/api.py\ninto nova/network/security_group. It also removes any query to the database\nfrom security group api into the nova security group driver. This allows\nsecurity group drivers the ability to decouple themselves from storing\nsecurity group information in the nova_db.\n\nChange-Id: Ib183515a0418203c8bcc88176e3a1498d7333300\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/b6a6bf6a388dc4ee1539515157e488b44d009879"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/b6a6bf6a388dc4ee1539515157e488b44d009879"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"59933249054bf71ec963585198583fe78050c9d6","is_merged_in_target_branch":true,"change_id":"Ib90d6379320ff1d007f8a661f7ddaa286ba6918e","change_number":22309,"patch_set_number":1,"change_status":"MERGED"}],"branch":"refs/heads/master"},"c3b7a7617ecd9ef8d9de29d8e5595193f97b854d":{"kind":"REWORK","_number":12,"created":"2013-02-19 21:38:30.000000000","uploader":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"ref":"refs/changes/61/22061/12","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/61/22061/12","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/61/22061/12 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/61/22061/12 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/61/22061/12 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/61/22061/12"}}},"commit":{"parents":[{"commit":"f237685e8a2f63c697c60adfe8206abbe5beca45","subject":"Merge \"Stub additional FloatingIP methods in FlatManager\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/f237685e8a2f63c697c60adfe8206abbe5beca45"}]}],"author":{"name":"Aaron Rosen","email":"arosen@nicira.com","date":"2013-02-15 18:41:00.000000000","tz":-480},"committer":{"name":"Aaron Rosen","email":"arosen@nicira.com","date":"2013-02-19 21:34:24.000000000","tz":-480},"subject":"Make nova security groups more pluggable","message":"Make nova security groups more pluggable\n\nThis patch moves the nova security group code out of nova/compute/api.py\ninto nova/network/security_group. It also removes any query to the database\nfrom security group api into the nova security group driver. This allows\nsecurity group drivers the ability to decouple themselves from storing\nsecurity group information in the nova_db.\n\nChange-Id: Ib183515a0418203c8bcc88176e3a1498d7333300\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/c3b7a7617ecd9ef8d9de29d8e5595193f97b854d"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/c3b7a7617ecd9ef8d9de29d8e5595193f97b854d"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"f237685e8a2f63c697c60adfe8206abbe5beca45","is_merged_in_target_branch":true}],"branch":"refs/heads/master"},"000caf758e9311c035a375c738acadf89150992f":{"kind":"REWORK","_number":13,"created":"2013-02-19 21:46:30.000000000","uploader":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"ref":"refs/changes/61/22061/13","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/61/22061/13","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/61/22061/13 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/61/22061/13 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/61/22061/13 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/61/22061/13"}}},"commit":{"parents":[{"commit":"f237685e8a2f63c697c60adfe8206abbe5beca45","subject":"Merge \"Stub additional FloatingIP methods in FlatManager\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/f237685e8a2f63c697c60adfe8206abbe5beca45"}]}],"author":{"name":"Aaron Rosen","email":"arosen@nicira.com","date":"2013-02-15 18:41:00.000000000","tz":-480},"committer":{"name":"Aaron Rosen","email":"arosen@nicira.com","date":"2013-02-19 21:42:24.000000000","tz":-480},"subject":"Make nova security groups more pluggable","message":"Make nova security groups more pluggable\n\nThis patch moves the nova security group code out of nova/compute/api.py\ninto nova/network/security_group. It also removes any query to the database\nfrom security group api into the nova security group driver. This allows\nsecurity group drivers the ability to decouple themselves from storing\nsecurity group information in the nova_db.\n\nChange-Id: Ib183515a0418203c8bcc88176e3a1498d7333300\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/000caf758e9311c035a375c738acadf89150992f"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/000caf758e9311c035a375c738acadf89150992f"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"f237685e8a2f63c697c60adfe8206abbe5beca45","is_merged_in_target_branch":true}],"branch":"refs/heads/master"},"17e38fec95b034e4226bfc6cae56f827c322ee6f":{"kind":"REWORK","_number":14,"created":"2013-02-19 21:53:38.000000000","uploader":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"ref":"refs/changes/61/22061/14","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/61/22061/14","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/61/22061/14 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/61/22061/14 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/61/22061/14 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/61/22061/14"}}},"commit":{"parents":[{"commit":"f237685e8a2f63c697c60adfe8206abbe5beca45","subject":"Merge \"Stub additional FloatingIP methods in FlatManager\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/f237685e8a2f63c697c60adfe8206abbe5beca45"}]}],"author":{"name":"Aaron Rosen","email":"arosen@nicira.com","date":"2013-02-15 18:41:00.000000000","tz":-480},"committer":{"name":"Aaron Rosen","email":"arosen@nicira.com","date":"2013-02-19 21:49:33.000000000","tz":-480},"subject":"Make nova security groups more pluggable","message":"Make nova security groups more pluggable\n\nThis patch moves the nova security group code out of nova/compute/api.py\ninto nova/network/security_group. It also removes any query to the database\nfrom security group api into the nova security group driver. This allows\nsecurity group drivers the ability to decouple themselves from storing\nsecurity group information in the nova_db.\n\nChange-Id: Ib183515a0418203c8bcc88176e3a1498d7333300\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/17e38fec95b034e4226bfc6cae56f827c322ee6f"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/17e38fec95b034e4226bfc6cae56f827c322ee6f"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"f237685e8a2f63c697c60adfe8206abbe5beca45","is_merged_in_target_branch":true}],"branch":"refs/heads/master"},"a69ee525e095c0756d55e7205be0abd825d8c0f9":{"kind":"REWORK","_number":15,"created":"2013-02-20 01:30:27.000000000","uploader":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"ref":"refs/changes/61/22061/15","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/61/22061/15","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/61/22061/15 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/61/22061/15 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/61/22061/15 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/61/22061/15"}}},"commit":{"parents":[{"commit":"5fb2d6ef952658df5d3f85f1f1ad520cb955037f","subject":"Merge \"Fix key check in instance actions formatter.\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/5fb2d6ef952658df5d3f85f1f1ad520cb955037f"}]}],"author":{"name":"Aaron Rosen","email":"arosen@nicira.com","date":"2013-02-15 18:41:00.000000000","tz":-480},"committer":{"name":"Aaron Rosen","email":"arosen@nicira.com","date":"2013-02-20 01:26:33.000000000","tz":-480},"subject":"Make nova security groups more pluggable","message":"Make nova security groups more pluggable\n\nThis patch moves the nova security group code out of nova/compute/api.py\ninto nova/network/security_group. It also removes any query to the database\nfrom security group api into the nova security group driver. This allows\nsecurity group drivers the ability to decouple themselves from storing\nsecurity group information in the nova_db.\n\nChange-Id: Ib183515a0418203c8bcc88176e3a1498d7333300\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/a69ee525e095c0756d55e7205be0abd825d8c0f9"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/a69ee525e095c0756d55e7205be0abd825d8c0f9"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"5fb2d6ef952658df5d3f85f1f1ad520cb955037f","is_merged_in_target_branch":true}],"branch":"refs/heads/master"},"478642a0ecc0eb918da0bfe7eddc8f91bee366f9":{"kind":"TRIVIAL_REBASE","_number":16,"created":"2013-02-20 02:06:44.000000000","uploader":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"ref":"refs/changes/61/22061/16","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/61/22061/16","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/61/22061/16 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/61/22061/16 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/61/22061/16 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/61/22061/16"}}},"commit":{"parents":[{"commit":"4bc4b25c8d155855b16b42a7f87eb2e1f1bd061b","subject":"Merge \"Fix XMLMatcher error reporting\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/4bc4b25c8d155855b16b42a7f87eb2e1f1bd061b"}]}],"author":{"name":"Aaron Rosen","email":"arosen@nicira.com","date":"2013-02-15 18:41:00.000000000","tz":-480},"committer":{"name":"Aaron Rosen","email":"arosen@nicira.com","date":"2013-02-20 02:02:37.000000000","tz":-480},"subject":"Make nova security groups more pluggable","message":"Make nova security groups more pluggable\n\nThis patch moves the nova security group code out of nova/compute/api.py\ninto nova/network/security_group. It also removes any query to the database\nfrom security group api into the nova security group driver. This allows\nsecurity group drivers the ability to decouple themselves from storing\nsecurity group information in the nova_db.\n\nChange-Id: Ib183515a0418203c8bcc88176e3a1498d7333300\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/478642a0ecc0eb918da0bfe7eddc8f91bee366f9"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/478642a0ecc0eb918da0bfe7eddc8f91bee366f9"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"4bc4b25c8d155855b16b42a7f87eb2e1f1bd061b","is_merged_in_target_branch":true}],"branch":"refs/heads/master"},"286da1dc4f6ebfc5e1f3e94d3be5d005d5866794":{"kind":"TRIVIAL_REBASE","_number":17,"created":"2013-02-20 03:44:50.000000000","uploader":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"ref":"refs/changes/61/22061/17","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/61/22061/17","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/61/22061/17 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/61/22061/17 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/61/22061/17 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/61/22061/17"}}},"commit":{"parents":[{"commit":"4e54c59b8888a2c5a8ab41c213d3bff2faba5570","subject":"Merge \"PowerVMDiskAdapter detach/cleanup refactoring\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/4e54c59b8888a2c5a8ab41c213d3bff2faba5570"}]}],"author":{"name":"Aaron Rosen","email":"arosen@nicira.com","date":"2013-02-15 18:41:00.000000000","tz":-480},"committer":{"name":"Aaron Rosen","email":"arosen@nicira.com","date":"2013-02-20 03:40:49.000000000","tz":-480},"subject":"Make nova security groups more pluggable","message":"Make nova security groups more pluggable\n\nThis patch moves the nova security group code out of nova/compute/api.py\ninto nova/network/security_group. It also removes any query to the database\nfrom security group api into the nova security group driver. This allows\nsecurity group drivers the ability to decouple themselves from storing\nsecurity group information in the nova_db.\n\nChange-Id: Ib183515a0418203c8bcc88176e3a1498d7333300\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/286da1dc4f6ebfc5e1f3e94d3be5d005d5866794"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/286da1dc4f6ebfc5e1f3e94d3be5d005d5866794"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"4e54c59b8888a2c5a8ab41c213d3bff2faba5570","is_merged_in_target_branch":true}],"branch":"refs/heads/master"},"b8e1ec8a5f10358ed452ecd1e942bc9af1b4d691":{"kind":"REWORK","_number":18,"created":"2013-02-20 17:48:49.000000000","uploader":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"ref":"refs/changes/61/22061/18","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/61/22061/18","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/61/22061/18 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/61/22061/18 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/61/22061/18 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/61/22061/18"}}},"commit":{"parents":[{"commit":"666cb4eaf70c9f2f8dd05ba0df91f0e7dd6810cb","subject":"Merge \"Add API Sample tests for Hypervisors extension.\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/666cb4eaf70c9f2f8dd05ba0df91f0e7dd6810cb"}]}],"author":{"name":"Aaron Rosen","email":"arosen@nicira.com","date":"2013-02-15 18:41:00.000000000","tz":-480},"committer":{"name":"Aaron Rosen","email":"arosen@nicira.com","date":"2013-02-20 17:43:34.000000000","tz":-480},"subject":"Make nova security groups more pluggable","message":"Make nova security groups more pluggable\n\nThis patch moves the nova security group code out of nova/compute/api.py\ninto nova/network/security_group. It also removes any query to the database\nfrom security group api into the nova security group driver. This allows\nsecurity group drivers the ability to decouple themselves from storing\nsecurity group information in the nova_db.\n\nChange-Id: Ib183515a0418203c8bcc88176e3a1498d7333300\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/b8e1ec8a5f10358ed452ecd1e942bc9af1b4d691"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/b8e1ec8a5f10358ed452ecd1e942bc9af1b4d691"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"666cb4eaf70c9f2f8dd05ba0df91f0e7dd6810cb","is_merged_in_target_branch":true}],"branch":"refs/heads/master"},"671118e659773dd19874b933ec84b419b8bc0778":{"kind":"TRIVIAL_REBASE","_number":19,"created":"2013-02-20 18:36:40.000000000","uploader":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"ref":"refs/changes/61/22061/19","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/61/22061/19","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/61/22061/19 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/61/22061/19 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/61/22061/19 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/61/22061/19"}}},"commit":{"parents":[{"commit":"f478fa696746ba61f3749a9b0559bbbaaf25cfa5","subject":"Merge \"Prevent the unexpected with nova-manage network modify.\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/f478fa696746ba61f3749a9b0559bbbaaf25cfa5"}]}],"author":{"name":"Aaron Rosen","email":"arosen@nicira.com","date":"2013-02-15 18:41:00.000000000","tz":-480},"committer":{"name":"Aaron Rosen","email":"arosen@nicira.com","date":"2013-02-20 18:32:40.000000000","tz":-480},"subject":"Make nova security groups more pluggable","message":"Make nova security groups more pluggable\n\nThis patch moves the nova security group code out of nova/compute/api.py\ninto nova/network/security_group. It also removes any query to the database\nfrom security group api into the nova security group driver. This allows\nsecurity group drivers the ability to decouple themselves from storing\nsecurity group information in the nova_db.\n\nChange-Id: Ib183515a0418203c8bcc88176e3a1498d7333300\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/671118e659773dd19874b933ec84b419b8bc0778"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/671118e659773dd19874b933ec84b419b8bc0778"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"f478fa696746ba61f3749a9b0559bbbaaf25cfa5","is_merged_in_target_branch":true}],"branch":"refs/heads/master"},"d562012f34eadfe6b68dd5ebe06a2fa565de3b2e":{"kind":"REWORK","_number":20,"created":"2013-02-20 19:31:17.000000000","uploader":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"ref":"refs/changes/61/22061/20","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/61/22061/20","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/61/22061/20 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/61/22061/20 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/61/22061/20 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/61/22061/20"}}},"commit":{"parents":[{"commit":"51055262c2e354d3ad69f7ce6470a6b549881aad","subject":"Merge \"Fix handling of source_groups with no-db-compute.\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/51055262c2e354d3ad69f7ce6470a6b549881aad"}]}],"author":{"name":"Aaron Rosen","email":"arosen@nicira.com","date":"2013-02-15 18:41:00.000000000","tz":-480},"committer":{"name":"Aaron Rosen","email":"arosen@nicira.com","date":"2013-02-20 19:27:01.000000000","tz":-480},"subject":"Make nova security groups more pluggable","message":"Make nova security groups more pluggable\n\nThis patch moves the nova security group code out of nova/compute/api.py\ninto nova/network/security_group. It also removes any query to the database\nfrom security group api into the nova security group driver. This allows\nsecurity group drivers the ability to decouple themselves from storing\nsecurity group information in the nova_db.\n\nChange-Id: Ib183515a0418203c8bcc88176e3a1498d7333300\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/d562012f34eadfe6b68dd5ebe06a2fa565de3b2e"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/d562012f34eadfe6b68dd5ebe06a2fa565de3b2e"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"51055262c2e354d3ad69f7ce6470a6b549881aad","is_merged_in_target_branch":true}],"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}