)]}'
{"nova/objects/pci_device_pool.py":[{"author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"change_message_id":"63f3cc8d5564e7e334653ccf8e719cc242d720dd","unresolved":false,"context_lines":[{"line_number":105,"context_line":"            else:"},{"line_number":106,"context_line":"                pool_list \u003d [objects.PciDevicePool.from_dict(pci_stats)]"},{"line_number":107,"context_line":"            pools \u003d objects.PciDevicePoolList(objects\u003dpool_list)"},{"line_number":108,"context_line":"    else:"},{"line_number":109,"context_line":"        pools \u003d objects.PciDevicePoolList()"},{"line_number":110,"context_line":"    return pools"}],"source_content_type":"text/x-python","patch_set":1,"id":"da20952f_adb89012","line":108,"updated":"2015-09-09 17:19:09.000000000","message":"This nesting makes the code hard to read. How about something like this:\n\n    pools \u003d []\n    if pci_stats:\n        ... calculate pool_list and pools\n    return objects.PciDevicePoolList(objects\u003dpools)","commit_id":"439184bf8e45543ca36bed4183bf921ba77ca761"},{"author":{"_account_id":13289,"name":"Taylor Peoples","email":"tpeoples@us.ibm.com","username":"tpeoples"},"change_message_id":"a5f3b96878c687dce430db42184d1446acb82a87","unresolved":false,"context_lines":[{"line_number":105,"context_line":"            else:"},{"line_number":106,"context_line":"                pool_list \u003d [objects.PciDevicePool.from_dict(pci_stats)]"},{"line_number":107,"context_line":"            pools \u003d objects.PciDevicePoolList(objects\u003dpool_list)"},{"line_number":108,"context_line":"    else:"},{"line_number":109,"context_line":"        pools \u003d objects.PciDevicePoolList()"},{"line_number":110,"context_line":"    return pools"}],"source_content_type":"text/x-python","patch_set":1,"id":"da20952f_83055d15","line":108,"in_reply_to":"da20952f_adb89012","updated":"2015-09-09 18:23:32.000000000","message":"Hopefully this is addressed by patch set 2.  The special case for nova_object.namespace in pci_stats was handled by just returning early since obj_from_primitive will already be in the object format we want.","commit_id":"439184bf8e45543ca36bed4183bf921ba77ca761"}],"nova/tests/unit/objects/test_pci_device_pool.py":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"037c11ead92c3d1dbea88cdbaf1c42948f476c8d","unresolved":false,"context_lines":[{"line_number":109,"context_line":"    def test_from_pci_stats_bad(self):"},{"line_number":110,"context_line":"        prim \u003d \"not a valid json string for an object\""},{"line_number":111,"context_line":"        pools \u003d pci_device_pool.from_pci_stats(prim)"},{"line_number":112,"context_line":"        self.assertEqual(len(pools), 0)"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba8a016a_acc3c737","line":112,"updated":"2015-11-20 20:44:01.000000000","message":"This should be (expected, actual)","commit_id":"8df3810ca0bb4a78a209be74b07769dcbdf9787b"}]}