)]}'
{"nova/tests/test_libvirt_blockinfo.py":[{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"53b1882ac36d851085e7c392ae13c58d07b87c95","unresolved":false,"context_lines":[{"line_number":189,"context_line":"                                             None)"},{"line_number":190,"context_line":"        expect \u003d {"},{"line_number":191,"context_line":"            \u0027disk\u0027: {\u0027bus\u0027: \u0027lxc\u0027, \u0027type\u0027: \u0027disk\u0027, \u0027dev\u0027: \u0027a\u0027},"},{"line_number":192,"context_line":"            \u0027root\u0027: {\u0027bus\u0027: \u0027lxc\u0027, \u0027type\u0027: \u0027disk\u0027, \u0027dev\u0027: \u0027a\u0027}"},{"line_number":193,"context_line":"        }"},{"line_number":194,"context_line":"        self.assertEqual(mapping, expect)"},{"line_number":195,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2B3BA%3D","line":192,"updated":"2013-02-16 10:50:36.000000000","message":"IMHO \u0027dev\u0027 here should be None, since there is no meaningful dev for LXC","commit_id":"335e6baf9c1e70d1f595948da8520791ed33cd90"},{"author":{"_account_id":24,"name":"Chuck Short","email":"charles.short@windriver.com","username":"zulcss"},"change_message_id":"41575e7ee6b84d69f6c5e6c8a7f24a144f10db58","unresolved":false,"context_lines":[{"line_number":189,"context_line":"                                             None)"},{"line_number":190,"context_line":"        expect \u003d {"},{"line_number":191,"context_line":"            \u0027disk\u0027: {\u0027bus\u0027: \u0027lxc\u0027, \u0027type\u0027: \u0027disk\u0027, \u0027dev\u0027: \u0027a\u0027},"},{"line_number":192,"context_line":"            \u0027root\u0027: {\u0027bus\u0027: \u0027lxc\u0027, \u0027type\u0027: \u0027disk\u0027, \u0027dev\u0027: \u0027a\u0027}"},{"line_number":193,"context_line":"        }"},{"line_number":194,"context_line":"        self.assertEqual(mapping, expect)"},{"line_number":195,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2B28M%3D","line":192,"in_reply_to":"AAAAM3%2F%2B3BA%3D","updated":"2013-02-16 13:29:47.000000000","message":"Done","commit_id":"335e6baf9c1e70d1f595948da8520791ed33cd90"}],"nova/virt/libvirt/blockinfo.py":[{"author":{"_account_id":1082,"name":"Scott Moser","email":"smoser@ubuntu.com","username":"smoser"},"change_message_id":"4f539435def6e5ae49f9fc642697ce80a1204be2","unresolved":false,"context_lines":[{"line_number":117,"context_line":"    elif disk_bus \u003d\u003d \"uml\":"},{"line_number":118,"context_line":"        return \"ubd\""},{"line_number":119,"context_line":"    elif disk_bus \u003d\u003d \"lxc\":"},{"line_number":120,"context_line":"        return \"\""},{"line_number":121,"context_line":"    else:"},{"line_number":122,"context_line":"        raise exception.NovaException("},{"line_number":123,"context_line":"            _(\"Unable to determine disk prefix for %s\") %"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2B36c%3D","line":120,"updated":"2013-02-15 20:40:58.000000000","message":"It seems like \u0027\u0027 might be confusing here.  None or \"LXC_BUS\" might be better. so that debugging might be more obvious in the event of an error.","commit_id":"335e6baf9c1e70d1f595948da8520791ed33cd90"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"53b1882ac36d851085e7c392ae13c58d07b87c95","unresolved":false,"context_lines":[{"line_number":117,"context_line":"    elif disk_bus \u003d\u003d \"uml\":"},{"line_number":118,"context_line":"        return \"ubd\""},{"line_number":119,"context_line":"    elif disk_bus \u003d\u003d \"lxc\":"},{"line_number":120,"context_line":"        return \"\""},{"line_number":121,"context_line":"    else:"},{"line_number":122,"context_line":"        raise exception.NovaException("},{"line_number":123,"context_line":"            _(\"Unable to determine disk prefix for %s\") %"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2B3BI%3D","line":120,"in_reply_to":"AAAAM3%2F%2B36c%3D","updated":"2013-02-16 10:50:36.000000000","message":"Agreed, I think we should return None here, since there is no meaningful disk bus for LXC.","commit_id":"335e6baf9c1e70d1f595948da8520791ed33cd90"},{"author":{"_account_id":24,"name":"Chuck Short","email":"charles.short@windriver.com","username":"zulcss"},"change_message_id":"41575e7ee6b84d69f6c5e6c8a7f24a144f10db58","unresolved":false,"context_lines":[{"line_number":117,"context_line":"    elif disk_bus \u003d\u003d \"uml\":"},{"line_number":118,"context_line":"        return \"ubd\""},{"line_number":119,"context_line":"    elif disk_bus \u003d\u003d \"lxc\":"},{"line_number":120,"context_line":"        return \"\""},{"line_number":121,"context_line":"    else:"},{"line_number":122,"context_line":"        raise exception.NovaException("},{"line_number":123,"context_line":"            _(\"Unable to determine disk prefix for %s\") %"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2B28Y%3D","line":120,"in_reply_to":"AAAAM3%2F%2B36c%3D","updated":"2013-02-16 13:29:47.000000000","message":"Done","commit_id":"335e6baf9c1e70d1f595948da8520791ed33cd90"},{"author":{"_account_id":24,"name":"Chuck Short","email":"charles.short@windriver.com","username":"zulcss"},"change_message_id":"41575e7ee6b84d69f6c5e6c8a7f24a144f10db58","unresolved":false,"context_lines":[{"line_number":117,"context_line":"    elif disk_bus \u003d\u003d \"uml\":"},{"line_number":118,"context_line":"        return \"ubd\""},{"line_number":119,"context_line":"    elif disk_bus \u003d\u003d \"lxc\":"},{"line_number":120,"context_line":"        return \"\""},{"line_number":121,"context_line":"    else:"},{"line_number":122,"context_line":"        raise exception.NovaException("},{"line_number":123,"context_line":"            _(\"Unable to determine disk prefix for %s\") %"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2B28U%3D","line":120,"in_reply_to":"AAAAM3%2F%2B3BI%3D","updated":"2013-02-16 13:29:47.000000000","message":"Done","commit_id":"335e6baf9c1e70d1f595948da8520791ed33cd90"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"53b1882ac36d851085e7c392ae13c58d07b87c95","unresolved":false,"context_lines":[{"line_number":150,"context_line":"       Returns the chosen disk_dev name, or raises an"},{"line_number":151,"context_line":"       exception if none is available."},{"line_number":152,"context_line":"    \"\"\""},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"    dev_prefix \u003d get_dev_prefix_for_disk_bus(bus)"},{"line_number":155,"context_line":"    max_dev \u003d get_dev_count_for_disk_bus(bus)"},{"line_number":156,"context_line":"    if last_device:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2B3BE%3D","line":153,"updated":"2013-02-16 10:50:36.000000000","message":"And here we should check for a None prefix, and return None as the disk dev","commit_id":"335e6baf9c1e70d1f595948da8520791ed33cd90"},{"author":{"_account_id":24,"name":"Chuck Short","email":"charles.short@windriver.com","username":"zulcss"},"change_message_id":"41575e7ee6b84d69f6c5e6c8a7f24a144f10db58","unresolved":false,"context_lines":[{"line_number":150,"context_line":"       Returns the chosen disk_dev name, or raises an"},{"line_number":151,"context_line":"       exception if none is available."},{"line_number":152,"context_line":"    \"\"\""},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"    dev_prefix \u003d get_dev_prefix_for_disk_bus(bus)"},{"line_number":155,"context_line":"    max_dev \u003d get_dev_count_for_disk_bus(bus)"},{"line_number":156,"context_line":"    if last_device:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2B28Q%3D","line":153,"in_reply_to":"AAAAM3%2F%2B3BE%3D","updated":"2013-02-16 13:29:47.000000000","message":"Done","commit_id":"335e6baf9c1e70d1f595948da8520791ed33cd90"}]}