)]}'
{"nova/conductor/api.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"d2a7e5701e8ff826429352dfb289bb1ba45bacba","unresolved":false,"context_lines":[{"line_number":65,"context_line":"        return self._manager.provider_fw_rule_get_all(context)"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    def object_backport(self, context, objinst, target_version):"},{"line_number":68,"context_line":"        return self._manager.object_backport(context, objinst, target_version)"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"    def object_backport_versions(self, context, objinst, object_versions):"},{"line_number":71,"context_line":"        return self._manager.object_backport_versions(context, objinst,"}],"source_content_type":"text/x-python","patch_set":1,"id":"da20952f_21cfb6b4","side":"PARENT","line":68,"updated":"2015-09-09 14:12:23.000000000","message":"So, you\u0027re right that we should be able to remove this. However, it makes me a little nervous since (a) we JUST switched to it and (b) the library technically still falls back to this older method in some circumstances. It would be immensely confusing to see a failure where the fallback to this method ended up with an AttributeError here.\n\nMy proposed solutions (in order of preference) would be:\n\n1. Just  leave this here. It\u0027s not hurting much to keep it on the server and client side, especially with as much as you\u0027re getting ready to dump in the next patch. If something goes wrong with the version-based approach once we snap liberty, it\u0027ll be easy to roll back.\n\n2. Leave this here, but log and raise with a very clear description of what is going on, which will be much more useful than the generic AttributeError that we\u0027d get if we don\u0027t.","commit_id":"32c56137b462b6c490165d8c8230c28cc8f7ac7f"},{"author":{"_account_id":6450,"name":"Hans Lindgren","email":"hanlind@kth.se","username":"hanlind"},"change_message_id":"727b34fc11168591bd86608171f678509317e4d8","unresolved":false,"context_lines":[{"line_number":65,"context_line":"        return self._manager.provider_fw_rule_get_all(context)"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    def object_backport(self, context, objinst, target_version):"},{"line_number":68,"context_line":"        return self._manager.object_backport(context, objinst, target_version)"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"    def object_backport_versions(self, context, objinst, object_versions):"},{"line_number":71,"context_line":"        return self._manager.object_backport_versions(context, objinst,"}],"source_content_type":"text/x-python","patch_set":1,"id":"da20952f_6a39fea2","side":"PARENT","line":68,"in_reply_to":"da20952f_01d392d6","updated":"2015-09-09 16:53:52.000000000","message":"Yes, leaving it but call object_backport_versions sounds like the best approach.","commit_id":"32c56137b462b6c490165d8c8230c28cc8f7ac7f"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"816d9c7ea4e0243cece39979f13c0f29dc47acbc","unresolved":false,"context_lines":[{"line_number":65,"context_line":"        return self._manager.provider_fw_rule_get_all(context)"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    def object_backport(self, context, objinst, target_version):"},{"line_number":68,"context_line":"        return self._manager.object_backport(context, objinst, target_version)"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"    def object_backport_versions(self, context, objinst, object_versions):"},{"line_number":71,"context_line":"        return self._manager.object_backport_versions(context, objinst,"}],"source_content_type":"text/x-python","patch_set":1,"id":"da20952f_01d392d6","side":"PARENT","line":68,"in_reply_to":"da20952f_21cfb6b4","updated":"2015-09-09 14:23:26.000000000","message":"You know, we could do what I did for class_action_versions.. We could leave this here, call object_backport_versions, first collecting the manifest.","commit_id":"32c56137b462b6c490165d8c8230c28cc8f7ac7f"}],"nova/conductor/manager.py":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"429be5e39c11c857fd8ed939a6ed87299176ff42","unresolved":false,"context_lines":[{"line_number":447,"context_line":"        except Exception:"},{"line_number":448,"context_line":"            raise messaging.ExpectedException()"},{"line_number":449,"context_line":""},{"line_number":450,"context_line":"    # NOTE(hanlind): This can be removed in version 3.0 of the RPC API"},{"line_number":451,"context_line":"    def object_class_action(self, context, objname, objmethod,"},{"line_number":452,"context_line":"                            objver, args, kwargs):"},{"line_number":453,"context_line":"        \"\"\"Perform a classmethod action on an object.\"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"da20952f_01cd3765","line":450,"updated":"2015-09-07 08:17:29.000000000","message":"Nit: this is kinda unrelated, but there is no better place for it","commit_id":"67c308bc57153f4c316da0c3eff89260a12164fe"}]}