)]}'
{"nova/network/neutronv2/api.py":[{"author":{"_account_id":14819,"name":"Timofey Durakov","email":"timofei.nd@gmail.com","username":"tdurakov"},"change_message_id":"2737a0b383db73435fbe08d74afcb3833f69671e","unresolved":false,"context_lines":[{"line_number":201,"context_line":"    with lockutils.lock(\u0027neutron_admin_auth_token_lock\u0027):"},{"line_number":202,"context_line":"        # FIXME(jamielennox): We should also retrieve the endpoint from the"},{"line_number":203,"context_line":"        # catalog here rather than relying on setting it in CONF."},{"line_number":204,"context_line":"        auth_token \u003d _ADMIN_AUTH.get_token(_SESSION)"},{"line_number":205,"context_line":""},{"line_number":206,"context_line":"    return auth_token"},{"line_number":207,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"da20952f_21271264","line":204,"updated":"2015-09-07 12:34:41.000000000","message":"the problem here, that the same token would be returned. _ADMIN_AUTH doesn\u0027t know that token become invalid. It will check that there is enough time before expiration and returns it again. You could maybe add invalidate_token flag into method params, but all threads then would call _get_admin_auth_token with invalidate_flag again and again...","commit_id":"5d8943847bfdb05a1895d12e5061ea18fc75f6d3"},{"author":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"change_message_id":"0bccbc0eb54a2eda0c552b8a24c4e8c65c90339b","unresolved":false,"context_lines":[{"line_number":201,"context_line":"    with lockutils.lock(\u0027neutron_admin_auth_token_lock\u0027):"},{"line_number":202,"context_line":"        # FIXME(jamielennox): We should also retrieve the endpoint from the"},{"line_number":203,"context_line":"        # catalog here rather than relying on setting it in CONF."},{"line_number":204,"context_line":"        auth_token \u003d _ADMIN_AUTH.get_token(_SESSION)"},{"line_number":205,"context_line":""},{"line_number":206,"context_line":"    return auth_token"},{"line_number":207,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"da20952f_00367f50","line":204,"in_reply_to":"da20952f_21271264","updated":"2015-09-07 16:47:55.000000000","message":"Ah. Let me try tweaking the logic to accomodate that.","commit_id":"5d8943847bfdb05a1895d12e5061ea18fc75f6d3"},{"author":{"_account_id":14819,"name":"Timofey Durakov","email":"timofei.nd@gmail.com","username":"tdurakov"},"change_message_id":"2737a0b383db73435fbe08d74afcb3833f69671e","unresolved":false,"context_lines":[{"line_number":217,"context_line":""},{"line_number":218,"context_line":"    def get_token(self, session):"},{"line_number":219,"context_line":"        if self.token is None:"},{"line_number":220,"context_line":"            self.token \u003d get_admin_auth_token(_SESSION)"},{"line_number":221,"context_line":"        return self.token"},{"line_number":222,"context_line":""},{"line_number":223,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"da20952f_a16562af","line":220,"updated":"2015-09-07 12:34:41.000000000","message":"if no token in AdminAuthPlugin, it asks new one in  v2.Password plugin, aka, _ADMIN_AUTH","commit_id":"5d8943847bfdb05a1895d12e5061ea18fc75f6d3"},{"author":{"_account_id":14819,"name":"Timofey Durakov","email":"timofei.nd@gmail.com","username":"tdurakov"},"change_message_id":"c2c5dcc5040f1a45e720d2ea9071134d72fafe2c","unresolved":false,"context_lines":[{"line_number":214,"context_line":"            endpoint, get_admin_auth_token(_SESSION))"},{"line_number":215,"context_line":""},{"line_number":216,"context_line":"    def invalidate(self):"},{"line_number":217,"context_line":"        if invalidate_admin_auth_token():"},{"line_number":218,"context_line":"            self.token \u003d None"},{"line_number":219,"context_line":"            return True"},{"line_number":220,"context_line":"        return False"}],"source_content_type":"text/x-python","patch_set":9,"id":"ba15a1d1_84b6fc3b","line":217,"updated":"2015-09-14 08:43:35.000000000","message":"I think you should add smth like: \nif self.token is not None:\n  return True\nsome kind of double check locking","commit_id":"a77df1f18147ce2fd488e8e30e5e5c8a4ed8d53c"}]}