)]}'
{"nova/compute/utils.py":[{"author":{"_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},"change_message_id":"2a9c757abc87f9a8f5ad4e069e698d96bd4760ea","unresolved":false,"context_lines":[{"line_number":134,"context_line":"    name is valid but applicable to a different backend (for example"},{"line_number":135,"context_line":"    /dev/vdc is specified but the backend uses /dev/xvdc), the device"},{"line_number":136,"context_line":"    name will be converted to the appropriate format."},{"line_number":137,"context_line":"    \"\"\""},{"line_number":138,"context_line":"    is_xen \u003d driver.compute_driver_matches(\u0027xenapi.XenAPIDriver\u0027)"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"    req_prefix \u003d None"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba15a1d1_d07bae26","line":137,"updated":"2015-09-17 11:08:33.000000000","message":"We should be completely removing this in the follow up patch - importing the driver here is wrong since this module is imported in the API and basically all other services via objects, which may not have the right info so can be a very subtle source of bugs.","commit_id":"daab35f9fe844f382c84bce785da9959a53e4abe"}],"nova/tests/unit/compute/test_compute_utils.py":[{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"749bbc812b7896d400d581e5d819328eee306736","unresolved":false,"context_lines":[{"line_number":242,"context_line":"        self.stubs.Set(flavors, \u0027get_flavor\u0027,"},{"line_number":243,"context_line":"                       lambda instance_type_id, ctxt\u003dNone: self.flavor)"},{"line_number":244,"context_line":"        device \u003d self._validate_device()"},{"line_number":245,"context_line":"        self.assertEqual(device, \u0027/dev/xvdb\u0027)"},{"line_number":246,"context_line":""},{"line_number":247,"context_line":"    def test_swap_and_one_attachment_xenapi(self):"},{"line_number":248,"context_line":"        self._update_flavor({"}],"source_content_type":"text/x-python","patch_set":3,"id":"da20952f_8752e910","line":245,"updated":"2015-09-11 20:03:18.000000000","message":"The change you\u0027ve made makes these tests basically useless.  Having a test to assert that /dev/xvdb is returned is good, but goes against the spirit of the modified tests here.  Rather than calling _validate_device you may want to call _get_device_name_for_instance in the test and pass in a bdm that uses /dev/xvdb so that the tests can check for device letters c and e respectively.","commit_id":"daab35f9fe844f382c84bce785da9959a53e4abe"}]}