)]}'
{"id":"openstack%2Fnova~222026","triplet_id":"openstack%2Fnova~stable%2Fjuno~I36a954c095a9aa35879200784dc18e35edf689e6","project":"openstack/nova","branch":"stable/juno","topic":"bug/1484738-juno","hashtags":[],"change_id":"I36a954c095a9aa35879200784dc18e35edf689e6","subject":"Don\u0027t expect meta attributes in object_compat that aren\u0027t in the db obj","status":"MERGED","created":"2015-09-10 03:43:57.000000000","updated":"2015-09-11 02:32:08.000000000","submitted":"2015-09-11 02:31:59.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"ec7ae292b21814cb52a1e33dc6957383be8f4f8b","_number":222026,"virtual_id_number":222026,"owner":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"date":"2015-09-10 05:46:51.000000000","_account_id":5170,"name":"Microsoft Hyper-V CI","email":"hyper-v_ci@microsoft.com","username":"hyper-v-ci","tags":["SERVICE_USER"]},{"value":2,"date":"2015-09-11 02:31:59.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"date":"2015-09-10 03:51:21.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"value":0,"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},{"value":0,"_account_id":1420,"name":"Adam Gandelman","email":"adamg@ubuntu.com","username":"gandelman-a"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"all":[{"value":0,"_account_id":5170,"name":"Microsoft Hyper-V CI","email":"hyper-v_ci@microsoft.com","username":"hyper-v-ci","tags":["SERVICE_USER"]},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"value":2,"date":"2015-09-10 22:57:02.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},{"value":2,"date":"2015-09-11 00:29:30.000000000","_account_id":1420,"name":"Adam Gandelman","email":"adamg@ubuntu.com","username":"gandelman-a"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":1420,"name":"Adam Gandelman","email":"adamg@ubuntu.com","username":"gandelman-a"},"all":[{"value":0,"_account_id":5170,"name":"Microsoft Hyper-V CI","email":"hyper-v_ci@microsoft.com","username":"hyper-v-ci","tags":["SERVICE_USER"]},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"value":0,"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},{"value":1,"date":"2015-09-11 00:29:30.000000000","_account_id":1420,"name":"Adam Gandelman","email":"adamg@ubuntu.com","username":"gandelman-a"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":5170,"name":"Microsoft Hyper-V CI","email":"hyper-v_ci@microsoft.com","username":"hyper-v-ci","tags":["SERVICE_USER"]},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},{"value":0,"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},{"value":0,"_account_id":1420,"name":"Adam Gandelman","email":"adamg@ubuntu.com","username":"gandelman-a"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":1420,"name":"Adam Gandelman","email":"adamg@ubuntu.com","username":"gandelman-a"},{"_account_id":5170,"name":"Microsoft Hyper-V CI","email":"hyper-v_ci@microsoft.com","username":"hyper-v-ci","tags":["SERVICE_USER"]},{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2015-09-10 03:51:21.000000000","updated_by":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"reviewer":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2015-09-10 05:46:51.000000000","updated_by":{"_account_id":5170,"name":"Microsoft Hyper-V CI","email":"hyper-v_ci@microsoft.com","username":"hyper-v-ci","tags":["SERVICE_USER"]},"reviewer":{"_account_id":5170,"name":"Microsoft Hyper-V CI","email":"hyper-v_ci@microsoft.com","username":"hyper-v-ci","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2015-09-10 22:57:02.000000000","updated_by":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"reviewer":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"state":"REVIEWER"},{"updated":"2015-09-11 00:29:30.000000000","updated_by":{"_account_id":1420,"name":"Adam Gandelman","email":"adamg@ubuntu.com","username":"gandelman-a"},"reviewer":{"_account_id":1420,"name":"Adam Gandelman","email":"adamg@ubuntu.com","username":"gandelman-a"},"state":"REVIEWER"},{"updated":"2015-09-11 02:31:59.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"5bbd00fdab3f30642ac12dd681bb884604fd74ff","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2015-09-10 03:43:57.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"21ba3d9b7791011ae4ef4d6046eb9b44fdf5c207","author":{"_account_id":10118,"name":"IBM PowerKVM CI","email":"kvmpower@linux.vnet.ibm.com","username":"powerkvm","tags":["SERVICE_USER"]},"date":"2015-09-10 03:51:21.000000000","message":"Patch Set 1:\n\nTesting completed on IBM PowerKVM platform. For rechecking only on the IBM PowerKVM CI, add a review comment with pkvm-recheck. Contact info: kvmpower@linux.vnet.ibm.com. For more information, see https://wiki.openstack.org/wiki/PowerKVM\n\n- check-ibm-tempest-dsvm-full http://dal05.objectstorage.softlayer.net/v1/AUTH_3d8e6ecb-f597-448c-8ec2-164e9f710dd6/pkvmci/222026/1/check-ibm-tempest-dsvm-full/781edd7 : FAILURE in 6m 38s (non-voting)\n- check-ibm-tempest-dsvm-postgres-full http://dal05.objectstorage.softlayer.net/v1/AUTH_3d8e6ecb-f597-448c-8ec2-164e9f710dd6/pkvmci/222026/1/check-ibm-tempest-dsvm-postgres-full/370e2e0 : FAILURE in 6m 41s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"f26c1872110598b5794805c475056a81b16c6b60","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-09-10 04:30:56.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-nova-python26 http://logs.openstack.org/26/222026/1/check/gate-nova-python26/2fed936/ : SUCCESS in 18m 08s\n- gate-nova-pep8 http://logs.openstack.org/26/222026/1/check/gate-nova-pep8/64f9413/ : SUCCESS in 8m 30s\n- gate-nova-docs http://docs-draft.openstack.org/26/222026/1/check/gate-nova-docs/6431c91//doc/build/html/ : SUCCESS in 18m 14s\n- gate-nova-python27 http://logs.openstack.org/26/222026/1/check/gate-nova-python27/c19be4b/ : SUCCESS in 18m 48s\n- gate-tempest-dsvm-full http://logs.openstack.org/26/222026/1/check/gate-tempest-dsvm-full/3ec3f9b/ : SUCCESS in 41m 47s\n- gate-tempest-dsvm-postgres-full http://logs.openstack.org/26/222026/1/check/gate-tempest-dsvm-postgres-full/292c874/ : SUCCESS in 41m 40s\n- gate-tempest-dsvm-neutron-full http://logs.openstack.org/26/222026/1/check/gate-tempest-dsvm-neutron-full/889a070/ : SUCCESS in 45m 28s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/26/222026/1/check/gate-tempest-dsvm-large-ops/a286a76/ : SUCCESS in 17m 47s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/26/222026/1/check/gate-tempest-dsvm-neutron-large-ops/da4fab7/ : SUCCESS in 24m 36s\n- gate-devstack-dsvm-cells http://logs.openstack.org/26/222026/1/check/gate-devstack-dsvm-cells/6a74a8a/ : SUCCESS in 16m 59s\n- gate-grenade-dsvm-ironic-sideways http://logs.openstack.org/26/222026/1/check/gate-grenade-dsvm-ironic-sideways/7a51a9c/ : SUCCESS in 34m 12s","accounts_in_message":[],"_revision_number":1},{"id":"72fbd8a89a1c35686a0bb5f247afb5926ebba460","author":{"_account_id":5170,"name":"Microsoft Hyper-V CI","email":"hyper-v_ci@microsoft.com","username":"hyper-v-ci","tags":["SERVICE_USER"]},"date":"2015-09-10 05:46:51.000000000","message":"Patch Set 1:\n\nBuild succeeded.\n\n- hyper-v-ci http://64.119.130.115/222026/1/ : FAILURE in 2h 02m 00s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"f22960ff89d6bed5f5c6e5314fd484bcd2cfe898","author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"date":"2015-09-10 22:57:02.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"a86f69c700fb9d1835bf776f242703ef795a3edc","author":{"_account_id":1420,"name":"Adam Gandelman","email":"adamg@ubuntu.com","username":"gandelman-a"},"date":"2015-09-11 00:29:30.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"9b5cd3f8f19a50a9fa716f504f760cf844ec78a5","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-09-11 00:30:17.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"e05b1b85c8d1839e89fd633afe9a3c5db5b461fc","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-09-11 02:31:59.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-nova-python26 http://logs.openstack.org/26/222026/1/gate/gate-nova-python26/95c1636/ : SUCCESS in 18m 07s\n- gate-nova-docs http://docs-draft.openstack.org/26/222026/1/gate/gate-nova-docs/0ae9ad4//doc/build/html/ : SUCCESS in 19m 45s\n- gate-nova-pep8 http://logs.openstack.org/26/222026/1/gate/gate-nova-pep8/9195c7e/ : SUCCESS in 8m 08s\n- gate-nova-python27 http://logs.openstack.org/26/222026/1/gate/gate-nova-python27/e488673/ : SUCCESS in 15m 30s\n- gate-tempest-dsvm-full http://logs.openstack.org/26/222026/1/gate/gate-tempest-dsvm-full/f05b4d0/ : SUCCESS in 42m 23s\n- gate-tempest-dsvm-postgres-full http://logs.openstack.org/26/222026/1/gate/gate-tempest-dsvm-postgres-full/d6d3af0/ : SUCCESS in 42m 14s\n- gate-tempest-dsvm-neutron-full http://logs.openstack.org/26/222026/1/gate/gate-tempest-dsvm-neutron-full/0765578/ : SUCCESS in 1h 04m 00s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/26/222026/1/gate/gate-tempest-dsvm-large-ops/402e45a/ : SUCCESS in 22m 49s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/26/222026/1/gate/gate-tempest-dsvm-neutron-large-ops/c1416ab/ : SUCCESS in 21m 33s\n- gate-devstack-dsvm-cells http://logs.openstack.org/26/222026/1/gate/gate-devstack-dsvm-cells/abe4f7f/ : SUCCESS in 18m 48s\n- gate-grenade-dsvm-ironic-sideways http://logs.openstack.org/26/222026/1/gate/gate-grenade-dsvm-ironic-sideways/70ae0e9/ : SUCCESS in 33m 57s","accounts_in_message":[],"_revision_number":1},{"id":"97c8876a5fb02f2e2b86d1d70c5bc09864083210","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-09-11 02:32:08.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"dc5ced25c61fc742c513abc03b92e2d8f8042d8c","revisions":{"dc5ced25c61fc742c513abc03b92e2d8f8042d8c":{"kind":"REWORK","_number":1,"created":"2015-09-10 03:43:57.000000000","uploader":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"ref":"refs/changes/26/222026/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/26/222026/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/26/222026/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/26/222026/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/26/222026/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/26/222026/1"}}},"commit":{"parents":[{"commit":"3dd5bb32bb62fae7aa4958dcbabd01a49b975f79","subject":"Merge \"Don\u0027t pass the service catalog when making glance requests\" into stable/juno","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/3dd5bb32bb62fae7aa4958dcbabd01a49b975f79"}]}],"author":{"name":"Matt Riedemann","email":"mriedem@us.ibm.com","date":"2015-09-10 03:29:09.000000000","tz":-420},"committer":{"name":"Matt Riedemann","email":"mriedem@us.ibm.com","date":"2015-09-10 03:42:38.000000000","tz":-420},"subject":"Don\u0027t expect meta attributes in object_compat that aren\u0027t in the db obj","message":"Don\u0027t expect meta attributes in object_compat that aren\u0027t in the db obj\n\nThe object_compat decorator expects to get the Instance object with\n\u0027metadata\u0027 and \u0027system_metadata\u0027 attributes but if those aren\u0027t in the\ndb instance dict object, Instance._from_db_object will fail with a\nKeyError.\n\nIn Kilo this happens per refresh_instance_security_rules because in the\ncompute API code, the instance passed to refresh_instance_security_rules\ncomes from the call to get the security group(s) which joins on the\ninstances column, but that doesn\u0027t join on the metadata/system_metadata\nfields for the instances.  So when the instances get to object_compat in\nthe compute manager and the db instance dict is converted to the\nInstance object, it expects fields that aren\u0027t in the dict and we get\nthe KeyError.\n\nThe refresh_instance_security_rules case is fixed in Liberty per commit\n12fbe6f082ef9b70b89302e15daa12e851e507a7 - in that case the compute API\npasses Instance objects to the compute manager so object_compat doesn\u0027t\nhave anything to do, _load_instance just sees instance_or_dict isn\u0027t a\ndict and ignores it.\n\nWe\u0027re making this change since (1) it\u0027s an obviously wrong assumption in\nobject_compat and should be fixed and (2) we need to backport this fix\nto stable/kilo since it\u0027s an upgrade impact for users there.\n\nCloses-Bug: #1484738\n\nConflicts:\n        nova/tests/unit/compute/test_compute.py\n\nNOTE(mriedem): The conflict is due to the unit tests being moved in\nkilo, otherwise this is unchanged.\n\nChange-Id: I36a954c095a9aa35879200784dc18e35edf689e6\n(cherry picked from commit 9369aab04e37b7818d49b00e65857be8b3564e9e)\n(cherry picked from commit 08d1153d3be9f8d59aa0acc03eedd45a1697ed7b)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/dc5ced25c61fc742c513abc03b92e2d8f8042d8c"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/dc5ced25c61fc742c513abc03b92e2d8f8042d8c"}]},"branch":"refs/heads/stable/juno"}},"requirements":[],"submit_records":[],"submit_requirements":[]}