)]}'
{"nova/api/openstack/compute/flavor_manage.py":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"bc9159aa7e3b9e21a5c9d6ac00aa5a0dd111478d","unresolved":false,"context_lines":[{"line_number":62,"context_line":""},{"line_number":63,"context_line":"        vals \u003d body[\u0027flavor\u0027]"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"        name \u003d vals[\u0027name\u0027]"},{"line_number":66,"context_line":"        flavorid \u003d vals.get(\u0027id\u0027)"},{"line_number":67,"context_line":"        memory \u003d vals[\u0027ram\u0027]"},{"line_number":68,"context_line":"        vcpus \u003d vals[\u0027vcpus\u0027]"}],"source_content_type":"text/x-python","patch_set":7,"id":"ba15a1d1_c570fd42","line":65,"updated":"2015-09-23 09:47:32.000000000","message":"are we missing the call to normalize the name here?","commit_id":"4354163c1e149ffdff5f46b9f480d58704f009c8"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"871b05db8c8879c3e4198d974393269e6857189c","unresolved":false,"context_lines":[{"line_number":62,"context_line":""},{"line_number":63,"context_line":"        vals \u003d body[\u0027flavor\u0027]"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"        name \u003d vals[\u0027name\u0027]"},{"line_number":66,"context_line":"        flavorid \u003d vals.get(\u0027id\u0027)"},{"line_number":67,"context_line":"        memory \u003d vals[\u0027ram\u0027]"},{"line_number":68,"context_line":"        vcpus \u003d vals[\u0027vcpus\u0027]"}],"source_content_type":"text/x-python","patch_set":7,"id":"ba15a1d1_c8eb34db","line":65,"in_reply_to":"ba15a1d1_c570fd42","updated":"2015-09-23 09:53:43.000000000","message":"Turns out there is already a strip() further down the stack.\n\nSo lets call this a Nit, I quite like the idea of having normalise called here for consistency.","commit_id":"4354163c1e149ffdff5f46b9f480d58704f009c8"}],"nova/tests/unit/api/openstack/compute/test_serversV21.py":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"fd91ca4c979ec4860acf98f648a45972c5f6edec","unresolved":false,"context_lines":[{"line_number":3553,"context_line":""},{"line_number":3554,"context_line":"    def fake_schema_extension_point(self, version):"},{"line_number":3555,"context_line":"        if version \u003d\u003d \u00272.1\u0027:"},{"line_number":3556,"context_line":"            return self.fake_schema"},{"line_number":3557,"context_line":""},{"line_number":3558,"context_line":"    def get_controller_extensions(self):"},{"line_number":3559,"context_line":"        return []"}],"source_content_type":"text/x-python","patch_set":2,"id":"da20952f_f1a3acaf","line":3556,"updated":"2015-09-10 09:27:52.000000000","message":"Should we not see a test for when this returns a None value, and what that means?","commit_id":"592f35f2e25af7795268e6fb27bf9b67271069b3"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"48469ed1e5afef25a856f9c13c030b10a004ccd1","unresolved":false,"context_lines":[{"line_number":3553,"context_line":""},{"line_number":3554,"context_line":"    def fake_schema_extension_point(self, version):"},{"line_number":3555,"context_line":"        if version \u003d\u003d \u00272.1\u0027:"},{"line_number":3556,"context_line":"            return self.fake_schema"},{"line_number":3557,"context_line":""},{"line_number":3558,"context_line":"    def get_controller_extensions(self):"},{"line_number":3559,"context_line":"        return []"}],"source_content_type":"text/x-python","patch_set":2,"id":"da20952f_6959ec8d","line":3556,"in_reply_to":"da20952f_ec074fc7","updated":"2015-09-10 11:47:42.000000000","message":"but yes, it is confuse for the code reader, let me add comment at here.","commit_id":"592f35f2e25af7795268e6fb27bf9b67271069b3"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"e548e62ad991153c8299046c0d18d51265ff2e2d","unresolved":false,"context_lines":[{"line_number":3553,"context_line":""},{"line_number":3554,"context_line":"    def fake_schema_extension_point(self, version):"},{"line_number":3555,"context_line":"        if version \u003d\u003d \u00272.1\u0027:"},{"line_number":3556,"context_line":"            return self.fake_schema"},{"line_number":3557,"context_line":""},{"line_number":3558,"context_line":"    def get_controller_extensions(self):"},{"line_number":3559,"context_line":"        return []"}],"source_content_type":"text/x-python","patch_set":2,"id":"da20952f_ec074fc7","line":3556,"in_reply_to":"da20952f_f1a3acaf","updated":"2015-09-10 09:50:21.000000000","message":"At this point, only version\u003d\u00272.1\u0027 passed in. If other value passed in, this fake method return None, and the unittest failed.","commit_id":"592f35f2e25af7795268e6fb27bf9b67271069b3"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"bf812e6d7f66f80fc4f32355f2a29eca8b4e2322","unresolved":false,"context_lines":[{"line_number":3554,"context_line":"    def fake_schema_extension_point(self, version):"},{"line_number":3555,"context_line":"        if version \u003d\u003d \u00272.1\u0027:"},{"line_number":3556,"context_line":"            return self.fake_schema"},{"line_number":3557,"context_line":"        # This fake method should reuturn the schema for expected version"},{"line_number":3558,"context_line":"        # Return None will make the tests failed, that means there is something"},{"line_number":3559,"context_line":"        # in the code."},{"line_number":3560,"context_line":"        return None"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba15a1d1_4b3d97db","line":3557,"updated":"2015-09-17 20:13:32.000000000","message":"nit: return","commit_id":"9abf75309e22e25bc623c76910a263d57e76ad97"}]}