)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"5fa01bf7b7e47877de99a783f8015cff95e568a8","unresolved":false,"context_lines":[{"line_number":17,"context_line":"               help\u003d\u0027SSL key file (if separate from cert)\u0027),"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"One would probably expect such options to set SSL settings for other"},{"line_number":20,"context_line":"subsystems of Nova, but instead those are used solely for novncproxy."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"This change:"},{"line_number":23,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1af94dfe_87a4aea6","line":20,"range":{"start_line":20,"start_character":20,"end_line":20,"end_character":69},"updated":"2016-03-16 12:42:06.000000000","message":"As this is an option wich is used in the baseproxy [1], I think this affects also the other proxy services (serial [2], spice [3]) which reuse the baseproxy logic. This would mean a move to the \"vnc\" group would be even more confusing.\n\n[1] https://github.com/openstack/nova/blob/aecefcb9dd5403a0d0a83e9f95d49dcea22e5fc4/nova/cmd/baseproxy.py#L68 \n[2] https://github.com/openstack/nova/blob/aecefcb9dd5403a0d0a83e9f95d49dcea22e5fc4/nova/cmd/serialproxy.py#L37 \n[3] https://github.com/openstack/nova/blob/aecefcb9dd5403a0d0a83e9f95d49dcea22e5fc4/nova/cmd/spicehtml5proxy.py#L47","commit_id":"a6ba81c2f29417af46716ad16c977c582bdf90ef"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"5fa01bf7b7e47877de99a783f8015cff95e568a8","unresolved":false,"context_lines":[{"line_number":30,"context_line":"with existing config files. We might remove the deprecated names in"},{"line_number":31,"context_line":"the future, though."},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"DocImpact"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"Backwards compatibility with existing config files is preserved by"},{"line_number":36,"context_line":"the means of oslo.config, but operators are encouraged to use new"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1af94dfe_0789be26","line":33,"range":{"start_line":33,"start_character":0,"end_line":33,"end_character":9},"updated":"2016-03-16 12:42:06.000000000","message":"This means a manual has to be updated [1] and I think this is not the case in this change. The operators need to be notified via release notes which we do with a \"reno\" file. That reno file is missing in this change.\n\n[1] http://lists.openstack.org/pipermail/openstack-dev/2016-March/088382.html","commit_id":"a6ba81c2f29417af46716ad16c977c582bdf90ef"},{"author":{"_account_id":8688,"name":"Alexis Lee","email":"openstack@lxsli.co.uk","username":"lxsli"},"change_message_id":"b4357ec68da6e1ae3780c05912852fecac8f1708","unresolved":false,"context_lines":[{"line_number":37,"context_line":"option names."},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"Closes-Bug: #1494207"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"Change-Id: I72883d63c2ff7273bb2e3a0a83d3418f112841d8"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7a740942_6c7db7b0","line":40,"updated":"2015-12-04 15:52:16.000000000","message":"nit: Add bp/centralize-config-options and set topic\n\ndon\u0027t put blank lines between tags","commit_id":"a6ba81c2f29417af46716ad16c977c582bdf90ef"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"a99170d31254503de50bb164990634dc873e7a20","unresolved":false,"context_lines":[{"line_number":15,"context_line":"`cert` and `key` options are renamed to make naming consistent with"},{"line_number":16,"context_line":"the remaining SSL option `ssl_only`."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Partial-Bug: #1494207"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Change-Id: I72883d63c2ff7273bb2e3a0a83d3418f112841d8"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"ba0121b8_40df8239","line":18,"range":{"start_line":18,"start_character":0,"end_line":18,"end_character":21},"updated":"2016-04-01 09:35:54.000000000","message":"nit: this should probably go below \u0027Change-Id\u0027","commit_id":"ad699eaa6374857f671f4b95e26d15319e76307a"},{"author":{"_account_id":6849,"name":"Roman Podoliaka","email":"roman.podoliaka@gmail.com","username":"rpodolyaka"},"change_message_id":"ddeb42416cb71e9094e767ba6421e1149c1b0f47","unresolved":false,"context_lines":[{"line_number":15,"context_line":"`cert` and `key` options are renamed to make naming consistent with"},{"line_number":16,"context_line":"the remaining SSL option `ssl_only`."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Partial-Bug: #1494207"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Change-Id: I72883d63c2ff7273bb2e3a0a83d3418f112841d8"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9a061dce_249b9619","line":18,"range":{"start_line":18,"start_character":0,"end_line":18,"end_character":21},"in_reply_to":"ba0121b8_3b3d5fdd","updated":"2016-04-07 13:26:59.000000000","message":"I prefer Change-Id to be the very last line of the commit message :P","commit_id":"ad699eaa6374857f671f4b95e26d15319e76307a"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"35ec86b32002b373ce04bd0b4257af74b0b8b46a","unresolved":false,"context_lines":[{"line_number":15,"context_line":"`cert` and `key` options are renamed to make naming consistent with"},{"line_number":16,"context_line":"the remaining SSL option `ssl_only`."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Partial-Bug: #1494207"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Change-Id: I72883d63c2ff7273bb2e3a0a83d3418f112841d8"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"ba0121b8_3b3d5fdd","line":18,"range":{"start_line":18,"start_character":0,"end_line":18,"end_character":21},"in_reply_to":"ba0121b8_40df8239","updated":"2016-04-01 10:13:06.000000000","message":"hmm, I always put it here, but I think git review puts it below if you don\u0027t leave a space now, for some reason.\n\nIt seems to prefer this order in here: https://wiki.openstack.org/wiki/GitCommitMessages#Summary_of_Git_commit_message_structure","commit_id":"ad699eaa6374857f671f4b95e26d15319e76307a"}],"nova/cmd/novnc.py":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"bd5c1ba1a754d7ee1ab5b20c8e0582d42af96222","unresolved":false,"context_lines":[{"line_number":18,"context_line":"opts \u003d ["},{"line_number":19,"context_line":"    cfg.BoolOpt(\u0027record\u0027,"},{"line_number":20,"context_line":"                default\u003dFalse,"},{"line_number":21,"context_line":"                deprecated_name\u003d\u0027record\u0027,"},{"line_number":22,"context_line":"                deprecated_group\u003d\u0027DEFAULT\u0027,"},{"line_number":23,"context_line":"                help\u003d\u0027Record sessions to FILE.[session_number]\u0027),"},{"line_number":24,"context_line":"    cfg.BoolOpt(\u0027daemon\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba8a016a_3adb4c1d","line":21,"updated":"2015-11-23 15:36:18.000000000","message":"do we need deprecated name here? I think we only need deprecated_group?\n\nI find this really confusing, I think we should drop the extra alias entries here.","commit_id":"88931656e5700895e0d303f1b72b1dd9c6e42a53"},{"author":{"_account_id":6849,"name":"Roman Podoliaka","email":"roman.podoliaka@gmail.com","username":"rpodolyaka"},"change_message_id":"cc9f231d6b39f4947805e93079f956be9f219cf0","unresolved":false,"context_lines":[{"line_number":18,"context_line":"opts \u003d ["},{"line_number":19,"context_line":"    cfg.BoolOpt(\u0027record\u0027,"},{"line_number":20,"context_line":"                default\u003dFalse,"},{"line_number":21,"context_line":"                deprecated_name\u003d\u0027record\u0027,"},{"line_number":22,"context_line":"                deprecated_group\u003d\u0027DEFAULT\u0027,"},{"line_number":23,"context_line":"                help\u003d\u0027Record sessions to FILE.[session_number]\u0027),"},{"line_number":24,"context_line":"    cfg.BoolOpt(\u0027daemon\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a8ffd7b_a440ce36","line":21,"in_reply_to":"ba8a016a_3adb4c1d","updated":"2015-11-30 17:57:01.000000000","message":"Done","commit_id":"88931656e5700895e0d303f1b72b1dd9c6e42a53"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"bd5c1ba1a754d7ee1ab5b20c8e0582d42af96222","unresolved":false,"context_lines":[{"line_number":23,"context_line":"                help\u003d\u0027Record sessions to FILE.[session_number]\u0027),"},{"line_number":24,"context_line":"    cfg.BoolOpt(\u0027daemon\u0027,"},{"line_number":25,"context_line":"                default\u003dFalse,"},{"line_number":26,"context_line":"                deprecated_name\u003d\u0027daemon\u0027,"},{"line_number":27,"context_line":"                deprecated_group\u003d\u0027DEFAULT\u0027,"},{"line_number":28,"context_line":"                help\u003d\u0027Become a daemon (background process)\u0027),"},{"line_number":29,"context_line":"    cfg.BoolOpt(\u0027ssl_only\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba8a016a_3a77cc03","line":26,"updated":"2015-11-23 15:36:18.000000000","message":"and this one.","commit_id":"88931656e5700895e0d303f1b72b1dd9c6e42a53"},{"author":{"_account_id":6849,"name":"Roman Podoliaka","email":"roman.podoliaka@gmail.com","username":"rpodolyaka"},"change_message_id":"cc9f231d6b39f4947805e93079f956be9f219cf0","unresolved":false,"context_lines":[{"line_number":23,"context_line":"                help\u003d\u0027Record sessions to FILE.[session_number]\u0027),"},{"line_number":24,"context_line":"    cfg.BoolOpt(\u0027daemon\u0027,"},{"line_number":25,"context_line":"                default\u003dFalse,"},{"line_number":26,"context_line":"                deprecated_name\u003d\u0027daemon\u0027,"},{"line_number":27,"context_line":"                deprecated_group\u003d\u0027DEFAULT\u0027,"},{"line_number":28,"context_line":"                help\u003d\u0027Become a daemon (background process)\u0027),"},{"line_number":29,"context_line":"    cfg.BoolOpt(\u0027ssl_only\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a8ffd7b_c43dd2bc","line":26,"in_reply_to":"ba8a016a_3a77cc03","updated":"2015-11-30 17:57:01.000000000","message":"Done","commit_id":"88931656e5700895e0d303f1b72b1dd9c6e42a53"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"bd5c1ba1a754d7ee1ab5b20c8e0582d42af96222","unresolved":false,"context_lines":[{"line_number":28,"context_line":"                help\u003d\u0027Become a daemon (background process)\u0027),"},{"line_number":29,"context_line":"    cfg.BoolOpt(\u0027ssl_only\u0027,"},{"line_number":30,"context_line":"                default\u003dFalse,"},{"line_number":31,"context_line":"                deprecated_name\u003d\u0027ssh_only\u0027,"},{"line_number":32,"context_line":"                deprecated_group\u003d\u0027DEFAULT\u0027,"},{"line_number":33,"context_line":"                help\u003d\u0027Disallow non-encrypted connections\u0027),"},{"line_number":34,"context_line":"    cfg.BoolOpt(\u0027source_is_ipv6\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba8a016a_5a72d012","line":31,"updated":"2015-11-23 15:36:18.000000000","message":"and this one.","commit_id":"88931656e5700895e0d303f1b72b1dd9c6e42a53"},{"author":{"_account_id":6849,"name":"Roman Podoliaka","email":"roman.podoliaka@gmail.com","username":"rpodolyaka"},"change_message_id":"cc9f231d6b39f4947805e93079f956be9f219cf0","unresolved":false,"context_lines":[{"line_number":28,"context_line":"                help\u003d\u0027Become a daemon (background process)\u0027),"},{"line_number":29,"context_line":"    cfg.BoolOpt(\u0027ssl_only\u0027,"},{"line_number":30,"context_line":"                default\u003dFalse,"},{"line_number":31,"context_line":"                deprecated_name\u003d\u0027ssh_only\u0027,"},{"line_number":32,"context_line":"                deprecated_group\u003d\u0027DEFAULT\u0027,"},{"line_number":33,"context_line":"                help\u003d\u0027Disallow non-encrypted connections\u0027),"},{"line_number":34,"context_line":"    cfg.BoolOpt(\u0027source_is_ipv6\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a8ffd7b_44780290","line":31,"in_reply_to":"ba8a016a_5a72d012","updated":"2015-11-30 17:57:01.000000000","message":"Done","commit_id":"88931656e5700895e0d303f1b72b1dd9c6e42a53"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"bd5c1ba1a754d7ee1ab5b20c8e0582d42af96222","unresolved":false,"context_lines":[{"line_number":33,"context_line":"                help\u003d\u0027Disallow non-encrypted connections\u0027),"},{"line_number":34,"context_line":"    cfg.BoolOpt(\u0027source_is_ipv6\u0027,"},{"line_number":35,"context_line":"                default\u003dFalse,"},{"line_number":36,"context_line":"                deprecated_name\u003d\u0027source_is_ipv6\u0027,"},{"line_number":37,"context_line":"                deprecated_group\u003d\u0027DEFAULT\u0027,"},{"line_number":38,"context_line":"                help\u003d\u0027Source is ipv6\u0027),"},{"line_number":39,"context_line":"    cfg.StrOpt(\u0027ssl_cert\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba8a016a_fa5f0473","line":36,"updated":"2015-11-23 15:36:18.000000000","message":"and this one.","commit_id":"88931656e5700895e0d303f1b72b1dd9c6e42a53"},{"author":{"_account_id":6849,"name":"Roman Podoliaka","email":"roman.podoliaka@gmail.com","username":"rpodolyaka"},"change_message_id":"cc9f231d6b39f4947805e93079f956be9f219cf0","unresolved":false,"context_lines":[{"line_number":33,"context_line":"                help\u003d\u0027Disallow non-encrypted connections\u0027),"},{"line_number":34,"context_line":"    cfg.BoolOpt(\u0027source_is_ipv6\u0027,"},{"line_number":35,"context_line":"                default\u003dFalse,"},{"line_number":36,"context_line":"                deprecated_name\u003d\u0027source_is_ipv6\u0027,"},{"line_number":37,"context_line":"                deprecated_group\u003d\u0027DEFAULT\u0027,"},{"line_number":38,"context_line":"                help\u003d\u0027Source is ipv6\u0027),"},{"line_number":39,"context_line":"    cfg.StrOpt(\u0027ssl_cert\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a8ffd7b_249a9ec6","line":36,"in_reply_to":"ba8a016a_fa5f0473","updated":"2015-11-30 17:57:01.000000000","message":"Done","commit_id":"88931656e5700895e0d303f1b72b1dd9c6e42a53"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"bd5c1ba1a754d7ee1ab5b20c8e0582d42af96222","unresolved":false,"context_lines":[{"line_number":46,"context_line":"               deprecated_group\u003d\u0027DEFAULT\u0027,"},{"line_number":47,"context_line":"               help\u003d\u0027SSL key file (if separate from cert)\u0027),"},{"line_number":48,"context_line":"    cfg.StrOpt(\u0027web\u0027,"},{"line_number":49,"context_line":"               default\u003d\u0027/usr/share/spice-html5\u0027,"},{"line_number":50,"context_line":"               deprecated_name\u003d\u0027web\u0027,"},{"line_number":51,"context_line":"               deprecated_group\u003d\u0027DEFAULT\u0027,"},{"line_number":52,"context_line":"               help\u003d\u0027Run webserver on same port. Serve files from DIR.\u0027),"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba8a016a_5aa5f044","line":49,"updated":"2015-11-23 15:36:18.000000000","message":"wow, per service defaults.\n\nI feel we should make this default to None, then talk about the per service defaults in the help text.\n\nbut lets make that a follow on change.","commit_id":"88931656e5700895e0d303f1b72b1dd9c6e42a53"},{"author":{"_account_id":6849,"name":"Roman Podoliaka","email":"roman.podoliaka@gmail.com","username":"rpodolyaka"},"change_message_id":"cc9f231d6b39f4947805e93079f956be9f219cf0","unresolved":false,"context_lines":[{"line_number":46,"context_line":"               deprecated_group\u003d\u0027DEFAULT\u0027,"},{"line_number":47,"context_line":"               help\u003d\u0027SSL key file (if separate from cert)\u0027),"},{"line_number":48,"context_line":"    cfg.StrOpt(\u0027web\u0027,"},{"line_number":49,"context_line":"               default\u003d\u0027/usr/share/spice-html5\u0027,"},{"line_number":50,"context_line":"               deprecated_name\u003d\u0027web\u0027,"},{"line_number":51,"context_line":"               deprecated_group\u003d\u0027DEFAULT\u0027,"},{"line_number":52,"context_line":"               help\u003d\u0027Run webserver on same port. Serve files from DIR.\u0027),"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a8ffd7b_4a6249af","line":49,"in_reply_to":"ba8a016a_5aa5f044","updated":"2015-11-30 17:57:01.000000000","message":"ok, agreed","commit_id":"88931656e5700895e0d303f1b72b1dd9c6e42a53"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"bd5c1ba1a754d7ee1ab5b20c8e0582d42af96222","unresolved":false,"context_lines":[{"line_number":47,"context_line":"               help\u003d\u0027SSL key file (if separate from cert)\u0027),"},{"line_number":48,"context_line":"    cfg.StrOpt(\u0027web\u0027,"},{"line_number":49,"context_line":"               default\u003d\u0027/usr/share/spice-html5\u0027,"},{"line_number":50,"context_line":"               deprecated_name\u003d\u0027web\u0027,"},{"line_number":51,"context_line":"               deprecated_group\u003d\u0027DEFAULT\u0027,"},{"line_number":52,"context_line":"               help\u003d\u0027Run webserver on same port. Serve files from DIR.\u0027),"},{"line_number":53,"context_line":"    ]"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba8a016a_ba597c90","line":50,"updated":"2015-11-23 15:36:18.000000000","message":"and this one.","commit_id":"88931656e5700895e0d303f1b72b1dd9c6e42a53"},{"author":{"_account_id":6849,"name":"Roman Podoliaka","email":"roman.podoliaka@gmail.com","username":"rpodolyaka"},"change_message_id":"cc9f231d6b39f4947805e93079f956be9f219cf0","unresolved":false,"context_lines":[{"line_number":47,"context_line":"               help\u003d\u0027SSL key file (if separate from cert)\u0027),"},{"line_number":48,"context_line":"    cfg.StrOpt(\u0027web\u0027,"},{"line_number":49,"context_line":"               default\u003d\u0027/usr/share/spice-html5\u0027,"},{"line_number":50,"context_line":"               deprecated_name\u003d\u0027web\u0027,"},{"line_number":51,"context_line":"               deprecated_group\u003d\u0027DEFAULT\u0027,"},{"line_number":52,"context_line":"               help\u003d\u0027Run webserver on same port. Serve files from DIR.\u0027),"},{"line_number":53,"context_line":"    ]"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a8ffd7b_ea569dcd","line":50,"in_reply_to":"ba8a016a_ba597c90","updated":"2015-11-30 17:57:01.000000000","message":"Done","commit_id":"88931656e5700895e0d303f1b72b1dd9c6e42a53"}],"nova/conf/console.py":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"35ec86b32002b373ce04bd0b4257af74b0b8b46a","unresolved":false,"context_lines":[{"line_number":47,"context_line":"    cfg.BoolOpt(\u0027source_is_ipv6\u0027,"},{"line_number":48,"context_line":"                default\u003dFalse,"},{"line_number":49,"context_line":"                help\u003d\u0027Source is ipv6\u0027),"},{"line_number":50,"context_line":"    cfg.StrOpt(\u0027ssl_cert\u0027,"},{"line_number":51,"context_line":"               default\u003d\u0027self.pem\u0027,"},{"line_number":52,"context_line":"               deprecated_name\u003d\u0027cert\u0027,"},{"line_number":53,"context_line":"               help\u003d\u0027SSL certificate file\u0027),"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba0121b8_661f3e5b","line":50,"updated":"2016-04-01 10:13:06.000000000","message":"I wish these renames were in a separate patch.","commit_id":"ad699eaa6374857f671f4b95e26d15319e76307a"},{"author":{"_account_id":6849,"name":"Roman Podoliaka","email":"roman.podoliaka@gmail.com","username":"rpodolyaka"},"change_message_id":"ddeb42416cb71e9094e767ba6421e1149c1b0f47","unresolved":false,"context_lines":[{"line_number":47,"context_line":"    cfg.BoolOpt(\u0027source_is_ipv6\u0027,"},{"line_number":48,"context_line":"                default\u003dFalse,"},{"line_number":49,"context_line":"                help\u003d\u0027Source is ipv6\u0027),"},{"line_number":50,"context_line":"    cfg.StrOpt(\u0027ssl_cert\u0027,"},{"line_number":51,"context_line":"               default\u003d\u0027self.pem\u0027,"},{"line_number":52,"context_line":"               deprecated_name\u003d\u0027cert\u0027,"},{"line_number":53,"context_line":"               help\u003d\u0027SSL certificate file\u0027),"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a061dce_0493f2fa","line":50,"in_reply_to":"ba0121b8_661f3e5b","updated":"2016-04-07 13:26:59.000000000","message":"Done","commit_id":"ad699eaa6374857f671f4b95e26d15319e76307a"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"a99170d31254503de50bb164990634dc873e7a20","unresolved":false,"context_lines":[{"line_number":54,"context_line":"    cfg.StrOpt(\u0027ssl_key\u0027,"},{"line_number":55,"context_line":"               deprecated_name\u003d\u0027key\u0027,"},{"line_number":56,"context_line":"               help\u003d\u0027SSL key file (if separate from cert)\u0027),"},{"line_number":57,"context_line":"    cfg.StrOpt(\u0027web\u0027,"},{"line_number":58,"context_line":"               default\u003d\u0027/usr/share/spice-html5\u0027,"},{"line_number":59,"context_line":"               help\u003d\u0027Run webserver on same port. Serve files from DIR.\u0027),"},{"line_number":60,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba0121b8_8094fa8a","line":57,"range":{"start_line":57,"start_character":15,"end_line":57,"end_character":20},"updated":"2016-04-01 09:35:54.000000000","message":"if you wanted to, a more meaningful name would be really helpful here","commit_id":"ad699eaa6374857f671f4b95e26d15319e76307a"},{"author":{"_account_id":6849,"name":"Roman Podoliaka","email":"roman.podoliaka@gmail.com","username":"rpodolyaka"},"change_message_id":"ddeb42416cb71e9094e767ba6421e1149c1b0f47","unresolved":false,"context_lines":[{"line_number":54,"context_line":"    cfg.StrOpt(\u0027ssl_key\u0027,"},{"line_number":55,"context_line":"               deprecated_name\u003d\u0027key\u0027,"},{"line_number":56,"context_line":"               help\u003d\u0027SSL key file (if separate from cert)\u0027),"},{"line_number":57,"context_line":"    cfg.StrOpt(\u0027web\u0027,"},{"line_number":58,"context_line":"               default\u003d\u0027/usr/share/spice-html5\u0027,"},{"line_number":59,"context_line":"               help\u003d\u0027Run webserver on same port. Serve files from DIR.\u0027),"},{"line_number":60,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a061dce_24c276e9","line":57,"range":{"start_line":57,"start_character":15,"end_line":57,"end_character":20},"in_reply_to":"ba0121b8_0605a20f","updated":"2016-04-07 13:26:59.000000000","message":"Agreed.","commit_id":"ad699eaa6374857f671f4b95e26d15319e76307a"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"35ec86b32002b373ce04bd0b4257af74b0b8b46a","unresolved":false,"context_lines":[{"line_number":54,"context_line":"    cfg.StrOpt(\u0027ssl_key\u0027,"},{"line_number":55,"context_line":"               deprecated_name\u003d\u0027key\u0027,"},{"line_number":56,"context_line":"               help\u003d\u0027SSL key file (if separate from cert)\u0027),"},{"line_number":57,"context_line":"    cfg.StrOpt(\u0027web\u0027,"},{"line_number":58,"context_line":"               default\u003d\u0027/usr/share/spice-html5\u0027,"},{"line_number":59,"context_line":"               help\u003d\u0027Run webserver on same port. Serve files from DIR.\u0027),"},{"line_number":60,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba0121b8_0605a20f","line":57,"range":{"start_line":57,"start_character":15,"end_line":57,"end_character":20},"in_reply_to":"ba0121b8_8094fa8a","updated":"2016-04-01 10:13:06.000000000","message":"+1, but lets do that in a separate change.","commit_id":"ad699eaa6374857f671f4b95e26d15319e76307a"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"a99170d31254503de50bb164990634dc873e7a20","unresolved":false,"context_lines":[{"line_number":54,"context_line":"    cfg.StrOpt(\u0027ssl_key\u0027,"},{"line_number":55,"context_line":"               deprecated_name\u003d\u0027key\u0027,"},{"line_number":56,"context_line":"               help\u003d\u0027SSL key file (if separate from cert)\u0027),"},{"line_number":57,"context_line":"    cfg.StrOpt(\u0027web\u0027,"},{"line_number":58,"context_line":"               default\u003d\u0027/usr/share/spice-html5\u0027,"},{"line_number":59,"context_line":"               help\u003d\u0027Run webserver on same port. Serve files from DIR.\u0027),"},{"line_number":60,"context_line":"]"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"ba0121b8_20924e4c","line":59,"range":{"start_line":57,"start_character":0,"end_line":59,"end_character":73},"updated":"2016-04-01 09:35:54.000000000","message":"it would be very helpful to include John\u0027s note about per-service defaults here as a \u0027TODO\u0027 or \u0027FIXME\u0027","commit_id":"ad699eaa6374857f671f4b95e26d15319e76307a"}],"releasenotes/notes/baseproxy_ssl_prefix-48e9831111a8bf94.yaml":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"a99170d31254503de50bb164990634dc873e7a20","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - options ``cert`` and ``key`` used in console proxies have been"},{"line_number":4,"context_line":"    renamed to ``ssl_cert`` and ``ssl_key`` accordingly to make"},{"line_number":5,"context_line":"    naming consistent with other SSL related options (specifically,"},{"line_number":6,"context_line":"    ``ssl_only``)"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"ba0121b8_40114203","line":3,"range":{"start_line":3,"start_character":25,"end_line":3,"end_character":56},"updated":"2016-04-01 09:35:54.000000000","message":"Needs commas:\n\n    ...``key``, used in console proxies, have...\n\nDon\u0027t know if grammar matters in release notes, but they\u0027ll form documents so it wouldn\u0027t be any harm","commit_id":"ad699eaa6374857f671f4b95e26d15319e76307a"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"35ec86b32002b373ce04bd0b4257af74b0b8b46a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - options ``cert`` and ``key`` used in console proxies have been"},{"line_number":4,"context_line":"    renamed to ``ssl_cert`` and ``ssl_key`` accordingly to make"},{"line_number":5,"context_line":"    naming consistent with other SSL related options (specifically,"},{"line_number":6,"context_line":"    ``ssl_only``)"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"ba0121b8_a644b649","line":3,"range":{"start_line":3,"start_character":25,"end_line":3,"end_character":56},"in_reply_to":"ba0121b8_40114203","updated":"2016-04-01 10:13:06.000000000","message":"It matters, but I can still understand the meaning here, but I am a bit \"grammar blind\" really.","commit_id":"ad699eaa6374857f671f4b95e26d15319e76307a"},{"author":{"_account_id":6849,"name":"Roman Podoliaka","email":"roman.podoliaka@gmail.com","username":"rpodolyaka"},"change_message_id":"ddeb42416cb71e9094e767ba6421e1149c1b0f47","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - options ``cert`` and ``key`` used in console proxies have been"},{"line_number":4,"context_line":"    renamed to ``ssl_cert`` and ``ssl_key`` accordingly to make"},{"line_number":5,"context_line":"    naming consistent with other SSL related options (specifically,"},{"line_number":6,"context_line":"    ``ssl_only``)"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9a061dce_e4a4fe4b","line":3,"range":{"start_line":3,"start_character":25,"end_line":3,"end_character":56},"in_reply_to":"ba0121b8_a644b649","updated":"2016-04-07 13:26:59.000000000","message":"Done","commit_id":"ad699eaa6374857f671f4b95e26d15319e76307a"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"a99170d31254503de50bb164990634dc873e7a20","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - options ``cert`` and ``key`` used in console proxies have been"},{"line_number":4,"context_line":"    renamed to ``ssl_cert`` and ``ssl_key`` accordingly to make"},{"line_number":5,"context_line":"    naming consistent with other SSL related options (specifically,"},{"line_number":6,"context_line":"    ``ssl_only``)"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"ba0121b8_20d36e61","line":4,"range":{"start_line":4,"start_character":44,"end_line":4,"end_character":55},"updated":"2016-04-01 09:35:54.000000000","message":"respectively","commit_id":"ad699eaa6374857f671f4b95e26d15319e76307a"},{"author":{"_account_id":6849,"name":"Roman Podoliaka","email":"roman.podoliaka@gmail.com","username":"rpodolyaka"},"change_message_id":"ddeb42416cb71e9094e767ba6421e1149c1b0f47","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - options ``cert`` and ``key`` used in console proxies have been"},{"line_number":4,"context_line":"    renamed to ``ssl_cert`` and ``ssl_key`` accordingly to make"},{"line_number":5,"context_line":"    naming consistent with other SSL related options (specifically,"},{"line_number":6,"context_line":"    ``ssl_only``)"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9a061dce_2469d6f9","line":4,"range":{"start_line":4,"start_character":44,"end_line":4,"end_character":55},"in_reply_to":"ba0121b8_20d36e61","updated":"2016-04-07 13:26:59.000000000","message":"Done","commit_id":"ad699eaa6374857f671f4b95e26d15319e76307a"}]}