)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"0f70a45beef85688202b42c88abad84999dfa6ad","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"create new cidr type for data storage"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"it turns out that the 149 migration was overly agressive in it\u0027s"},{"line_number":10,"context_line":"IPAddress conversion, as we actually have a few columns that are"},{"line_number":11,"context_line":"really CIDR values. This means that 39 chars isn\u0027t enough space to"},{"line_number":12,"context_line":"store even a normalized IPv6 cidr in the worst case (you need 4"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAAM3%2F%2BzYA%3D","line":9,"updated":"2013-02-18 22:37:59.000000000","message":"attonit: s/it\u0027s/its/; \"it\u0027s\" is a contraction for \"it is\", while \"its\" is the possessive that you mean to use.","commit_id":"5244a8b516277bd50872661608f373d2ec70532c"}],"nova/db/sqlalchemy/types.py":[{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"0f70a45beef85688202b42c88abad84999dfa6ad","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"class CIDR(types.TypeDecorator):"},{"line_number":42,"context_line":"    \"\"\"An SQLAlchemy type representing an IP-address.\"\"\""},{"line_number":43,"context_line":"    impl \u003d types.String(43).with_variant(postgresql.INET(), \u0027postgresql\u0027)"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    def process_bind_param(self, value, dialect):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAM3%2F%2BzXk%3D","line":42,"updated":"2013-02-18 22:37:59.000000000","message":"You should probably tune this docstring.","commit_id":"5244a8b516277bd50872661608f373d2ec70532c"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"0f70a45beef85688202b42c88abad84999dfa6ad","unresolved":false,"context_lines":[{"line_number":40,"context_line":""},{"line_number":41,"context_line":"class CIDR(types.TypeDecorator):"},{"line_number":42,"context_line":"    \"\"\"An SQLAlchemy type representing an IP-address.\"\"\""},{"line_number":43,"context_line":"    impl \u003d types.String(43).with_variant(postgresql.INET(), \u0027postgresql\u0027)"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    def process_bind_param(self, value, dialect):"},{"line_number":46,"context_line":"        \"\"\"Process/Formats the value before insert it into the db.\"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAM3%2F%2BzXQ%3D","line":43,"updated":"2013-02-18 22:37:59.000000000","message":"Should we consider using the postgresql CIDR type instead of INET?  (For other reviewers: INET does support a netmask, so it does cover the requirements for storing a CIDR.)","commit_id":"5244a8b516277bd50872661608f373d2ec70532c"},{"author":{"_account_id":2903,"name":"Morgan Fainberg","email":"morgan.fainberg@gmail.com","username":"mdrnstm"},"change_message_id":"d2d58f7b4353731a8b600f0228e7521fdfbe6677","unresolved":false,"context_lines":[{"line_number":40,"context_line":""},{"line_number":41,"context_line":"class CIDR(types.TypeDecorator):"},{"line_number":42,"context_line":"    \"\"\"An SQLAlchemy type representing an IP-address.\"\"\""},{"line_number":43,"context_line":"    impl \u003d types.String(43).with_variant(postgresql.INET(), \u0027postgresql\u0027)"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    def process_bind_param(self, value, dialect):"},{"line_number":46,"context_line":"        \"\"\"Process/Formats the value before insert it into the db.\"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAM3%2F%2BzWY%3D","line":43,"in_reply_to":"AAAAM3%2F%2BzXQ%3D","updated":"2013-02-18 22:45:13.000000000","message":"Based on Kevin\u0027s comment, provided CIDR type doesn\u0027t have issue (I don\u0027t expect it will) it might be a better choice since we\u0027re now splitting the two expected data types from each-other in MySQL based upon differing column sizes.\n\nI don\u0027t see this as a major issue though and both are a valid approach","commit_id":"5244a8b516277bd50872661608f373d2ec70532c"}]}