)]}'
{"nova/db/sqlalchemy/api.py":[{"author":{"_account_id":494,"name":"termie","email":"termie@openstack.org","username":"termie"},"change_message_id":"893237c3f8da35ca9cf0a1db8ca5c132c8b4466f","unresolved":false,"context_lines":[{"line_number":1532,"context_line":"    \"\"\"Return the actions associated to the given instance id\"\"\""},{"line_number":1533,"context_line":"    session \u003d get_session()"},{"line_number":1534,"context_line":"    return session.query(models.InstanceActions)\\"},{"line_number":1535,"context_line":"        .filter_by(instance_uuid\u003dinstance_uuid).all()"},{"line_number":1536,"context_line":""},{"line_number":1537,"context_line":""},{"line_number":1538,"context_line":"@require_context"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAC3%2F%2F9gg%3D","line":1535,"updated":"2011-12-12 23:11:35.000000000","message":"traditionally it seems that people have been doing this by leaving the period a the end of the first line and indenting the second line to match, in this case, \u0027query\u0027 and doing the same for the .all() (see directly below)","commit_id":"d3fb44ec37488ea810319565c721c11840c6d163"}],"nova/db/sqlalchemy/models.py":[{"author":{"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"},"change_message_id":"a5fa0f776ced3c1ee04f9a9ce5d3c55a33481727","unresolved":false,"context_lines":[{"line_number":308,"context_line":"    \"\"\"Represents a guest VM\u0027s actions and results\"\"\""},{"line_number":309,"context_line":"    __tablename__ \u003d \"instance_actions\""},{"line_number":310,"context_line":"    id \u003d Column(Integer, primary_key\u003dTrue)"},{"line_number":311,"context_line":"    instance_uuid \u003d Column(String(36), ForeignKey(\u0027instances.uuid\u0027))"},{"line_number":312,"context_line":"    action \u003d Column(String(255))"},{"line_number":313,"context_line":"    error \u003d Column(Text)"},{"line_number":314,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAC3%2F%2F9uE%3D","line":311,"updated":"2011-12-12 16:11:41.000000000","message":"You need to code this change into the migration as well (I think).","commit_id":"2978c7d8b8d8d5ac2eb2a6e9f2c16ada4660e1fd"}],"nova/tests/vmwareapi/db_fakes.py":[{"author":{"_account_id":494,"name":"termie","email":"termie@openstack.org","username":"termie"},"change_message_id":"893237c3f8da35ca9cf0a1db8ca5c132c8b4466f","unresolved":false,"context_lines":[{"line_number":62,"context_line":"        base_options \u003d {\r"},{"line_number":63,"context_line":"            \u0027name\u0027: values[\u0027name\u0027],\r"},{"line_number":64,"context_line":"            \u0027id\u0027: values[\u0027id\u0027],\r"},{"line_number":65,"context_line":"            \u0027uuid\u0027: utils.gen_uuid(),\r"},{"line_number":66,"context_line":"            \u0027reservation_id\u0027: utils.generate_uid(\u0027r\u0027),\r"},{"line_number":67,"context_line":"            \u0027image_ref\u0027: values[\u0027image_ref\u0027],\r"},{"line_number":68,"context_line":"            \u0027kernel_id\u0027: values[\u0027kernel_id\u0027],\r"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAC3%2F%2F9gY%3D","line":65,"updated":"2011-12-12 23:11:35.000000000","message":"seems like we should allow passing in uuid in values? most of the fun of uuids is that anybody can generate them","commit_id":"d3fb44ec37488ea810319565c721c11840c6d163"},{"author":{"_account_id":998,"name":"Naveed Massjouni","email":"naveedm9@gmail.com","username":"ironcamel"},"change_message_id":"6bd4508d22709014bb80edb874d9bb20e95b8f92","unresolved":false,"context_lines":[{"line_number":62,"context_line":"        base_options \u003d {\r"},{"line_number":63,"context_line":"            \u0027name\u0027: values[\u0027name\u0027],\r"},{"line_number":64,"context_line":"            \u0027id\u0027: values[\u0027id\u0027],\r"},{"line_number":65,"context_line":"            \u0027uuid\u0027: utils.gen_uuid(),\r"},{"line_number":66,"context_line":"            \u0027reservation_id\u0027: utils.generate_uid(\u0027r\u0027),\r"},{"line_number":67,"context_line":"            \u0027image_ref\u0027: values[\u0027image_ref\u0027],\r"},{"line_number":68,"context_line":"            \u0027kernel_id\u0027: values[\u0027kernel_id\u0027],\r"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAC3%2F%2F9bY%3D","line":65,"in_reply_to":"AAAAC3%2F%2F9gY%3D","updated":"2011-12-13 20:06:54.000000000","message":"I\u0027m not sure what you mean. I had to add this so the tests would pass. This is just a test fake.","commit_id":"d3fb44ec37488ea810319565c721c11840c6d163"}],"nova/virt/vmwareapi_conn.py":[{"author":{"_account_id":100,"name":"Johannes Erdfelt","email":"johannes@erdfelt.com","username":"johannes.erdfelt"},"change_message_id":"5981205afdf7038d0e92becb749ad0b4c4cb61b7","unresolved":false,"context_lines":[{"line_number":371,"context_line":"                            task_ref, \"Task\", \"info\")"},{"line_number":372,"context_line":"            task_name \u003d task_info.name"},{"line_number":373,"context_line":"            action \u003d dict("},{"line_number":374,"context_line":"                instance_uuid\u003dint(instance_uuid),"},{"line_number":375,"context_line":"                action\u003dtask_name[0:255],"},{"line_number":376,"context_line":"                error\u003dNone)"},{"line_number":377,"context_line":"            if task_info.state in [\u0027queued\u0027, \u0027running\u0027]:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAC3%2F%2F954%3D","line":374,"updated":"2011-12-09 23:55:36.000000000","message":"This probably shouldn\u0027t try converting a UUID into an int.","commit_id":"7db05d5eea01750a027a4926295d056048a08a57"}],"nova/virt/xenapi/vm_utils.py":[{"author":{"_account_id":494,"name":"termie","email":"termie@openstack.org","username":"termie"},"change_message_id":"893237c3f8da35ca9cf0a1db8ca5c132c8b4466f","unresolved":false,"context_lines":[{"line_number":909,"context_line":"        raise exception.CouldNotFetchMetrics()"},{"line_number":910,"context_line":""},{"line_number":911,"context_line":"    @classmethod"},{"line_number":912,"context_line":"    def _scan_sr(cls, session, instance\u003dNone, sr_ref\u003dNone):"},{"line_number":913,"context_line":"        \"\"\"Scans the SR specified by sr_ref\"\"\""},{"line_number":914,"context_line":"        if sr_ref:"},{"line_number":915,"context_line":"            LOG.debug(_(\"Re-scanning SR %s\"), sr_ref)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAC3%2F%2F9gU%3D","line":912,"updated":"2011-12-12 23:11:35.000000000","message":"it feels a little odd to me to have a protected classmethod, how about to you?","commit_id":"d3fb44ec37488ea810319565c721c11840c6d163"},{"author":{"_account_id":998,"name":"Naveed Massjouni","email":"naveedm9@gmail.com","username":"ironcamel"},"change_message_id":"8a1ff70a2f4baafab80040ed964053c6a318ca9d","unresolved":false,"context_lines":[{"line_number":909,"context_line":"        raise exception.CouldNotFetchMetrics()"},{"line_number":910,"context_line":""},{"line_number":911,"context_line":"    @classmethod"},{"line_number":912,"context_line":"    def _scan_sr(cls, session, instance\u003dNone, sr_ref\u003dNone):"},{"line_number":913,"context_line":"        \"\"\"Scans the SR specified by sr_ref\"\"\""},{"line_number":914,"context_line":"        if sr_ref:"},{"line_number":915,"context_line":"            LOG.debug(_(\"Re-scanning SR %s\"), sr_ref)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAC3%2F%2F9fU%3D","line":912,"in_reply_to":"AAAAC3%2F%2F9gU%3D","updated":"2011-12-12 23:42:41.000000000","message":"Yes, me too. I actually fixed this in patch set 5, before having a chance to read your comments. I will address the rest of your comments in patch set 6. Thanks.","commit_id":"d3fb44ec37488ea810319565c721c11840c6d163"},{"author":{"_account_id":494,"name":"termie","email":"termie@openstack.org","username":"termie"},"change_message_id":"893237c3f8da35ca9cf0a1db8ca5c132c8b4466f","unresolved":false,"context_lines":[{"line_number":914,"context_line":"        if sr_ref:"},{"line_number":915,"context_line":"            LOG.debug(_(\"Re-scanning SR %s\"), sr_ref)"},{"line_number":916,"context_line":"            task \u003d session.call_xenapi(\u0027Async.SR.scan\u0027, sr_ref)"},{"line_number":917,"context_line":"            instance_uuid \u003d None"},{"line_number":918,"context_line":"            if instance:"},{"line_number":919,"context_line":"                instance_uuid \u003d instance[\u0027uuid\u0027]"},{"line_number":920,"context_line":"            session.wait_for_task(task, instance_uuid)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAC3%2F%2F9gQ%3D","line":917,"updated":"2011-12-12 23:11:35.000000000","message":"can be re-written as:\n\ninstance_uuid \u003d instance and instance[\u0027uuid\u0027] or None\n\nor using new python syntax:\n\ninstance_uuid \u003d instance[\u0027uuid\u0027] if instance else None","commit_id":"d3fb44ec37488ea810319565c721c11840c6d163"},{"author":{"_account_id":494,"name":"termie","email":"termie@openstack.org","username":"termie"},"change_message_id":"893237c3f8da35ca9cf0a1db8ca5c132c8b4466f","unresolved":false,"context_lines":[{"line_number":1132,"context_line":""},{"line_number":1133,"context_line":""},{"line_number":1134,"context_line":"def _wait_for_vhd_coalesce(session, instance, sr_ref, vdi_ref,"},{"line_number":1135,"context_line":"                          original_parent_uuid):"},{"line_number":1136,"context_line":"    \"\"\" Spin until the parent VHD is coalesced into its parent VHD"},{"line_number":1137,"context_line":""},{"line_number":1138,"context_line":"    Before coalesce:"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAC3%2F%2F9gE%3D","line":1135,"updated":"2011-12-12 23:11:35.000000000","message":"indent one space","commit_id":"d3fb44ec37488ea810319565c721c11840c6d163"}],"nova/virt/xenapi/vmops.py":[{"author":{"_account_id":494,"name":"termie","email":"termie@openstack.org","username":"termie"},"change_message_id":"893237c3f8da35ca9cf0a1db8ca5c132c8b4466f","unresolved":false,"context_lines":[{"line_number":615,"context_line":"        label \u003d \"%s-snapshot\" % instance.name"},{"line_number":616,"context_line":"        try:"},{"line_number":617,"context_line":"            template_vm_ref, template_vdi_uuids \u003d VMHelper.create_snapshot("},{"line_number":618,"context_line":"                self._session, instance, vm_ref, label)"},{"line_number":619,"context_line":"            return template_vm_ref, template_vdi_uuids"},{"line_number":620,"context_line":"        except self.XenAPI.Failure, exc:"},{"line_number":621,"context_line":"            logging.error(_(\"Unable to Snapshot %(vm_ref)s: %(exc)s\")"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAC3%2F%2F9gA%3D","line":618,"updated":"2011-12-12 23:11:35.000000000","message":"when continuing lines like this, the style is to double-indent (so it doens\u0027t look like a control-flow statement)","commit_id":"d3fb44ec37488ea810319565c721c11840c6d163"}],"nova/virt/xenapi_conn.py":[{"author":{"_account_id":100,"name":"Johannes Erdfelt","email":"johannes@erdfelt.com","username":"johannes.erdfelt"},"change_message_id":"5981205afdf7038d0e92becb749ad0b4c4cb61b7","unresolved":false,"context_lines":[{"line_number":528,"context_line":"                log_instance_actions \u003d FLAGS.xenapi_log_instance_actions and \\"},{"line_number":529,"context_line":"                    uuid"},{"line_number":530,"context_line":"                if log_instance_actions:"},{"line_number":531,"context_line":"                    action[\"instance_uuid\"] \u003d int(uuid)"},{"line_number":532,"context_line":""},{"line_number":533,"context_line":"                if status \u003d\u003d \"pending\":"},{"line_number":534,"context_line":"                    return"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAC3%2F%2F950%3D","line":531,"updated":"2011-12-09 23:55:36.000000000","message":"Same thing here, this probably shouldn\u0027t convert a uuid into an int","commit_id":"7db05d5eea01750a027a4926295d056048a08a57"},{"author":{"_account_id":494,"name":"termie","email":"termie@openstack.org","username":"termie"},"change_message_id":"893237c3f8da35ca9cf0a1db8ca5c132c8b4466f","unresolved":false,"context_lines":[{"line_number":525,"context_line":""},{"line_number":526,"context_line":"                # Ensure action is never \u003e 255"},{"line_number":527,"context_line":"                action \u003d dict(action\u003dname[:255], error\u003dNone)"},{"line_number":528,"context_line":"                log_instance_actions \u003d FLAGS.xenapi_log_instance_actions and \\"},{"line_number":529,"context_line":"                    uuid"},{"line_number":530,"context_line":"                if log_instance_actions:"},{"line_number":531,"context_line":"                    action[\"instance_uuid\"] \u003d uuid"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAC3%2F%2F9f4%3D","line":528,"updated":"2011-12-12 23:11:35.000000000","message":"use parens instead of \\\n(FLAGS.foo and\n uuid)","commit_id":"d3fb44ec37488ea810319565c721c11840c6d163"}]}