)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"0185eecaba051d2c23657829ff8f7766ba81dd1b","unresolved":false,"context_lines":[{"line_number":10,"context_line":"iSCSI volume"},{"line_number":11,"context_line":"Above description is incorrect and misleading. Actually, this option"},{"line_number":12,"context_line":"is applicable for both FC/iSCSI volumes"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: Ifdc6a2935702311eb8af363c742b5ab44c7a0d0f"},{"line_number":15,"context_line":"Closes-bug: #1495876"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ba15a1d1_d13dd4c4","line":13,"updated":"2015-09-17 20:53:11.000000000","message":"need DocImpact flag because a configuration option change","commit_id":"8313f1e0ab1b953b364128adc483ea9e7cdb62be"}],"nova/virt/libvirt/volume/iscsi.py":[{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"0185eecaba051d2c23657829ff8f7766ba81dd1b","unresolved":false,"context_lines":[{"line_number":26,"context_line":"               help\u003d\u0027Number of times to rescan iSCSI target to find volume\u0027),"},{"line_number":27,"context_line":"    cfg.BoolOpt(\u0027iscsi_use_multipath\u0027,"},{"line_number":28,"context_line":"                default\u003dFalse,"},{"line_number":29,"context_line":"                help\u003d\u0027Use multipath connection of the iSCSI or FC volume\u0027),"},{"line_number":30,"context_line":"    cfg.StrOpt(\u0027iscsi_iface\u0027,"},{"line_number":31,"context_line":"               deprecated_name\u003d\u0027iscsi_transport\u0027,"},{"line_number":32,"context_line":"               help\u003d\u0027The iSCSI transport iface to use to connect to target in \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba15a1d1_312210a4","line":29,"updated":"2015-09-17 20:53:11.000000000","message":"the name is iscsi_use_multipath I don\u0027t think add FC is proper\nmaybe use_multipath? but this is iscsi.py...","commit_id":"8313f1e0ab1b953b364128adc483ea9e7cdb62be"},{"author":{"_account_id":16986,"name":"Shuquan Huang","email":"shuquan.huang@live.com","username":"shuquan"},"change_message_id":"0c8d79eb5cf96298d8136e09047c7c1808dea515","unresolved":false,"context_lines":[{"line_number":26,"context_line":"               help\u003d\u0027Number of times to rescan iSCSI target to find volume\u0027),"},{"line_number":27,"context_line":"    cfg.BoolOpt(\u0027iscsi_use_multipath\u0027,"},{"line_number":28,"context_line":"                default\u003dFalse,"},{"line_number":29,"context_line":"                help\u003d\u0027Use multipath connection of the iSCSI or FC volume\u0027),"},{"line_number":30,"context_line":"    cfg.StrOpt(\u0027iscsi_iface\u0027,"},{"line_number":31,"context_line":"               deprecated_name\u003d\u0027iscsi_transport\u0027,"},{"line_number":32,"context_line":"               help\u003d\u0027The iSCSI transport iface to use to connect to target in \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba15a1d1_33f20d07","line":29,"in_reply_to":"ba15a1d1_312210a4","updated":"2015-09-18 03:14:46.000000000","message":"A better solution would be putting the config in another place??","commit_id":"8313f1e0ab1b953b364128adc483ea9e7cdb62be"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"09a718f61bc4a09bea00112b4992ca7b620163ac","unresolved":false,"context_lines":[{"line_number":26,"context_line":"               help\u003d\u0027Number of times to rescan iSCSI target to find volume\u0027),"},{"line_number":27,"context_line":"    cfg.BoolOpt(\u0027iscsi_use_multipath\u0027,"},{"line_number":28,"context_line":"                default\u003dFalse,"},{"line_number":29,"context_line":"                help\u003d\u0027Use multipath connection of the iSCSI or FC volume\u0027),"},{"line_number":30,"context_line":"    cfg.StrOpt(\u0027iscsi_iface\u0027,"},{"line_number":31,"context_line":"               deprecated_name\u003d\u0027iscsi_transport\u0027,"},{"line_number":32,"context_line":"               help\u003d\u0027The iSCSI transport iface to use to connect to target in \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba15a1d1_5b9b1318","line":29,"in_reply_to":"ba15a1d1_33f20d07","updated":"2015-09-18 09:00:31.000000000","message":"FC is a protocol which is totally independent to iSCSI\nI don\u0027t think use \u0027iscsi_use_multipath\u0027 to represent iSCSI or FC volume multipath make sense...\n\nput something related to FC in iscsi.py also weird","commit_id":"8313f1e0ab1b953b364128adc483ea9e7cdb62be"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"f0ba2127f09d4c01c139fc6be796d1e9c88d09ff","unresolved":false,"context_lines":[{"line_number":26,"context_line":"               help\u003d\u0027Number of times to rescan iSCSI target to find volume\u0027),"},{"line_number":27,"context_line":"    cfg.BoolOpt(\u0027iscsi_use_multipath\u0027,"},{"line_number":28,"context_line":"                default\u003dFalse,"},{"line_number":29,"context_line":"                help\u003d\u0027Use multipath connection of the iSCSI or FC volume\u0027),"},{"line_number":30,"context_line":"    cfg.StrOpt(\u0027iscsi_iface\u0027,"},{"line_number":31,"context_line":"               deprecated_name\u003d\u0027iscsi_transport\u0027,"},{"line_number":32,"context_line":"               help\u003d\u0027The iSCSI transport iface to use to connect to target in \u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a7e1126_e281b990","line":29,"updated":"2015-12-17 13:04:54.000000000","message":"It would be better to deprecate this to use_multipath if it\u0027s actually being used by FC code.","commit_id":"b3c69ef6d7028962bbde83b7597886d011dbd5af"}]}
