)]}'
{"id":"openstack%2Fnova~22461","triplet_id":"openstack%2Fnova~master~Ibae2f1238feac9a10b8dc2b74886ea59edac0bcc","project":"openstack/nova","branch":"master","topic":"bug/1130841","hashtags":[],"change_id":"Ibae2f1238feac9a10b8dc2b74886ea59edac0bcc","subject":"libvirt: fix volume walk of /dev/disk/by-path","status":"MERGED","created":"2013-02-20 19:01:41.000000000","updated":"2013-02-21 00:33:01.000000000","submitted":"2013-02-21 00:32:59.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"315803d517412ac6c6b8bc52ee4328b2eb7aa4c4","_number":22461,"virtual_id_number":22461,"owner":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"recommended":{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},{"value":0,"_account_id":24,"name":"Chuck Short","email":"charles.short@windriver.com","username":"zulcss"},{"value":0,"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},{"value":0,"_account_id":1525,"name":"Rafi Khardalian","email":"rafi@metacloud.com","username":"rkhardalian"},{"value":1,"date":"2013-02-20 20:06:58.000000000","_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},{"value":0,"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},{"value":2,"date":"2013-02-21 00:32:59.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"all":[{"value":2,"date":"2013-02-20 20:54:02.000000000","_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},{"value":1,"date":"2013-02-20 19:27:08.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":24,"name":"Chuck Short","email":"charles.short@windriver.com","username":"zulcss"},{"value":2,"date":"2013-02-20 20:55:15.000000000","_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},{"value":1,"date":"2013-02-20 19:51:52.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1525,"name":"Rafi Khardalian","email":"rafi@metacloud.com","username":"rkhardalian"},{"value":0,"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},{"value":2,"date":"2013-02-20 20:54:57.000000000","_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"all":[{"value":0,"date":"2013-02-20 20:54:02.000000000","_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},{"value":0,"_account_id":24,"name":"Chuck Short","email":"charles.short@windriver.com","username":"zulcss"},{"value":1,"date":"2013-02-20 20:55:15.000000000","_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},{"value":0,"_account_id":1525,"name":"Rafi Khardalian","email":"rafi@metacloud.com","username":"rkhardalian"},{"value":0,"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},{"value":1,"date":"2013-02-20 20:54:57.000000000","_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},{"value":0,"_account_id":24,"name":"Chuck Short","email":"charles.short@windriver.com","username":"zulcss"},{"value":0,"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},{"value":0,"_account_id":1525,"name":"Rafi Khardalian","email":"rafi@metacloud.com","username":"rkhardalian"},{"value":0,"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},{"value":0,"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":24,"name":"Chuck Short","email":"charles.short@windriver.com","username":"zulcss"},{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},{"_account_id":1525,"name":"Rafi Khardalian","email":"rafi@metacloud.com","username":"rkhardalian"},{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2013-02-20 19:27:08.000000000","updated_by":{"_account_id":24,"name":"Chuck Short","email":"charles.short@windriver.com","username":"zulcss"},"reviewer":{"_account_id":24,"name":"Chuck Short","email":"charles.short@windriver.com","username":"zulcss"},"state":"REVIEWER"},{"updated":"2013-02-20 19:51:52.000000000","updated_by":{"_account_id":1525,"name":"Rafi Khardalian","email":"rafi@metacloud.com","username":"rkhardalian"},"reviewer":{"_account_id":1525,"name":"Rafi Khardalian","email":"rafi@metacloud.com","username":"rkhardalian"},"state":"REVIEWER"},{"updated":"2013-02-20 20:06:58.000000000","updated_by":{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},"reviewer":{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2013-02-20 20:54:02.000000000","updated_by":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"reviewer":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"state":"REVIEWER"},{"updated":"2013-02-20 20:54:57.000000000","updated_by":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"reviewer":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"state":"REVIEWER"},{"updated":"2013-02-20 20:55:15.000000000","updated_by":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"reviewer":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"state":"REVIEWER"},{"updated":"2013-02-21 00:32:59.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"d4f83905297c91a743a78ec810273ae82ff98708","author":{"_account_id":24,"name":"Chuck Short","email":"charles.short@windriver.com","username":"zulcss"},"date":"2013-02-20 19:27:08.000000000","message":"Patch Set 1: Looks good to me, but someone else must approve\n\nlgtm, we see that in the ubuntu builds as well.","accounts_in_message":[],"_revision_number":1},{"id":"294e3266e834f632be3c31078bf1b352c0616d95","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-02-20 19:49:30.000000000","message":"Patch Set 1: Works for me\n\nBuild succeeded.\n\n- http://logs.openstack.org/22461/1/check/gate-nova-pep8/21148 : SUCCESS\n- http://logs.openstack.org/22461/1/check/gate-nova-docs/15715 : SUCCESS\n- http://logs.openstack.org/22461/1/check/gate-nova-python26/17160 : SUCCESS\n- http://logs.openstack.org/22461/1/check/gate-nova-python27/17215 : SUCCESS\n- http://logs.openstack.org/22461/1/check/gate-tempest-devstack-vm-full/4584 : SUCCESS\n- http://logs.openstack.org/22461/1/check/gate-tempest-devstack-vm-postgres-full/4303 : SUCCESS\n- http://logs.openstack.org/22461/1/check/gate-tempest-devstack-vm-quantum/9113 : SUCCESS\n- http://logs.openstack.org/22461/1/check/gate-nova-pylint/8625 : SUCCESS (non-voting)\n","accounts_in_message":[],"_revision_number":1},{"id":"912404765b5dc3bac524cd9b6fdc0deafd8a2d5e","author":{"_account_id":1525,"name":"Rafi Khardalian","email":"rafi@metacloud.com","username":"rkhardalian"},"date":"2013-02-20 19:51:52.000000000","message":"Patch Set 1: Looks good to me, but someone else must approve\n\n","accounts_in_message":[],"_revision_number":1},{"id":"7135c7bdc87e65aa5bcd2d1fc1b5ffe8c3dd4cdc","author":{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},"date":"2013-02-20 20:06:58.000000000","message":"Patch Set 1: Works for me\n\nSmokeStack Results (patch set 1):\n\tLibvirt (Fedora 17) Success: http://smokestack.openstack.org/?go\u003d/jobs/73464\n\tXenServer 5.6 (F17 domU) Success: http://smokestack.openstack.org/?go\u003d/jobs/73465\n","accounts_in_message":[],"_revision_number":1},{"id":"64b2db02ea190b41634cab1ecfdbbd2359fdef33","author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"date":"2013-02-20 20:54:02.000000000","message":"Patch Set 1: Looks good to me (core reviewer)\n\n","accounts_in_message":[],"_revision_number":1},{"id":"5c9116861ac9ab0df0942fca51e8a01d6245c98c","author":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"date":"2013-02-20 20:54:57.000000000","message":"Patch Set 1: Looks good to me (core reviewer); Approved\n\n","accounts_in_message":[],"_revision_number":1},{"id":"94bba9155e1de0e135f4a8fcc1a162e6b70d59dc","author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"date":"2013-02-20 20:55:15.000000000","message":"Patch Set 1: Looks good to me (core reviewer); Approved\n\n","accounts_in_message":[],"_revision_number":1},{"id":"047733a75b9f474dbf4379be1c26463550bf091a","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-02-20 21:07:36.000000000","message":"Patch Set 1: No score\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"51a8dbd7d42459f14f396f5f750ea7b36c8793df","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-02-21 00:32:59.000000000","message":"Patch Set 1: Verified\n\nBuild succeeded.\n\n- http://logs.openstack.org/22461/1/gate/gate-nova-docs/15817 : SUCCESS\n- http://logs.openstack.org/22461/1/gate/gate-nova-pep8/21252 : SUCCESS\n- http://logs.openstack.org/22461/1/gate/gate-nova-python26/17247 : SUCCESS\n- http://logs.openstack.org/22461/1/gate/gate-nova-python27/17316 : SUCCESS\n- http://logs.openstack.org/22461/1/gate/gate-tempest-devstack-vm-full/4735 : SUCCESS\n- http://logs.openstack.org/22461/1/gate/gate-tempest-devstack-vm-postgres-full/4454 : SUCCESS\n- http://logs.openstack.org/22461/1/gate/gate-tempest-devstack-vm-quantum/9275 : SUCCESS\n","accounts_in_message":[],"_revision_number":1},{"id":"8c73857de86509bae0056677b3388532c456a930","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-02-21 00:33:01.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"fe5382819a8e21d3c32832d92c41477df21c34fa","revisions":{"fe5382819a8e21d3c32832d92c41477df21c34fa":{"kind":"REWORK","_number":1,"created":"2013-02-20 19:01:41.000000000","uploader":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"ref":"refs/changes/61/22461/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/61/22461/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/61/22461/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/61/22461/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/61/22461/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/61/22461/1"}}},"commit":{"parents":[{"commit":"f478fa696746ba61f3749a9b0559bbbaaf25cfa5","subject":"Merge \"Prevent the unexpected with nova-manage network modify.\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/f478fa696746ba61f3749a9b0559bbbaaf25cfa5"}]}],"author":{"name":"Vishvananda Ishaya","email":"vishvananda@gmail.com","date":"2013-02-20 18:53:40.000000000","tz":-480},"committer":{"name":"Vishvananda Ishaya","email":"vishvananda@gmail.com","date":"2013-02-20 19:01:16.000000000","tz":-480},"subject":"libvirt: fix volume walk of /dev/disk/by-path","message":"libvirt: fix volume walk of /dev/disk/by-path\n\nIf /dev/disk/by-path does not exist, then _get_iscsi_devices() will\nraise an IndexError. Handle this case and return an empty list. This\nfixes a test on OSX.\n\nFixes bug 1130841\n\nChange-Id: Ibae2f1238feac9a10b8dc2b74886ea59edac0bcc\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/fe5382819a8e21d3c32832d92c41477df21c34fa"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/fe5382819a8e21d3c32832d92c41477df21c34fa"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"f478fa696746ba61f3749a9b0559bbbaaf25cfa5","is_merged_in_target_branch":true}],"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}