)]}'
{"nova/virt/libvirt/driver.py":[{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"1134933ccbafb6eed3074324aae8520edf745385","unresolved":false,"context_lines":[{"line_number":2639,"context_line":"                              \"\u0027%(ex)s\u0027\"), {\u0027path\u0027: dirpath, \u0027ex\u0027: e})"},{"line_number":2640,"context_line":"        finally:"},{"line_number":2641,"context_line":"            # ensure we call close(fd), when open() succeeds to delete the last"},{"line_number":2642,"context_line":"            # link to the file after unlink(file)"},{"line_number":2643,"context_line":"            if fd is not None:"},{"line_number":2644,"context_line":"                os.close(fd)"},{"line_number":2645,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ba15a1d1_76a71ebd","line":2642,"updated":"2015-09-17 20:42:20.000000000","message":"suggest to reword this comments to say\nensure unlink will remove the file due to close function close the file descriptor","commit_id":"51059d28944c5bfac419501548cb73e601af18fd"},{"author":{"_account_id":6849,"name":"Roman Podoliaka","email":"roman.podoliaka@gmail.com","username":"rpodolyaka"},"change_message_id":"5d2a2dff5afa2f37f7c3dbb90d731a38ff3c58a0","unresolved":false,"context_lines":[{"line_number":2639,"context_line":"                              \"\u0027%(ex)s\u0027\"), {\u0027path\u0027: dirpath, \u0027ex\u0027: e})"},{"line_number":2640,"context_line":"        finally:"},{"line_number":2641,"context_line":"            # ensure we call close(fd), when open() succeeds to delete the last"},{"line_number":2642,"context_line":"            # link to the file after unlink(file)"},{"line_number":2643,"context_line":"            if fd is not None:"},{"line_number":2644,"context_line":"                os.close(fd)"},{"line_number":2645,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ba15a1d1_dd9dd00a","line":2642,"in_reply_to":"ba15a1d1_76a71ebd","updated":"2015-09-18 13:20:37.000000000","message":"Done","commit_id":"51059d28944c5bfac419501548cb73e601af18fd"},{"author":{"_account_id":8802,"name":"Vladik Romanovsky","email":"vromanso@redhat.com","username":"vladikr"},"change_message_id":"0da9e9ee69b06a798e3c0d3b4362291a88af74c3","unresolved":false,"context_lines":[{"line_number":2642,"context_line":"            # ensure unlink(filepath) will actually remove the file by deleting"},{"line_number":2643,"context_line":"            # the remaining link to it in close(fd)"},{"line_number":2644,"context_line":"            if fd is not None:"},{"line_number":2645,"context_line":"                os.close(fd)"},{"line_number":2646,"context_line":""},{"line_number":2647,"context_line":"            try:"},{"line_number":2648,"context_line":"                os.unlink(testfile)"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba15a1d1_955b682e","line":2645,"updated":"2015-09-21 16:31:00.000000000","message":"wouldn\u0027t it be the same if you would just move the os.close(f) to the finally block? Always closing it here will not require the additional if?","commit_id":"18a994ea2d7637adde9c76bed28b8c73683761d2"}]}