)]}'
{"nova/compute/manager.py":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"1aea3d08d23900daf0893da1bfdf7c62f6183898","unresolved":false,"context_lines":[{"line_number":3692,"context_line":"            if erroneously_running and old_enough:"},{"line_number":3693,"context_line":"                return True"},{"line_number":3694,"context_line":"            return False"},{"line_number":3695,"context_line":"        timeout \u003d CONF.running_deleted_instance_timeout"},{"line_number":3696,"context_line":"        instances \u003d self._get_instances_on_driver(context)"},{"line_number":3697,"context_line":"        return [i for i in instances if deleted_instance(i)]"},{"line_number":3698,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2Bl5I%3D","line":3695,"updated":"2013-02-26 15:27:50.000000000","message":"Not sure I understand why has this timeout moved here. Would it not look better above the function definition? I guess I would prefer the reduced scope of the previous code, but maybe this is more efficient.","commit_id":"8222ccb86b2c9a69b987f1861ce696342df8f4ee"},{"author":{"_account_id":6450,"name":"Hans Lindgren","email":"hanlind@kth.se","username":"hanlind"},"change_message_id":"4547639e435f820008e1e7bf5042931abc726c72","unresolved":false,"context_lines":[{"line_number":3692,"context_line":"            if erroneously_running and old_enough:"},{"line_number":3693,"context_line":"                return True"},{"line_number":3694,"context_line":"            return False"},{"line_number":3695,"context_line":"        timeout \u003d CONF.running_deleted_instance_timeout"},{"line_number":3696,"context_line":"        instances \u003d self._get_instances_on_driver(context)"},{"line_number":3697,"context_line":"        return [i for i in instances if deleted_instance(i)]"},{"line_number":3698,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2BkyQ%3D","line":3695,"in_reply_to":"AAAAM3%2F%2Bl5I%3D","updated":"2013-02-26 23:44:51.000000000","message":"Yes, this was for efficiency. I have moved it above the function definition. Should I move it back inside?","commit_id":"8222ccb86b2c9a69b987f1861ce696342df8f4ee"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"1aea3d08d23900daf0893da1bfdf7c62f6183898","unresolved":false,"context_lines":[{"line_number":3693,"context_line":"                return True"},{"line_number":3694,"context_line":"            return False"},{"line_number":3695,"context_line":"        timeout \u003d CONF.running_deleted_instance_timeout"},{"line_number":3696,"context_line":"        instances \u003d self._get_instances_on_driver(context)"},{"line_number":3697,"context_line":"        return [i for i in instances if deleted_instance(i)]"},{"line_number":3698,"context_line":""},{"line_number":3699,"context_line":"    @contextlib.contextmanager"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2Bl4I%3D","line":3696,"updated":"2013-02-26 15:27:50.000000000","message":"Bit worried by the fact this call is so inefficient at the moment, maybe that should be fixed first?","commit_id":"8222ccb86b2c9a69b987f1861ce696342df8f4ee"},{"author":{"_account_id":6450,"name":"Hans Lindgren","email":"hanlind@kth.se","username":"hanlind"},"change_message_id":"4547639e435f820008e1e7bf5042931abc726c72","unresolved":false,"context_lines":[{"line_number":3693,"context_line":"                return True"},{"line_number":3694,"context_line":"            return False"},{"line_number":3695,"context_line":"        timeout \u003d CONF.running_deleted_instance_timeout"},{"line_number":3696,"context_line":"        instances \u003d self._get_instances_on_driver(context)"},{"line_number":3697,"context_line":"        return [i for i in instances if deleted_instance(i)]"},{"line_number":3698,"context_line":""},{"line_number":3699,"context_line":"    @contextlib.contextmanager"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2Bkys%3D","line":3696,"in_reply_to":"AAAAM3%2F%2Bl4I%3D","updated":"2013-02-26 23:44:51.000000000","message":"Done","commit_id":"8222ccb86b2c9a69b987f1861ce696342df8f4ee"}],"nova/tests/compute/test_compute.py":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"1aea3d08d23900daf0893da1bfdf7c62f6183898","unresolved":false,"context_lines":[{"line_number":3086,"context_line":""},{"line_number":3087,"context_line":"        self.mox.StubOutWithMock(self.compute.conductor_api,"},{"line_number":3088,"context_line":"                                 \"instance_get_by_uuid\")"},{"line_number":3089,"context_line":"        self.compute.conductor_api.instance_get_by_uuid(\u0027context\u0027,"},{"line_number":3090,"context_line":"                                                        \u0027herp\u0027).AndReturn("},{"line_number":3091,"context_line":"                                                                instance1)"},{"line_number":3092,"context_line":"        self.compute.conductor_api.instance_get_by_uuid(\u0027context\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2Bl4E%3D","line":3089,"updated":"2013-02-26 15:27:50.000000000","message":"I would stub out self.compute._get_instances_on_driver for a more robust test. Same in the above test really. Assuming that _get_instances_on_driver is tested somewhere.","commit_id":"8222ccb86b2c9a69b987f1861ce696342df8f4ee"},{"author":{"_account_id":6450,"name":"Hans Lindgren","email":"hanlind@kth.se","username":"hanlind"},"change_message_id":"4547639e435f820008e1e7bf5042931abc726c72","unresolved":false,"context_lines":[{"line_number":3086,"context_line":""},{"line_number":3087,"context_line":"        self.mox.StubOutWithMock(self.compute.conductor_api,"},{"line_number":3088,"context_line":"                                 \"instance_get_by_uuid\")"},{"line_number":3089,"context_line":"        self.compute.conductor_api.instance_get_by_uuid(\u0027context\u0027,"},{"line_number":3090,"context_line":"                                                        \u0027herp\u0027).AndReturn("},{"line_number":3091,"context_line":"                                                                instance1)"},{"line_number":3092,"context_line":"        self.compute.conductor_api.instance_get_by_uuid(\u0027context\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2BkyM%3D","line":3089,"in_reply_to":"AAAAM3%2F%2Bl4E%3D","updated":"2013-02-26 23:44:51.000000000","message":"Done","commit_id":"8222ccb86b2c9a69b987f1861ce696342df8f4ee"}]}