)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9060,"name":"Mike Dorman","email":"dorm@dorm.org","username":"gd-mdorman"},"change_message_id":"93a39879509c5ba2180f63fdff5e90b5297b49ae","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2015-09-17 21:13:25 +0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"websocketproxy: Ignore malformed cookies."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I178769fe16e5985e16c2947b8dd716927477e505"},{"line_number":10,"context_line":"Closes-Bug: #1496932"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"ba15a1d1_d6fceab9","line":8,"updated":"2015-09-17 20:32:49.000000000","message":"+1 please add some details here.","commit_id":"0d682b1a562fd7b36dff3b5b1db00e6fe57b0957"},{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"c1970c445dcb73e319dcdf293159b9a29247eca9","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2015-09-17 21:13:25 +0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"websocketproxy: Ignore malformed cookies."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I178769fe16e5985e16c2947b8dd716927477e505"},{"line_number":10,"context_line":"Closes-Bug: #1496932"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"ba15a1d1_2b6dc3cb","line":8,"updated":"2015-09-17 19:29:18.000000000","message":"Please provide additional details here beyond just a title.  Perhaps explain why the cookie is being loaded in parts now rather than what was done before.","commit_id":"0d682b1a562fd7b36dff3b5b1db00e6fe57b0957"}],"nova/console/websocketproxy.py":[{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"c1970c445dcb73e319dcdf293159b9a29247eca9","unresolved":false,"context_lines":[{"line_number":98,"context_line":"                for hcookie_part in hcookie.split(\u0027;\u0027):"},{"line_number":99,"context_line":"                    hcookie_part \u003d hcookie_part.lstrip()"},{"line_number":100,"context_line":"                    try:"},{"line_number":101,"context_line":"                        cookie.load(hcookie_part)"},{"line_number":102,"context_line":"                    except Cookie.CookieError:"},{"line_number":103,"context_line":"                        # Ignore malformed cookie."},{"line_number":104,"context_line":"                        LOG.debug(\u0027Malformed cookie: \"%s\"\u0027, hcookie_part,"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba15a1d1_ab8f9373","line":101,"updated":"2015-09-17 19:29:18.000000000","message":"I\u0027m not familiar with cookie loading, but is this additive?  A quick reading of the python docs seems to suggest that it is but I want to ensure that if token is found in an early part of the cookie that it could still be found in line 106 below.\n\nAlso, it\u0027s not clear to me why this is being done in parts.  Is it just for the debug message?","commit_id":"0d682b1a562fd7b36dff3b5b1db00e6fe57b0957"},{"author":{"_account_id":9060,"name":"Mike Dorman","email":"dorm@dorm.org","username":"gd-mdorman"},"change_message_id":"93a39879509c5ba2180f63fdff5e90b5297b49ae","unresolved":false,"context_lines":[{"line_number":98,"context_line":"                for hcookie_part in hcookie.split(\u0027;\u0027):"},{"line_number":99,"context_line":"                    hcookie_part \u003d hcookie_part.lstrip()"},{"line_number":100,"context_line":"                    try:"},{"line_number":101,"context_line":"                        cookie.load(hcookie_part)"},{"line_number":102,"context_line":"                    except Cookie.CookieError:"},{"line_number":103,"context_line":"                        # Ignore malformed cookie."},{"line_number":104,"context_line":"                        LOG.debug(\u0027Malformed cookie: \"%s\"\u0027, hcookie_part,"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba15a1d1_7632bea8","line":101,"updated":"2015-09-17 20:32:49.000000000","message":"I\u0027m not opposed to the loop here.  Although based on the error output from the bug report, it does seem as if you could probably get the name of the errant cookie from the exception thrown by cookie.load(hcookie)","commit_id":"0d682b1a562fd7b36dff3b5b1db00e6fe57b0957"}]}