)]}'
{"id":"openstack%2Fnova~2253","triplet_id":"openstack%2Fnova~master~Iae88c72f4fd2c7c097c23ef9e5f8fd392052f73e","project":"openstack/nova","branch":"master","topic":"bug/899767","hashtags":[],"change_id":"Iae88c72f4fd2c7c097c23ef9e5f8fd392052f73e","subject":"bug 899767: fix vif-plugging with live migration","status":"MERGED","created":"2011-12-12 06:04:01.000000000","updated":"2011-12-13 21:32:19.000000000","submitted":"2011-12-13 21:32:18.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"52ec43973987c6fcb68ae18c1df11f5cc9dace0c","_number":2253,"virtual_id_number":2253,"owner":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},{"value":0,"_account_id":475,"name":"Rick Harris","email":"rick.harris@rackspace.com","username":"rconradharris"},{"value":0,"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},{"value":1,"date":"2011-12-13 21:32:18.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"recommended":{"_account_id":475,"name":"Rick Harris","email":"rick.harris@rackspace.com","username":"rconradharris"},"all":[{"value":0,"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},{"value":1,"date":"2011-12-13 19:57:46.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":475,"name":"Rick Harris","email":"rick.harris@rackspace.com","username":"rconradharris"},{"value":2,"date":"2011-12-13 21:22:55.000000000","_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},{"value":0,"date":"2011-12-13 21:32:18.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"all":[{"value":0,"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},{"value":0,"_account_id":475,"name":"Rick Harris","email":"rick.harris@rackspace.com","username":"rconradharris"},{"value":0,"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},{"value":0,"_account_id":475,"name":"Rick Harris","email":"rick.harris@rackspace.com","username":"rconradharris"},{"value":0,"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},{"_account_id":475,"name":"Rick Harris","email":"rick.harris@rackspace.com","username":"rconradharris"},{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2011-12-12 18:03:03.000000000","updated_by":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"reviewer":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"state":"REVIEWER"},{"updated":"2011-12-13 19:57:46.000000000","updated_by":{"_account_id":475,"name":"Rick Harris","email":"rick.harris@rackspace.com","username":"rconradharris"},"reviewer":{"_account_id":475,"name":"Rick Harris","email":"rick.harris@rackspace.com","username":"rconradharris"},"state":"REVIEWER"},{"updated":"2011-12-13 21:22:55.000000000","updated_by":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"reviewer":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"state":"REVIEWER"},{"updated":"2011-12-13 21:32:18.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"94c8577b0064063ac1ae4954befaaa8a11c5a140","author":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"date":"2011-12-12 06:32:23.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"701be84255108d9748b24d5189ae59d0d3c61ef8","author":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"date":"2011-12-12 18:03:03.000000000","message":"Patch Set 2: I would prefer that you didn\u0027t submit this\n\n(1 inline comment)\n\nPEP8 error, see inline.  PEP8 testing can be done by running ./run_tests.sh -p","accounts_in_message":[],"_revision_number":2},{"id":"bdf871cb282f06efe9492d15222d31c67d86679b","author":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"date":"2011-12-12 18:34:55.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"7bea6b770fb2ed39c38484da2dea8a2afca232a2","author":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"date":"2011-12-12 18:36:16.000000000","message":"Patch Set 2: (1 inline comment)\n\n","accounts_in_message":[],"_revision_number":2},{"id":"a68362564354d4548e0a1992d542f11f29912ac4","author":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"date":"2011-12-13 17:54:10.000000000","message":"Patch Set 3: Looks good to me, but someone else must approve\n\nCode looks correct.  I will feel way better about changes like this when we have integration testing that actually does live migration.  :)","accounts_in_message":[],"_revision_number":3},{"id":"ab35320c3f2e53ff6fc50ab6508d3d0eb776b1b7","author":{"_account_id":475,"name":"Rick Harris","email":"rick.harris@rackspace.com","username":"rconradharris"},"date":"2011-12-13 19:57:46.000000000","message":"Patch Set 3: Looks good to me, but someone else must approve\n\nLooks sensible.","accounts_in_message":[],"_revision_number":3},{"id":"d2b803bb638842132e6f0f0dc2d0b0053a9fd298","author":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"date":"2011-12-13 21:22:55.000000000","message":"Patch Set 3: Looks good to me, approved\n\n","accounts_in_message":[],"_revision_number":3},{"id":"8c52f215c379311ac15327cf83233f3637ef79bd","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2011-12-13 21:32:18.000000000","message":"Patch Set 3: Verified\n\nBuild Successful \n \nhttps://jenkins.openstack.org/job/gate-nova-unittests/247/ : SUCCESS \nhttps://jenkins.openstack.org/job/gate-nova-pep8/2011/ : SUCCESS \nhttps://jenkins.openstack.org/job/gate-nova-merge/636/ : SUCCESS","accounts_in_message":[],"_revision_number":3},{"id":"8462f79a688698a23c6c45edfcb658c884e3f18c","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2011-12-13 21:32:19.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"6b6633521c57422dfcdd1c0fbd8004c01bbe99cc","revisions":{"940c61c242702398a79e846e746d17cc2803c5d4":{"kind":"REWORK","_number":1,"created":"2011-12-12 06:04:01.000000000","uploader":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"ref":"refs/changes/53/2253/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/53/2253/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/53/2253/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/53/2253/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/53/2253/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/53/2253/1"}}},"commit":{"parents":[{"commit":"1b4a0f859e76de4c6e5cb7b51a12e9bf2fb3e295","subject":"Merge \"Add preparation for asynchronous instance faults\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/1b4a0f859e76de4c6e5cb7b51a12e9bf2fb3e295"}]}],"author":{"name":"Dan Wendlandt","email":"dan@nicira.com","date":"2011-12-04 00:27:03.000000000","tz":-480},"committer":{"name":"Dan Wendlandt","email":"dan@nicira.com","date":"2011-12-12 06:03:57.000000000","tz":-480},"subject":"bug 899767: fix vif-plugging with live migration","message":"bug 899767: fix vif-plugging with live migration\n\nExpose vif_unplug method in virt layer, as the compute manager has to\nexplicitly call it on during live migration, so that network devices are\ntorn down even if the disk image is not.\n\nChange-Id: Iae88c72f4fd2c7c097c23ef9e5f8fd392052f73e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/940c61c242702398a79e846e746d17cc2803c5d4"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/940c61c242702398a79e846e746d17cc2803c5d4"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"1b4a0f859e76de4c6e5cb7b51a12e9bf2fb3e295","is_merged_in_target_branch":true}],"branch":"refs/heads/master"},"6e8e6b34486b3aeaaafeea0958ac65a5c299b086":{"kind":"REWORK","_number":2,"created":"2011-12-12 06:32:23.000000000","uploader":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"ref":"refs/changes/53/2253/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/53/2253/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/53/2253/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/53/2253/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/53/2253/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/53/2253/2"}}},"commit":{"parents":[{"commit":"1b4a0f859e76de4c6e5cb7b51a12e9bf2fb3e295","subject":"Merge \"Add preparation for asynchronous instance faults\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/1b4a0f859e76de4c6e5cb7b51a12e9bf2fb3e295"}]}],"author":{"name":"Dan Wendlandt","email":"dan@nicira.com","date":"2011-12-12 06:32:16.000000000","tz":-480},"committer":{"name":"Dan Wendlandt","email":"dan@nicira.com","date":"2011-12-12 06:32:16.000000000","tz":-480},"subject":"bug 899767: fix vif-plugging with live migration","message":"bug 899767: fix vif-plugging with live migration\n\nExpose vif_unplug method in virt layer, as the compute manager has to\nexplicitly call it on during live migration, so that network devices are\ntorn down even if the disk image is not.\n\nChange-Id: Iae88c72f4fd2c7c097c23ef9e5f8fd392052f73e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/6e8e6b34486b3aeaaafeea0958ac65a5c299b086"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/6e8e6b34486b3aeaaafeea0958ac65a5c299b086"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"1b4a0f859e76de4c6e5cb7b51a12e9bf2fb3e295","is_merged_in_target_branch":true}],"branch":"refs/heads/master"},"6b6633521c57422dfcdd1c0fbd8004c01bbe99cc":{"kind":"REWORK","_number":3,"created":"2011-12-12 18:34:55.000000000","uploader":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"ref":"refs/changes/53/2253/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/53/2253/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/53/2253/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/53/2253/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/53/2253/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/53/2253/3"}}},"commit":{"parents":[{"commit":"b43fa8b590850fd50a85f36da8c3046c3a1c19a0","subject":"Merge \"fixed_ips by vif does not raise\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/b43fa8b590850fd50a85f36da8c3046c3a1c19a0"}]}],"author":{"name":"Dan Wendlandt","email":"dan@nicira.com","date":"2011-12-12 18:34:33.000000000","tz":-480},"committer":{"name":"Dan Wendlandt","email":"dan@nicira.com","date":"2011-12-12 18:34:52.000000000","tz":-480},"subject":"bug 899767: fix vif-plugging with live migration","message":"bug 899767: fix vif-plugging with live migration\n\nExpose vif_unplug method in virt layer, as the compute manager has to\nexplicitly call it on during live migration, so that network devices are\ntorn down even if the disk image is not.\n\nChange-Id: Iae88c72f4fd2c7c097c23ef9e5f8fd392052f73e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/6b6633521c57422dfcdd1c0fbd8004c01bbe99cc"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/6b6633521c57422dfcdd1c0fbd8004c01bbe99cc"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"b43fa8b590850fd50a85f36da8c3046c3a1c19a0","is_merged_in_target_branch":true}],"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}