)]}'
{"nova/virt/xenapi/vmops.py":[{"author":{"_account_id":494,"name":"termie","email":"termie@openstack.org","username":"termie"},"change_message_id":"cdb196193d7613f1f0b3afe57be553bf51bd8ab5","unresolved":false,"context_lines":[{"line_number":408,"context_line":"        # Wait for boot to finish"},{"line_number":409,"context_line":"        LOG.debug(_(\u0027Instance %s: waiting for running\u0027), instance_name)"},{"line_number":410,"context_line":"        while True:"},{"line_number":411,"context_line":"            greenthread.sleep(0.5)"},{"line_number":412,"context_line":""},{"line_number":413,"context_line":"            state \u003d self.get_info(instance_name)[\u0027state\u0027]"},{"line_number":414,"context_line":"            if state \u003d\u003d power_state.RUNNING:"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAC3%2F%2F9nc%3D","line":411,"updated":"2011-12-12 21:16:23.000000000","message":"maybe put this at the end of the while loop, to save the half second during tests","commit_id":"67139d33dd5ce8b6960faf84e091f57958a63d66"},{"author":{"_account_id":100,"name":"Johannes Erdfelt","email":"johannes@erdfelt.com","username":"johannes.erdfelt"},"change_message_id":"cd55b61c006886389cb272696d5cc12e4ca54da1","unresolved":false,"context_lines":[{"line_number":408,"context_line":"        # Wait for boot to finish"},{"line_number":409,"context_line":"        LOG.debug(_(\u0027Instance %s: waiting for running\u0027), instance_name)"},{"line_number":410,"context_line":"        while True:"},{"line_number":411,"context_line":"            greenthread.sleep(0.5)"},{"line_number":412,"context_line":""},{"line_number":413,"context_line":"            state \u003d self.get_info(instance_name)[\u0027state\u0027]"},{"line_number":414,"context_line":"            if state \u003d\u003d power_state.RUNNING:"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAC3%2F%2F9jA%3D","line":411,"in_reply_to":"AAAAC3%2F%2F9nc%3D","updated":"2011-12-12 21:25:41.000000000","message":"Will do","commit_id":"67139d33dd5ce8b6960faf84e091f57958a63d66"},{"author":{"_account_id":494,"name":"termie","email":"termie@openstack.org","username":"termie"},"change_message_id":"cdb196193d7613f1f0b3afe57be553bf51bd8ab5","unresolved":false,"context_lines":[{"line_number":459,"context_line":"        # Set VCPU weight"},{"line_number":460,"context_line":"        inst_type \u003d db.instance_type_get(ctx, instance.instance_type_id)"},{"line_number":461,"context_line":"        vcpu_weight \u003d inst_type[\"vcpu_weight\"]"},{"line_number":462,"context_line":"        if str(vcpu_weight) !\u003d \"None\":"},{"line_number":463,"context_line":"            LOG.debug(_(\"Setting VCPU weight\"))"},{"line_number":464,"context_line":"            self._session.call_xenapi(\"VM.add_to_VCPUs_params\", vm_ref,"},{"line_number":465,"context_line":"                    \"weight\", vcpu_weight)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAC3%2F%2F9nU%3D","line":462,"updated":"2011-12-12 21:16:23.000000000","message":"this seems a little fragile, is there a better false value?","commit_id":"67139d33dd5ce8b6960faf84e091f57958a63d66"},{"author":{"_account_id":100,"name":"Johannes Erdfelt","email":"johannes@erdfelt.com","username":"johannes.erdfelt"},"change_message_id":"673f233782644feaf141b418ee46b744ebc47a91","unresolved":false,"context_lines":[{"line_number":459,"context_line":"        # Set VCPU weight"},{"line_number":460,"context_line":"        inst_type \u003d db.instance_type_get(ctx, instance.instance_type_id)"},{"line_number":461,"context_line":"        vcpu_weight \u003d inst_type[\"vcpu_weight\"]"},{"line_number":462,"context_line":"        if str(vcpu_weight) !\u003d \"None\":"},{"line_number":463,"context_line":"            LOG.debug(_(\"Setting VCPU weight\"))"},{"line_number":464,"context_line":"            self._session.call_xenapi(\"VM.add_to_VCPUs_params\", vm_ref,"},{"line_number":465,"context_line":"                    \"weight\", vcpu_weight)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAC3%2F%2F9iY%3D","line":462,"in_reply_to":"AAAAC3%2F%2F9i8%3D","updated":"2011-12-12 21:37:31.000000000","message":"Talking to jk0 about it (since he wrote it), he said it had to do with some problems related to the migration when the column was added.\n\nI guess there\u0027s an argument that it should be cleaned up, but it seems outside the scope of this patch.\n\nI\u0027m sure no one will have any qualms if you opened up a bug on it.","commit_id":"67139d33dd5ce8b6960faf84e091f57958a63d66"},{"author":{"_account_id":100,"name":"Johannes Erdfelt","email":"johannes@erdfelt.com","username":"johannes.erdfelt"},"change_message_id":"cd55b61c006886389cb272696d5cc12e4ca54da1","unresolved":false,"context_lines":[{"line_number":459,"context_line":"        # Set VCPU weight"},{"line_number":460,"context_line":"        inst_type \u003d db.instance_type_get(ctx, instance.instance_type_id)"},{"line_number":461,"context_line":"        vcpu_weight \u003d inst_type[\"vcpu_weight\"]"},{"line_number":462,"context_line":"        if str(vcpu_weight) !\u003d \"None\":"},{"line_number":463,"context_line":"            LOG.debug(_(\"Setting VCPU weight\"))"},{"line_number":464,"context_line":"            self._session.call_xenapi(\"VM.add_to_VCPUs_params\", vm_ref,"},{"line_number":465,"context_line":"                    \"weight\", vcpu_weight)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAC3%2F%2F9i8%3D","line":462,"in_reply_to":"AAAAC3%2F%2F9nU%3D","updated":"2011-12-12 21:25:41.000000000","message":"I can\u0027t answer that question. This code already existed before this patch, I just reformatted it.","commit_id":"67139d33dd5ce8b6960faf84e091f57958a63d66"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"812c5a6a550e7a9b65f3c8bf8e0bf606664ba865","unresolved":false,"context_lines":[{"line_number":448,"context_line":"            if state \u003d\u003d power_state.RUNNING:"},{"line_number":449,"context_line":"                break"},{"line_number":450,"context_line":""},{"line_number":451,"context_line":"            greenthread.sleep(0.5)"},{"line_number":452,"context_line":""},{"line_number":453,"context_line":"        LOG.debug(_(\u0027Instance %s: running\u0027), instance_name)"},{"line_number":454,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAC3%2F%2F87w%3D","line":451,"updated":"2011-12-14 17:37:16.000000000","message":"There is no timeout here... isn\u0027t that a potential infinite loop?","commit_id":"ddc0b7cb3b366e0a33cb952d0d22e366fbcd3a07"}]}