)]}'
{"nova/scheduler/filter_scheduler.py":[{"author":{"_account_id":8688,"name":"Alexis Lee","email":"openstack@lxsli.co.uk","username":"lxsli"},"change_message_id":"ed201ef4570be834338864149a259ad87abce9ba","unresolved":false,"context_lines":[{"line_number":162,"context_line":"                chosen_host \u003d random.choice(weighed_hosts)"},{"line_number":163,"context_line":"            else:"},{"line_number":164,"context_line":"                chosen_host \u003d random.choice("},{"line_number":165,"context_line":"                    weighed_hosts[0:scheduler_host_subset_size])"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"            LOG.debug(\"Selected host: %(host)s\", {\u0027host\u0027: chosen_host})"},{"line_number":168,"context_line":"            selected_hosts.append(chosen_host)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a1a9d01_c42d8847","line":165,"updated":"2015-09-28 10:34:46.000000000","message":"a) I don\u0027t think this change makes any difference to anyone;\n\nb) the code would be clearer as:\n\n  if scheduler_host_subset_size \u003c len(weighed_hosts):\n    weighed_hosts \u003d weighed_hosts[0:scheduler_host_subset_size]\n  chosen_host \u003d random.choice(weighed_hosts)","commit_id":"5478df7de5b0496133b40319a0acb37d6ba1e994"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"45a81cd8c7e1de7b72f1a8a719f9a989c8974d7c","unresolved":false,"context_lines":[{"line_number":162,"context_line":"                chosen_host \u003d random.choice(weighed_hosts)"},{"line_number":163,"context_line":"            else:"},{"line_number":164,"context_line":"                chosen_host \u003d random.choice("},{"line_number":165,"context_line":"                    weighed_hosts[0:scheduler_host_subset_size])"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"            LOG.debug(\"Selected host: %(host)s\", {\u0027host\u0027: chosen_host})"},{"line_number":168,"context_line":"            selected_hosts.append(chosen_host)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a1a9d01_8f21e9a1","line":165,"in_reply_to":"9a1a9d01_c42d8847","updated":"2015-09-28 10:51:26.000000000","message":"clearer !\u003d concise","commit_id":"5478df7de5b0496133b40319a0acb37d6ba1e994"},{"author":{"_account_id":14027,"name":"Michal Rostecki","email":"mrostecki@suse.de","username":"mrostecki"},"change_message_id":"34825496a2f86736e02116c982f3722ad213a432","unresolved":false,"context_lines":[{"line_number":159,"context_line":"            scheduler_host_subset_size \u003d max(1,"},{"line_number":160,"context_line":"                                             CONF.scheduler_host_subset_size)"},{"line_number":161,"context_line":"            if scheduler_host_subset_size \u003c len(weighed_hosts):"},{"line_number":162,"context_line":"                weighed_hosts \u003d weighed_hosts[0:scheduler_host_subset_size]"},{"line_number":163,"context_line":"            chosen_host \u003d random.choice(weighed_hosts)"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"            LOG.debug(\"Selected host: %(host)s\", {\u0027host\u0027: chosen_host})"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a1a9d01_43257759","line":162,"updated":"2015-09-30 16:10:59.000000000","message":"Why not just\n\n  weighed_hosts \u003d weighed_hosts[:scheduler_host_subset_size]\n\n?","commit_id":"c566db9934acb2077b859f841f03e717d8915eac"},{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"33dddb20a3b890797be5b2ed4cd7d1fedd572202","unresolved":false,"context_lines":[{"line_number":159,"context_line":"            scheduler_host_subset_size \u003d max(1,"},{"line_number":160,"context_line":"                                             CONF.scheduler_host_subset_size)"},{"line_number":161,"context_line":"            if scheduler_host_subset_size \u003c len(weighed_hosts):"},{"line_number":162,"context_line":"                weighed_hosts \u003d weighed_hosts[0:scheduler_host_subset_size]"},{"line_number":163,"context_line":"            chosen_host \u003d random.choice(weighed_hosts)"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"            LOG.debug(\"Selected host: %(host)s\", {\u0027host\u0027: chosen_host})"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a1a9d01_c633be60","line":162,"in_reply_to":"9a1a9d01_43257759","updated":"2015-10-01 05:29:10.000000000","message":"Either works, guess this is just the habit I\u0027ve gotten into.","commit_id":"c566db9934acb2077b859f841f03e717d8915eac"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"d91c9c7a98cd94cd0359c1bc078a0a53e97c1c6e","unresolved":false,"context_lines":[{"line_number":160,"context_line":"                                             CONF.scheduler_host_subset_size)"},{"line_number":161,"context_line":"            if scheduler_host_subset_size \u003c len(weighed_hosts):"},{"line_number":162,"context_line":"                weighed_hosts \u003d weighed_hosts[0:scheduler_host_subset_size]"},{"line_number":163,"context_line":"            chosen_host \u003d random.choice(weighed_hosts)"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"            LOG.debug(\"Selected host: %(host)s\", {\u0027host\u0027: chosen_host})"},{"line_number":166,"context_line":"            selected_hosts.append(chosen_host)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a1a9d01_959e6a61","line":163,"updated":"2015-09-30 14:20:17.000000000","message":"sounds a nice quick-win","commit_id":"c566db9934acb2077b859f841f03e717d8915eac"}]}