)]}'
{"nova/compute/manager.py":[{"author":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"change_message_id":"f92821f563581a7659ab65572163d0acf4902d90","unresolved":false,"context_lines":[{"line_number":1848,"context_line":"                    continue"},{"line_number":1849,"context_line":""},{"line_number":1850,"context_line":"                net \u003d self.network_api.get_network_by_id(context,"},{"line_number":1851,"context_line":"                                                         vif[\u0027network_id\u0027])"},{"line_number":1852,"context_line":"                self.db.bw_usage_update(context,"},{"line_number":1853,"context_line":"                                        vif[\u0027instance_id\u0027],"},{"line_number":1854,"context_line":"                                        net[\u0027label\u0027],"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAC3%2F%2F9fI%3D","line":1851,"updated":"2011-12-12 23:58:44.000000000","message":"Can we get this down to 1 call total somehow?   This is going to slam the network manager every time it runs.  If there\u0027s 50 instances on a host, there\u0027s \"100 * macs\" rpc calls here.\n\nMaybe this should wait so we can use the \u0027cache\u0027 ?","commit_id":"0dfec5e42d6e9271cbd19bf5cdf71244f22890c0"},{"author":{"_account_id":191,"name":"Trey Morris","email":"trey.morris@rackspace.com","username":"tr3buchet"},"change_message_id":"319dcc3bc6bebe2f6ab3988914443744d67f25f0","unresolved":false,"context_lines":[{"line_number":1848,"context_line":"                    continue"},{"line_number":1849,"context_line":""},{"line_number":1850,"context_line":"                net \u003d self.network_api.get_network_by_id(context,"},{"line_number":1851,"context_line":"                                                         vif[\u0027network_id\u0027])"},{"line_number":1852,"context_line":"                self.db.bw_usage_update(context,"},{"line_number":1853,"context_line":"                                        vif[\u0027instance_id\u0027],"},{"line_number":1854,"context_line":"                                        net[\u0027label\u0027],"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAC3%2F%2F9Vg%3D","line":1851,"in_reply_to":"AAAAC3%2F%2F9e4%3D","updated":"2011-12-13 16:16:56.000000000","message":"Comstud: are you fine if this gets slammed for a week or 2?\nkoelker: if he\u0027s not I can see a way to do it, you\u0027ll have to do a network_api.get_instance_nw_info() and do the looptiloops","commit_id":"0dfec5e42d6e9271cbd19bf5cdf71244f22890c0"},{"author":{"_account_id":385,"name":"Jason Kölker","email":"jason@koelker.net","username":"jason-koelker"},"change_message_id":"d2b510da217666ed511f67dfd2a3473ce484df53","unresolved":false,"context_lines":[{"line_number":1848,"context_line":"                    continue"},{"line_number":1849,"context_line":""},{"line_number":1850,"context_line":"                net \u003d self.network_api.get_network_by_id(context,"},{"line_number":1851,"context_line":"                                                         vif[\u0027network_id\u0027])"},{"line_number":1852,"context_line":"                self.db.bw_usage_update(context,"},{"line_number":1853,"context_line":"                                        vif[\u0027instance_id\u0027],"},{"line_number":1854,"context_line":"                                        net[\u0027label\u0027],"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAC3%2F%2F9e4%3D","line":1851,"in_reply_to":"AAAAC3%2F%2F9fI%3D","updated":"2011-12-13 00:23:58.000000000","message":"Right now I can\u0027t see a way to avoid the double lookup. Once the Network Model is integrated in to the network manager, I can have it just return a vif object which will have the network contained in it. That\u0027s probably going to be a week or two until the other model stuff gets integrated into the network manager.\n\nMy plan was to get this in now to fix the bug, then keep the bug open to refactor when we can.","commit_id":"0dfec5e42d6e9271cbd19bf5cdf71244f22890c0"},{"author":{"_account_id":642,"name":"Matt Dietz","email":"matthew.dietz@gmail.com","username":"cerberus"},"change_message_id":"ec0976de7753534ee7adbe30717e53660620a1c0","unresolved":false,"context_lines":[{"line_number":1885,"context_line":"            for usage in bw_usage:"},{"line_number":1886,"context_line":"                mac \u003d usage[\u0027mac_address\u0027]"},{"line_number":1887,"context_line":"                vif \u003d self.network_api.get_vif_by_mac_address(context, mac)"},{"line_number":1888,"context_line":"                if not vif:"},{"line_number":1889,"context_line":"                    continue"},{"line_number":1890,"context_line":""},{"line_number":1891,"context_line":"                self.db.bw_usage_update(context,"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAD3%2F%2F%2B4I%3D","line":1888,"updated":"2012-01-11 20:32:34.000000000","message":"When would this happen?","commit_id":"be431b1aeec602dbdcde5c04cc7a41d7dd2d8f3a"}],"nova/db/sqlalchemy/migrate_repo/versions/065_convert_bw_usage_to_store_network_id.py":[{"author":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"change_message_id":"79a01a1b618d7c990408afed4593e359a6d90cfc","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    bw_usage_cache.create_column(network_label_column)"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    bw_usage_cache.update()\\"},{"line_number":48,"context_line":"        .values(network_id\u003dselect([network.c.label])\\"},{"line_number":49,"context_line":"            .where(network.c.id \u003d\u003d bw_usage_cache.c.network_id)\\"},{"line_number":50,"context_line":"            .as_scalar()).execute()"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAC3%2F%2F8rc%3D","line":48,"updated":"2011-12-15 04:22:14.000000000","message":"Should be:  .values(network_label\u003dselect(..... \n\nRight?","commit_id":"362cb82d4f036431673d60e28d5069fe92440ed5"},{"author":{"_account_id":385,"name":"Jason Kölker","email":"jason@koelker.net","username":"jason-koelker"},"change_message_id":"00288a05c65dce6405619733719c7cefc1d2de24","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    bw_usage_cache.create_column(network_label_column)"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    bw_usage_cache.update()\\"},{"line_number":48,"context_line":"        .values(network_id\u003dselect([network.c.label])\\"},{"line_number":49,"context_line":"            .where(network.c.id \u003d\u003d bw_usage_cache.c.network_id)\\"},{"line_number":50,"context_line":"            .as_scalar()).execute()"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAC3%2F%2F8l4%3D","line":48,"in_reply_to":"AAAAC3%2F%2F8rc%3D","updated":"2011-12-15 15:59:39.000000000","message":"Done","commit_id":"362cb82d4f036431673d60e28d5069fe92440ed5"}],"nova/network/api.py":[{"author":{"_account_id":191,"name":"Trey Morris","email":"trey.morris@rackspace.com","username":"tr3buchet"},"change_message_id":"319dcc3bc6bebe2f6ab3988914443744d67f25f0","unresolved":false,"context_lines":[{"line_number":73,"context_line":"                        FLAGS.network_topic,"},{"line_number":74,"context_line":"                        {\u0027method\u0027: \u0027get_network_by_id\u0027,"},{"line_number":75,"context_line":"                         \u0027args\u0027: {\u0027network_id\u0027: network_id}})"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    def allocate_floating_ip(self, context):"},{"line_number":78,"context_line":"        \"\"\"Adds a floating ip to a project. (allocates)\"\"\""},{"line_number":79,"context_line":"        # NOTE(vish): We don\u0027t know which network host should get the ip"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAC3%2F%2F9Vc%3D","line":76,"updated":"2011-12-13 16:16:56.000000000","message":"If you do just use network_api.get_instance_nw_info(*), these can be dropped","commit_id":"0dfec5e42d6e9271cbd19bf5cdf71244f22890c0"},{"author":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"change_message_id":"79a01a1b618d7c990408afed4593e359a6d90cfc","unresolved":false,"context_lines":[{"line_number":65,"context_line":"    def get_vif_by_mac_address(self, context, mac_address):"},{"line_number":66,"context_line":"        return rpc.call(context,"},{"line_number":67,"context_line":"                        FLAGS.network_topic,"},{"line_number":68,"context_line":"                        {\u0027method\u0027: \u0027get_vifs_by_mac_address\u0027,"},{"line_number":69,"context_line":"                         \u0027args\u0027: {\u0027mac_address\u0027: mac_address}})"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    def get_network_by_id(self, context, network_id):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAC3%2F%2F8rY%3D","line":68,"updated":"2011-12-15 04:22:14.000000000","message":"method is typod.  \u0027vifs\u0027 instead of \u0027vif\u0027.","commit_id":"362cb82d4f036431673d60e28d5069fe92440ed5"},{"author":{"_account_id":385,"name":"Jason Kölker","email":"jason@koelker.net","username":"jason-koelker"},"change_message_id":"00288a05c65dce6405619733719c7cefc1d2de24","unresolved":false,"context_lines":[{"line_number":65,"context_line":"    def get_vif_by_mac_address(self, context, mac_address):"},{"line_number":66,"context_line":"        return rpc.call(context,"},{"line_number":67,"context_line":"                        FLAGS.network_topic,"},{"line_number":68,"context_line":"                        {\u0027method\u0027: \u0027get_vifs_by_mac_address\u0027,"},{"line_number":69,"context_line":"                         \u0027args\u0027: {\u0027mac_address\u0027: mac_address}})"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    def get_network_by_id(self, context, network_id):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAC3%2F%2F8l0%3D","line":68,"in_reply_to":"AAAAC3%2F%2F8rY%3D","updated":"2011-12-15 15:59:39.000000000","message":"Done","commit_id":"362cb82d4f036431673d60e28d5069fe92440ed5"}]}