)]}'
{"nova/objects/instance.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"ba0920870633f818b54dbe6b9000d762562e4a24","unresolved":false,"context_lines":[{"line_number":829,"context_line":"        try:"},{"line_number":830,"context_line":"            yield"},{"line_number":831,"context_line":"        finally:"},{"line_number":832,"context_line":"            self.revert_migration_context()"},{"line_number":833,"context_line":""},{"line_number":834,"context_line":"    @base.remotable"},{"line_number":835,"context_line":"    def drop_migration_context(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba15a1d1_8eac4889","line":832,"updated":"2015-09-23 19:25:32.000000000","message":"This is awesome, except that I think it will be misunderstood by callers. Probably not a problem currently, but later someone could get tripped up by this.\n\nThis sets the instance.numa_topology to the value of the old_ one in the migration context, it does not *restore* the value that was set before we entered the context manager, which Is I think what nearly everyone will expect.","commit_id":"b73b67ec1fb34c67490b3fe9155d484569289152"},{"author":{"_account_id":8688,"name":"Alexis Lee","email":"openstack@lxsli.co.uk","username":"lxsli"},"change_message_id":"0aad3f15cf6c3e0775ff3804d2812fb94c370453","unresolved":false,"context_lines":[{"line_number":831,"context_line":"        context will be saved which can cause incorrect resource tracking, and"},{"line_number":832,"context_line":"        should be avoided."},{"line_number":833,"context_line":"        \"\"\""},{"line_number":834,"context_line":"        current_numa_topo \u003d self.numa_topology"},{"line_number":835,"context_line":"        self.apply_migration_context()"},{"line_number":836,"context_line":"        try:"},{"line_number":837,"context_line":"            yield"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a1a9d01_15b0c3dc","line":834,"updated":"2015-09-25 12:41:39.000000000","message":"Why don\u0027t we try to restore all of ourself afterwards, not just NUMA?","commit_id":"66e0744471ce491371a67ffdd8ba3c105919e255"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"b40aa3c882d74782ec95d0814edb3ef3adc3904f","unresolved":false,"context_lines":[{"line_number":831,"context_line":"        context will be saved which can cause incorrect resource tracking, and"},{"line_number":832,"context_line":"        should be avoided."},{"line_number":833,"context_line":"        \"\"\""},{"line_number":834,"context_line":"        current_numa_topo \u003d self.numa_topology"},{"line_number":835,"context_line":"        self.apply_migration_context()"},{"line_number":836,"context_line":"        try:"},{"line_number":837,"context_line":"            yield"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a1a9d01_272801e2","line":834,"in_reply_to":"9a1a9d01_15b0c3dc","updated":"2015-09-28 12:58:41.000000000","message":"I think its more about just reverting the apply:\nhttps://github.com/openstack/nova/blob/master/nova/objects/instance.py#L812","commit_id":"66e0744471ce491371a67ffdd8ba3c105919e255"}],"nova/tests/unit/objects/test_instance.py":[{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"2ff65b2964e91e59f673a2e0da55e81cb496fb77","unresolved":false,"context_lines":[{"line_number":1227,"context_line":"                                 uuid\u003d\u0027fake-uuid\u0027, numa_topology\u003dnuma_topology)"},{"line_number":1228,"context_line":"        with inst.mutated_migration_context():"},{"line_number":1229,"context_line":"            self.assertIsInstance(inst.numa_topology,"},{"line_number":1230,"context_line":"                                  objects.InstanceNUMATopology)"},{"line_number":1231,"context_line":"        self.assertIs(numa_topology, inst.numa_topology)"},{"line_number":1232,"context_line":""},{"line_number":1233,"context_line":"    @mock.patch.object(objects.Instance, \u0027get_by_uuid\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a1a9d01_fa64454a","line":1230,"updated":"2015-09-24 14:08:13.000000000","message":"It is better have fake migration context. otherwise we can\u0027t ensure the numa_topology is changed.","commit_id":"995473e42423942cd3787ba51724720ff2eb09f3"},{"author":{"_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},"change_message_id":"868a419dec2edacdec438f50baff791a8ea97c5f","unresolved":false,"context_lines":[{"line_number":1227,"context_line":"                                 uuid\u003d\u0027fake-uuid\u0027, numa_topology\u003dnuma_topology)"},{"line_number":1228,"context_line":"        with inst.mutated_migration_context():"},{"line_number":1229,"context_line":"            self.assertIsInstance(inst.numa_topology,"},{"line_number":1230,"context_line":"                                  objects.InstanceNUMATopology)"},{"line_number":1231,"context_line":"        self.assertIs(numa_topology, inst.numa_topology)"},{"line_number":1232,"context_line":""},{"line_number":1233,"context_line":"    @mock.patch.object(objects.Instance, \u0027get_by_uuid\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a1a9d01_c6716ce2","line":1230,"in_reply_to":"9a1a9d01_fa64454a","updated":"2015-09-24 15:16:26.000000000","message":"yar actully will change this","commit_id":"995473e42423942cd3787ba51724720ff2eb09f3"}]}