)]}'
{"nova/virt/libvirt/driver.py":[{"author":{"_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},"change_message_id":"aba01bdd32f857ca10caada8fc548da5ea75a5d3","unresolved":false,"context_lines":[{"line_number":5898,"context_line":"                    ((progress_watermark \u003e info.data_remaining) and"},{"line_number":5899,"context_line":"                     (info.data_remaining \u003e 0))):"},{"line_number":5900,"context_line":"                    progress_watermark \u003d info.data_remaining"},{"line_number":5901,"context_line":"                    progress_time \u003d now"},{"line_number":5902,"context_line":""},{"line_number":5903,"context_line":"                if (progress_timeout !\u003d 0 and"},{"line_number":5904,"context_line":"                    (now - progress_time) \u003e progress_timeout):"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a1a9d01_42576802","line":5901,"updated":"2015-09-25 09:22:36.000000000","message":"Do we want to be not setting this? I am not sure TBH as this is really an edge case so it\u0027s probably OK.","commit_id":"5a051cc2b023f8ffb8b97bd07194f09609be1bd7"},{"author":{"_account_id":16839,"name":"Cale Rath","email":"ctrath@us.ibm.com","username":"ctrath"},"change_message_id":"016257cf3d4ac71e8d797d5c0c114697509468d4","unresolved":false,"context_lines":[{"line_number":5898,"context_line":"                    ((progress_watermark \u003e info.data_remaining) and"},{"line_number":5899,"context_line":"                     (info.data_remaining \u003e 0))):"},{"line_number":5900,"context_line":"                    progress_watermark \u003d info.data_remaining"},{"line_number":5901,"context_line":"                    progress_time \u003d now"},{"line_number":5902,"context_line":""},{"line_number":5903,"context_line":"                if (progress_timeout !\u003d 0 and"},{"line_number":5904,"context_line":"                    (now - progress_time) \u003e progress_timeout):"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a1a9d01_a2dd0d16","line":5901,"in_reply_to":"9a1a9d01_42576802","updated":"2015-09-25 18:50:30.000000000","message":"I\u0027m assuming you\u0027re referring to setting progress_time.  Yeah, it probably should still be set.  I\u0027ll upload an update.","commit_id":"5a051cc2b023f8ffb8b97bd07194f09609be1bd7"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"f06b5663a1c86813bb5395054de4a63abeb02b7a","unresolved":false,"context_lines":[{"line_number":5896,"context_line":""},{"line_number":5897,"context_line":"                if (progress_watermark is None or"},{"line_number":5898,"context_line":"                    progress_watermark \u003e info.data_remaining):"},{"line_number":5899,"context_line":"                    if info.data_remaining \u003e 0 or progress_watermark is None:"},{"line_number":5900,"context_line":"                        progress_watermark \u003d info.data_remaining"},{"line_number":5901,"context_line":"                    progress_time \u003d now"},{"line_number":5902,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9a1a9d01_344cc46f","line":5899,"updated":"2015-09-27 06:29:10.000000000","message":"can you please add in a unit test for this flow","commit_id":"a5515400987a9f7ab720fe3045da536dbaa66233"},{"author":{"_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},"change_message_id":"6d835eece1b3b7b4004672648e9dad5717f8b282","unresolved":false,"context_lines":[{"line_number":5897,"context_line":"                if (progress_watermark is None or"},{"line_number":5898,"context_line":"                    progress_watermark \u003e info.data_remaining):"},{"line_number":5899,"context_line":"                    if info.data_remaining \u003e 0 or progress_watermark is None:"},{"line_number":5900,"context_line":"                        progress_watermark \u003d info.data_remaining"},{"line_number":5901,"context_line":"                    else:"},{"line_number":5902,"context_line":"                        LOG.debug(\"Watermark not updated. data_remaining is 0\")"},{"line_number":5903,"context_line":"                    progress_time \u003d now"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a1a9d01_4bd53cb7","line":5900,"updated":"2015-10-02 09:46:17.000000000","message":"So with the change as it\u0027s enough for progress_watermark to be None set for us to set it to data_remaining, which puts us back to where we were :)","commit_id":"e0f3f5d3210cf2586b067d5f6626ccb8c0c2fbb9"},{"author":{"_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},"change_message_id":"e52a43e521e1503b30c19f5813e7d873aca4e8ea","unresolved":false,"context_lines":[{"line_number":5897,"context_line":"                if (progress_watermark is None or"},{"line_number":5898,"context_line":"                    progress_watermark \u003e info.data_remaining):"},{"line_number":5899,"context_line":"                    if info.data_remaining \u003e 0 or progress_watermark is None:"},{"line_number":5900,"context_line":"                        progress_watermark \u003d info.data_remaining"},{"line_number":5901,"context_line":"                    else:"},{"line_number":5902,"context_line":"                        LOG.debug(\"Watermark not updated. data_remaining is 0\")"},{"line_number":5903,"context_line":"                    progress_time \u003d now"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a2fa921_93036542","line":5900,"in_reply_to":"9a1a9d01_412661bb","updated":"2015-10-07 08:48:25.000000000","message":"so in case progress_watermark is None, we would would _still_ set progress_watermark to the value of info.data_remaining even if info.data_remaining is 0 because we use an or in the if statement guarding this.\n\nThat is the same as the behaviour we have now, right?","commit_id":"e0f3f5d3210cf2586b067d5f6626ccb8c0c2fbb9"},{"author":{"_account_id":16839,"name":"Cale Rath","email":"ctrath@us.ibm.com","username":"ctrath"},"change_message_id":"8d4fd495dc321c1ba455a197b21e65ed34155aed","unresolved":false,"context_lines":[{"line_number":5897,"context_line":"                if (progress_watermark is None or"},{"line_number":5898,"context_line":"                    progress_watermark \u003e info.data_remaining):"},{"line_number":5899,"context_line":"                    if info.data_remaining \u003e 0 or progress_watermark is None:"},{"line_number":5900,"context_line":"                        progress_watermark \u003d info.data_remaining"},{"line_number":5901,"context_line":"                    else:"},{"line_number":5902,"context_line":"                        LOG.debug(\"Watermark not updated. data_remaining is 0\")"},{"line_number":5903,"context_line":"                    progress_time \u003d now"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a1a9d01_412661bb","line":5900,"in_reply_to":"9a1a9d01_4bd53cb7","updated":"2015-10-02 21:17:21.000000000","message":"Nikola, I\u0027m trying to understand your comment.   Are you saying that we shouldn\u0027t be setting the watermark to 0 even if it\u0027s None and info.data_remaining is 0?","commit_id":"e0f3f5d3210cf2586b067d5f6626ccb8c0c2fbb9"}]}