)]}'
{"nova/objects/compute_node.py":[{"author":{"_account_id":9775,"name":"Sudipta Biswas","email":"sbiswas7@in.ibm.com","username":"sudswas"},"change_message_id":"0e81d9bd471d8009ec9c9c31be4dddb21d81d280","unresolved":false,"context_lines":[{"line_number":92,"context_line":"    def obj_make_compatible(self, primitive, target_version):"},{"line_number":93,"context_line":"        super(ComputeNode, self).obj_make_compatible(primitive, target_version)"},{"line_number":94,"context_line":"        target_version \u003d versionutils.convert_version_to_tuple(target_version)"},{"line_number":95,"context_line":"        if target_version \u003c (1, 15):"},{"line_number":96,"context_line":"            if \u0027host_capabilities\u0027 in primitive:"},{"line_number":97,"context_line":"                del primitive[\u0027host_capabilities\u0027]"},{"line_number":98,"context_line":"        if target_version \u003c (1, 14):"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa69d971_31d37606","line":95,"updated":"2016-01-04 11:08:53.000000000","message":"Assuming that only the \u0027host_capabilities\u0027 field is leading to the version bump, i guess line 95 and 96 can be combined using a short circuit operator?\n\nif target_version \u003c x and \u0027host_capabilities\u0027 in y:","commit_id":"acd0e3480c857113f44be19188b7a0c46b22803e"},{"author":{"_account_id":8213,"name":"Claudiu Belu","email":"cbelu@cloudbasesolutions.com","username":"claudiub"},"change_message_id":"b4855b2c8d5cca23d903fa6b8b00eac8da0a3e97","unresolved":false,"context_lines":[{"line_number":92,"context_line":"    def obj_make_compatible(self, primitive, target_version):"},{"line_number":93,"context_line":"        super(ComputeNode, self).obj_make_compatible(primitive, target_version)"},{"line_number":94,"context_line":"        target_version \u003d versionutils.convert_version_to_tuple(target_version)"},{"line_number":95,"context_line":"        if target_version \u003c (1, 15):"},{"line_number":96,"context_line":"            if \u0027host_capabilities\u0027 in primitive:"},{"line_number":97,"context_line":"                del primitive[\u0027host_capabilities\u0027]"},{"line_number":98,"context_line":"        if target_version \u003c (1, 14):"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a68dd71_430e83e6","line":95,"in_reply_to":"fa69d971_31d37606","updated":"2016-01-27 07:23:04.000000000","message":"Done","commit_id":"acd0e3480c857113f44be19188b7a0c46b22803e"},{"author":{"_account_id":9775,"name":"Sudipta Biswas","email":"sbiswas7@in.ibm.com","username":"sudswas"},"change_message_id":"0e81d9bd471d8009ec9c9c31be4dddb21d81d280","unresolved":false,"context_lines":[{"line_number":204,"context_line":"            compute[\u0027supported_hv_specs\u0027] \u003d hv_specs"},{"line_number":205,"context_line":""},{"line_number":206,"context_line":"        host_cap \u003d db_compute.get(\u0027host_capabilities\u0027)"},{"line_number":207,"context_line":"        compute.host_capabilities \u003d ("},{"line_number":208,"context_line":"            objects.HostCapabilities.from_host_capabilities(host_cap))"},{"line_number":209,"context_line":""},{"line_number":210,"context_line":"        pci_stats \u003d db_compute.get(\u0027pci_stats\u0027)"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa69d971_f1787ef4","line":207,"updated":"2016-01-04 11:08:53.000000000","message":"nit: \nif host_cap:\n    compute.host_capabilities \u003d xyz","commit_id":"acd0e3480c857113f44be19188b7a0c46b22803e"},{"author":{"_account_id":8213,"name":"Claudiu Belu","email":"cbelu@cloudbasesolutions.com","username":"claudiub"},"change_message_id":"b4855b2c8d5cca23d903fa6b8b00eac8da0a3e97","unresolved":false,"context_lines":[{"line_number":204,"context_line":"            compute[\u0027supported_hv_specs\u0027] \u003d hv_specs"},{"line_number":205,"context_line":""},{"line_number":206,"context_line":"        host_cap \u003d db_compute.get(\u0027host_capabilities\u0027)"},{"line_number":207,"context_line":"        compute.host_capabilities \u003d ("},{"line_number":208,"context_line":"            objects.HostCapabilities.from_host_capabilities(host_cap))"},{"line_number":209,"context_line":""},{"line_number":210,"context_line":"        pci_stats \u003d db_compute.get(\u0027pci_stats\u0027)"}],"source_content_type":"text/x-python","patch_set":7,"id":"9a68dd71_e3ed37f0","line":207,"in_reply_to":"fa69d971_f1787ef4","updated":"2016-01-27 07:23:04.000000000","message":"Done","commit_id":"acd0e3480c857113f44be19188b7a0c46b22803e"}]}