)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7156,"name":"Mathieu Gagné","email":"mgagne@calavera.ca","username":"mgagne"},"change_message_id":"67a6469db7dfadcf298f583fab5d8d44002c64cb","unresolved":false,"context_lines":[{"line_number":12,"context_line":"that every live-migration will be a block-migration and vice versa."},{"line_number":13,"context_line":"This doesn\u0027t make sense and is a misconfiguration."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Because some customers could already have configured their systems in"},{"line_number":16,"context_line":"this faulty way, this patch set logs a warning if it discovers this,"},{"line_number":17,"context_line":"instead of blocking the nova-compute service to come up."},{"line_number":18,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9a1a9d01_d7778fd2","line":15,"updated":"2015-10-02 23:10:36.000000000","message":"I fail to see why someone would want to continue having this faulty config which could cause data corruption and loss. Could this validation be done at startup and refuse to start otherwise?","commit_id":"8ecf93e88a1a6cc49fffc43a964fe49a37e70d24"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"a5cd4299858dcc5e0752b22c050df2e51c52361e","unresolved":false,"context_lines":[{"line_number":12,"context_line":"that every live-migration will be a block-migration and vice versa."},{"line_number":13,"context_line":"This doesn\u0027t make sense and is a misconfiguration."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Because some customers could already have configured their systems in"},{"line_number":16,"context_line":"this faulty way, this patch set logs a warning if it discovers this,"},{"line_number":17,"context_line":"instead of blocking the nova-compute service to come up."},{"line_number":18,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7a2fa921_303cae2e","line":15,"in_reply_to":"9a1a9d01_d7778fd2","updated":"2015-10-07 16:34:32.000000000","message":"@Mathieu Gagné: \nRefusing to start the service would be the hard way to notify the customer about that. I\u0027ve chosen the \"soft way\" of a warning to remain backwards compatible to their `nova.conf` in case of an upgrade of a compute node to prevent an interruption in the customer\u0027s setup. To answer your question:\n\n    \u003e Could this validation be done at startup and refuse\n    \u003e to start otherwise?\n\nYes, that\u0027s possible (that gets already done when an old libvirt version is detected), but I\u0027m hesitant to do so because of the reason mentioned above.","commit_id":"8ecf93e88a1a6cc49fffc43a964fe49a37e70d24"}],"nova/tests/unit/virt/libvirt/test_driver.py":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"774d27bc9cf21500fc7746c1fda6950d9a933f91","unresolved":false,"context_lines":[{"line_number":752,"context_line":"        drvr.init_host(\"dummyhost\")"},{"line_number":753,"context_line":""},{"line_number":754,"context_line":"        msg \u003d mock_log.warning.call_args_list[0]"},{"line_number":755,"context_line":"        self.assertIn(\u0027Running Nova with a live_migration_flag\u0027, msg[0][0])"},{"line_number":756,"context_line":"        msg \u003d mock_log.warning.call_args_list[1]"},{"line_number":757,"context_line":"        self.assertIn(\u0027Running Nova with a block_migration_flag\u0027, msg[0][0])"},{"line_number":758,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"ba8a016a_95e24900","line":755,"updated":"2015-11-23 15:41:08.000000000","message":"I have a slight worry about unit tests and localizations, but I can\u0027t think of a better idea.","commit_id":"8ecf93e88a1a6cc49fffc43a964fe49a37e70d24"}],"nova/virt/libvirt/driver.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"254d0192814d1928548c8151ae29f21154db9df2","unresolved":false,"context_lines":[{"line_number":615,"context_line":"    def _do_migration_flag_warnings(self):"},{"line_number":616,"context_line":"        block_migration_flag \u003d \u0027VIR_MIGRATE_NON_SHARED_INC\u0027"},{"line_number":617,"context_line":"        if block_migration_flag in CONF.libvirt.live_migration_flag:"},{"line_number":618,"context_line":"            LOG.warning(_LW(\u0027Running Nova with a live_migration_flag config\u0027"},{"line_number":619,"context_line":"                            \u0027option which contains %(flag)s \u0027"},{"line_number":620,"context_line":"                            \u0027will cause all live-migrations to be block-\u0027"},{"line_number":621,"context_line":"                            \u0027migrations instead. This setting should only be \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a1a9d01_785506f8","line":618,"updated":"2015-09-29 11:49:34.000000000","message":"missing space at the end of the line","commit_id":"d6e57f57704d8582c977458c4a3d90322ae3c9be"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"8dbfbb5a4d51c20338b0a75ed7dd4a26600afae1","unresolved":false,"context_lines":[{"line_number":615,"context_line":"    def _do_migration_flag_warnings(self):"},{"line_number":616,"context_line":"        block_migration_flag \u003d \u0027VIR_MIGRATE_NON_SHARED_INC\u0027"},{"line_number":617,"context_line":"        if block_migration_flag in CONF.libvirt.live_migration_flag:"},{"line_number":618,"context_line":"            LOG.warning(_LW(\u0027Running Nova with a live_migration_flag config\u0027"},{"line_number":619,"context_line":"                            \u0027option which contains %(flag)s \u0027"},{"line_number":620,"context_line":"                            \u0027will cause all live-migrations to be block-\u0027"},{"line_number":621,"context_line":"                            \u0027migrations instead. This setting should only be \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a1a9d01_16fffbaa","line":618,"in_reply_to":"9a1a9d01_785506f8","updated":"2015-09-29 13:20:54.000000000","message":"Done","commit_id":"d6e57f57704d8582c977458c4a3d90322ae3c9be"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"254d0192814d1928548c8151ae29f21154db9df2","unresolved":false,"context_lines":[{"line_number":622,"context_line":"                            \u0027on the block_migration_flag instead.\u0027),"},{"line_number":623,"context_line":"                        {\u0027flag\u0027: block_migration_flag})"},{"line_number":624,"context_line":"        if block_migration_flag not in CONF.libvirt.block_migration_flag:"},{"line_number":625,"context_line":"            LOG.warning(_LW(\u0027Running Nova with a block_migration_flag config\u0027"},{"line_number":626,"context_line":"                            \u0027option which does not contain %(flag)s \u0027"},{"line_number":627,"context_line":"                            \u0027will cause all block-migrations to be live-\u0027"},{"line_number":628,"context_line":"                            \u0027migrations instead. This setting should be \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a1a9d01_58412237","line":625,"updated":"2015-09-29 11:49:34.000000000","message":"missing space at the end of the line","commit_id":"d6e57f57704d8582c977458c4a3d90322ae3c9be"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"8dbfbb5a4d51c20338b0a75ed7dd4a26600afae1","unresolved":false,"context_lines":[{"line_number":622,"context_line":"                            \u0027on the block_migration_flag instead.\u0027),"},{"line_number":623,"context_line":"                        {\u0027flag\u0027: block_migration_flag})"},{"line_number":624,"context_line":"        if block_migration_flag not in CONF.libvirt.block_migration_flag:"},{"line_number":625,"context_line":"            LOG.warning(_LW(\u0027Running Nova with a block_migration_flag config\u0027"},{"line_number":626,"context_line":"                            \u0027option which does not contain %(flag)s \u0027"},{"line_number":627,"context_line":"                            \u0027will cause all block-migrations to be live-\u0027"},{"line_number":628,"context_line":"                            \u0027migrations instead. This setting should be \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a1a9d01_b62e4f41","line":625,"in_reply_to":"9a1a9d01_58412237","updated":"2015-09-29 13:20:54.000000000","message":"Done","commit_id":"d6e57f57704d8582c977458c4a3d90322ae3c9be"}]}