)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"7a7c8efa2cfdaf187b4b1c9ad5d8c2f25edc1e5a","unresolved":false,"context_lines":[{"line_number":10,"context_line":"from the set of uuids passed in the scheduler hint \u0027same_host\u0027. However,"},{"line_number":11,"context_line":"it passes also if the host does not have any instance."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Fixes-Bug: #1500920"},{"line_number":14,"context_line":"Change-Id: I9e65fd1153a5e33c676890ab3e562e464f9ff625"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9a1a9d01_e455dac1","line":13,"updated":"2015-09-29 21:12:41.000000000","message":"Closes-Bug\n\nhttp://docs.openstack.org/infra/manual/developers.html#working-on-bugs","commit_id":"a49e3b932367749e8788f11c178b9e5bcbeffcb7"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"9960e355bce724fde9367f3606b57105c4e61246","unresolved":false,"context_lines":[{"line_number":10,"context_line":"from the set of uuids passed in the scheduler hint \u0027same_host\u0027. However,"},{"line_number":11,"context_line":"it passes also if the host does not have any instance."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Fixes-Bug: #1500920"},{"line_number":14,"context_line":"Change-Id: I9e65fd1153a5e33c676890ab3e562e464f9ff625"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9a1a9d01_2fd2cb5c","line":13,"in_reply_to":"9a1a9d01_04d48eba","updated":"2015-09-29 21:44:09.000000000","message":"maybe a little bit aggressive here\nplease refer to the link I listed above...","commit_id":"a49e3b932367749e8788f11c178b9e5bcbeffcb7"},{"author":{"_account_id":91,"name":"Alvaro","email":"aloga@ifca.unican.es","username":"aloga"},"change_message_id":"b995a11c92742dc67db5ff63c40373f5c22f7ae4","unresolved":false,"context_lines":[{"line_number":10,"context_line":"from the set of uuids passed in the scheduler hint \u0027same_host\u0027. However,"},{"line_number":11,"context_line":"it passes also if the host does not have any instance."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Fixes-Bug: #1500920"},{"line_number":14,"context_line":"Change-Id: I9e65fd1153a5e33c676890ab3e562e464f9ff625"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9a1a9d01_04d48eba","line":13,"in_reply_to":"9a1a9d01_e455dac1","updated":"2015-09-29 21:24:16.000000000","message":"IIRC \"fixes-bug\", \"fixes bug\" and \"closes-bug\" are equivalent.","commit_id":"a49e3b932367749e8788f11c178b9e5bcbeffcb7"}],"nova/scheduler/filters/affinity_filter.py":[{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"7a7c8efa2cfdaf187b4b1c9ad5d8c2f25edc1e5a","unresolved":false,"context_lines":[{"line_number":60,"context_line":"                return overlap"},{"line_number":61,"context_line":"            # No instances on host, we should fail"},{"line_number":62,"context_line":"            return False"},{"line_number":63,"context_line":"        # With no same_host key or no instances"},{"line_number":64,"context_line":"        return True"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9a1a9d01_6418ea1e","line":63,"updated":"2015-09-29 21:12:41.000000000","message":"this comment need update?","commit_id":"a49e3b932367749e8788f11c178b9e5bcbeffcb7"},{"author":{"_account_id":91,"name":"Alvaro","email":"aloga@ifca.unican.es","username":"aloga"},"change_message_id":"28a3400eab94f916a68011247cc694eff6bf0055","unresolved":false,"context_lines":[{"line_number":60,"context_line":"                return overlap"},{"line_number":61,"context_line":"            # No instances on host, we should fail"},{"line_number":62,"context_line":"            return False"},{"line_number":63,"context_line":"        # With no same_host key or no instances"},{"line_number":64,"context_line":"        return True"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9a1a9d01_affa5b73","line":63,"in_reply_to":"9a1a9d01_0f5b47f7","updated":"2015-09-29 21:51:25.000000000","message":"The comment refers to the fact that same_host can be unset or that same_host can be empty.","commit_id":"a49e3b932367749e8788f11c178b9e5bcbeffcb7"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"9960e355bce724fde9367f3606b57105c4e61246","unresolved":false,"context_lines":[{"line_number":60,"context_line":"                return overlap"},{"line_number":61,"context_line":"            # No instances on host, we should fail"},{"line_number":62,"context_line":"            return False"},{"line_number":63,"context_line":"        # With no same_host key or no instances"},{"line_number":64,"context_line":"        return True"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9a1a9d01_0f5b47f7","line":63,"in_reply_to":"9a1a9d01_242d12fe","updated":"2015-09-29 21:44:09.000000000","message":"if you compare the comment with previous code\nit exactly describe the logic, I think if you change the logic\nthe comment should be consider to update\nbecause no instance doesn\u0027t affect whether code will go to here","commit_id":"a49e3b932367749e8788f11c178b9e5bcbeffcb7"},{"author":{"_account_id":91,"name":"Alvaro","email":"aloga@ifca.unican.es","username":"aloga"},"change_message_id":"b995a11c92742dc67db5ff63c40373f5c22f7ae4","unresolved":false,"context_lines":[{"line_number":60,"context_line":"                return overlap"},{"line_number":61,"context_line":"            # No instances on host, we should fail"},{"line_number":62,"context_line":"            return False"},{"line_number":63,"context_line":"        # With no same_host key or no instances"},{"line_number":64,"context_line":"        return True"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9a1a9d01_242d12fe","line":63,"in_reply_to":"9a1a9d01_6418ea1e","updated":"2015-09-29 21:24:16.000000000","message":"No, it doesn\u0027t, I guess. I think that it refers to the instances present in the same_host hint (i.e. same_host is not passed, or same_host\u003d[])","commit_id":"a49e3b932367749e8788f11c178b9e5bcbeffcb7"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"04aa662d0ae62b375bf69f5f562ee0885ea676e2","unresolved":false,"context_lines":[{"line_number":56,"context_line":"        if affinity_uuids:"},{"line_number":57,"context_line":"            overlap \u003d utils.instance_uuids_overlap(host_state, affinity_uuids)"},{"line_number":58,"context_line":"            return overlap"},{"line_number":59,"context_line":"        # With no same_host key or no instances"},{"line_number":60,"context_line":"        return True"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9a1a9d01_c2298f8b","line":59,"updated":"2015-09-30 12:14:55.000000000","message":"sorry, but I still think we need update comments here...","commit_id":"ad4b04918b4bc09ca903c2d1ed1f76cbb2855bfc"}],"nova/tests/unit/scheduler/filters/test_affinity_filters.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"8f2db48d0abe094a0bcd194e86b799789b7c0c37","unresolved":false,"context_lines":[{"line_number":85,"context_line":"        filter_properties \u003d {\u0027context\u0027: mock.sentinel.ctx,"},{"line_number":86,"context_line":"                             \u0027scheduler_hints\u0027: {"},{"line_number":87,"context_line":"                                 \u0027same_host\u0027: \u0027same\u0027}}"},{"line_number":88,"context_line":"        self.assertFalse(self.filt_cls.host_passes(host, filter_properties))"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    def test_affinity_same_filter_fails(self):"},{"line_number":91,"context_line":"        inst1 \u003d objects.Instance(uuid\u003d\u0027different\u0027)"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba8a016a_c32266a3","line":88,"updated":"2015-11-23 13:34:06.000000000","message":"I guess instead of this test code change, now we need two separate test cases to cover the new code. One is where there is no hint, and the other where there is no instance.\n\nAlso you might want to consider adding a functional test to cover the behavior change in the API","commit_id":"3a977bdc166242dd5104856c66e988ada5595543"},{"author":{"_account_id":91,"name":"Alvaro","email":"aloga@ifca.unican.es","username":"aloga"},"change_message_id":"8f78a4f17f32d1046ee8126648ac7c2e3d3c85ce","unresolved":false,"context_lines":[{"line_number":85,"context_line":"        filter_properties \u003d {\u0027context\u0027: mock.sentinel.ctx,"},{"line_number":86,"context_line":"                             \u0027scheduler_hints\u0027: {"},{"line_number":87,"context_line":"                                 \u0027same_host\u0027: \u0027same\u0027}}"},{"line_number":88,"context_line":"        self.assertFalse(self.filt_cls.host_passes(host, filter_properties))"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    def test_affinity_same_filter_fails(self):"},{"line_number":91,"context_line":"        inst1 \u003d objects.Instance(uuid\u003d\u0027different\u0027)"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a8ffd7b_751105ac","line":88,"in_reply_to":"ba8a016a_c32266a3","updated":"2015-11-30 12:02:20.000000000","message":"The no hint is tested in line 99: test_affinity_same_filter_handles_none","commit_id":"3a977bdc166242dd5104856c66e988ada5595543"}]}