)]}'
{"nova/objects/service.py":[{"author":{"_account_id":17139,"name":"Chuck Carmack","email":"carmack@us.ibm.com","username":"ccarmack"},"change_message_id":"a023c84f2170aa46c0638acd11d4ec0b64d6f1f5","unresolved":false,"context_lines":[{"line_number":251,"context_line":"            return"},{"line_number":252,"context_line":"        minver \u003d self.get_minimum_version(self._context, self.binary)"},{"line_number":253,"context_line":"        if minver \u003e self.version:"},{"line_number":254,"context_line":"            raise exception.ServiceTooOld()"},{"line_number":255,"context_line":""},{"line_number":256,"context_line":"    @base.remotable"},{"line_number":257,"context_line":"    def create(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a1a9d01_7140af34","line":254,"updated":"2015-09-29 18:42:42.000000000","message":"Would it be better for the message to include the service name, the service version, and the minimum version?  This might help in cases where services are started in script, such as stack.sh.","commit_id":"f7b4e1a2ba4f3093bb0456e7dab91f18c5485771"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"a6cf024050e41ab935b7960325e596db26c2682a","unresolved":false,"context_lines":[{"line_number":251,"context_line":"            return"},{"line_number":252,"context_line":"        minver \u003d self.get_minimum_version(self._context, self.binary)"},{"line_number":253,"context_line":"        if minver \u003e self.version:"},{"line_number":254,"context_line":"            raise exception.ServiceTooOld()"},{"line_number":255,"context_line":""},{"line_number":256,"context_line":"    @base.remotable"},{"line_number":257,"context_line":"    def create(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a1a9d01_982fa387","line":254,"in_reply_to":"9a1a9d01_7140af34","updated":"2015-09-29 19:24:22.000000000","message":"well, they\u0027re either logged to named files or with a service name in syslog. However, the versions are a good idea. That would require tweaking the exception class which isn\u0027t added here, so I can do that in a separate patch.","commit_id":"f7b4e1a2ba4f3093bb0456e7dab91f18c5485771"},{"author":{"_account_id":17139,"name":"Chuck Carmack","email":"carmack@us.ibm.com","username":"ccarmack"},"change_message_id":"32f0ddb66ad0ef4d87692925012ffb098ca16b91","unresolved":false,"context_lines":[{"line_number":251,"context_line":"            return"},{"line_number":252,"context_line":"        minver \u003d self.get_minimum_version(self._context, self.binary)"},{"line_number":253,"context_line":"        if minver \u003e self.version:"},{"line_number":254,"context_line":"            raise exception.ServiceTooOld()"},{"line_number":255,"context_line":""},{"line_number":256,"context_line":"    @base.remotable"},{"line_number":257,"context_line":"    def create(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a1a9d01_bb15c140","line":254,"in_reply_to":"9a1a9d01_982fa387","updated":"2015-09-29 19:49:30.000000000","message":"Thanks for the explanation.  I was thinking of the output of the CLIs rather than the logs, such as nova-scheduler.   I don\u0027t know the code, so maybe that\u0027s not relevant.","commit_id":"f7b4e1a2ba4f3093bb0456e7dab91f18c5485771"}]}
