)]}'
{"nova/tests/test_powervm.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"b3db03feb18cb285a170f3f1296157ae6733b6f7","unresolved":false,"context_lines":[{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    def __init__(self):"},{"line_number":50,"context_line":"        pass"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    def get_lpar(self, instance_name, resource_type\u003d\u0027lpar\u0027):"},{"line_number":53,"context_line":"        return fake_lpar(instance_name)"},{"line_number":54,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAM3%2F%2BlsM%3D","line":51,"updated":"2013-02-26 16:49:54.000000000","message":"What\u0027s this?","commit_id":"32efced640434e75710f322ffa6e308909cbe170"}],"nova/virt/powervm/exception.py":[{"author":{"_account_id":4601,"name":"Tiago Mello","email":"tmello@linux.vnet.ibm.com","username":"tmello"},"change_message_id":"7f5746aabb630f7cbcd051226c864ca8095e3ce4","unresolved":false,"context_lines":[{"line_number":71,"context_line":"class PowerVMMissingRequiredConfigOptions(exception.NovaException):"},{"line_number":72,"context_line":"    message \u003d _(\"Required configuration options are not set. Verify \""},{"line_number":73,"context_line":"                \"powervm_img_remote_path and powervm_img_local_path \""},{"line_number":74,"context_line":"                \"are set with valid unix path\")"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAM3%2F%2BlYY%3D","line":74,"updated":"2013-02-26 18:53:23.000000000","message":"Although the exception class name is generic, the message is very specific to the powervm_img_remote_path and powervm_img_local_path. It would nice to pass the required options as parameters.","commit_id":"9de341df656b384ca442e534ae5fd649ca5b4867"}],"nova/virt/powervm/operator.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"b3db03feb18cb285a170f3f1296157ae6733b6f7","unresolved":false,"context_lines":[{"line_number":69,"context_line":""},{"line_number":70,"context_line":"        if local_path is None or remote_path is None:"},{"line_number":71,"context_line":"            raise exception.PowerVMMissingRequiredConfigOptions()"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    def get_info(self, instance_name):"},{"line_number":74,"context_line":"        \"\"\"Get the current status of an LPAR instance."},{"line_number":75,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAM3%2F%2BlsE%3D","line":72,"updated":"2013-02-26 16:49:54.000000000","message":"This needs tests.","commit_id":"32efced640434e75710f322ffa6e308909cbe170"},{"author":{"_account_id":4601,"name":"Tiago Mello","email":"tmello@linux.vnet.ibm.com","username":"tmello"},"change_message_id":"7f5746aabb630f7cbcd051226c864ca8095e3ce4","unresolved":false,"context_lines":[{"line_number":67,"context_line":"        local_path \u003d CONF.powervm_img_local_path"},{"line_number":68,"context_line":"        remote_path \u003d CONF.powervm_img_remote_path"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"        if local_path is None or remote_path is None:"},{"line_number":71,"context_line":"            raise exception.PowerVMMissingRequiredConfigOptions()"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    def get_info(self, instance_name):"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAM3%2F%2BlYM%3D","line":70,"updated":"2013-02-26 18:53:23.000000000","message":"It will fail anyway if the local/remote path are invalid, won\u0027t it?","commit_id":"9de341df656b384ca442e534ae5fd649ca5b4867"}]}