)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16237,"name":"venkatamahesh","email":"venkatamaheshkotha@gmail.com","username":"venkatamahesh"},"change_message_id":"379cf5114d34540f6b05afed257b4f5ea84363ed","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2015-09-30 17:16:30 +0530"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Partial-Bug: #1494374"},{"line_number":8,"context_line":"nova.virt.libvirt.driver._get_guest_config method is nearly 400 LOC and should be broken up"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"Change-Id: Id741dfc769c02a5544691a7db49a7dbff6b11376"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9a1a9d01_e7cdc531","line":8,"updated":"2015-09-30 12:07:38.000000000","message":"In the commit message, title should be in text sentence. and then\nleave a line gap and write description of changes and then put \"Partial-Bug: #1494374\". For further reference \"https://wiki.openstack.org/wiki/GitCommitMessages#Summary_of_Git_commit_message_structure\"","commit_id":"f51bad86e2e494ce65ee34828b0f93b017482afb"},{"author":{"_account_id":15950,"name":"Ukesh Kumar","email":"ukeshkumar@gmail.com","username":"ukeshkumar"},"change_message_id":"19e9f8345101d95e0b8cd2bdec79d3384dc61311","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2015-09-30 17:16:30 +0530"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Partial-Bug: #1494374"},{"line_number":8,"context_line":"nova.virt.libvirt.driver._get_guest_config method is nearly 400 LOC and should be broken up"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"Change-Id: Id741dfc769c02a5544691a7db49a7dbff6b11376"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7a2fa921_0e73df81","line":8,"in_reply_to":"9a1a9d01_e7cdc531","updated":"2015-10-08 08:45:16.000000000","message":"Done","commit_id":"f51bad86e2e494ce65ee34828b0f93b017482afb"},{"author":{"_account_id":16907,"name":"Diana Clarke","email":"diana.joan.clarke@gmail.com","username":"diana-clarke"},"change_message_id":"f3e120a191c6de9add41963f42f05fdbb8d623ca","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Ukesh Kumar \u003cukeshkumar@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-10-06 08:51:38 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"nova.virt.libvirt.driver._get_guest_config method is nearly 400 LOC and should be broken up"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Splited _get_guest_config method into two for now. Planned to fix it in multiple-fix"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7a2fa921_8bc0e8e1","line":7,"updated":"2015-10-07 21:20:09.000000000","message":"According to the OpenStack dev guide, the first line of a commit message should be a \"short 50 character or less summary\". This line is 90+ characters.\n\nhttp://docs.openstack.org/infra/manual/developers.html#committing-a-change","commit_id":"ef41b999586dfdf334945f7ad801c8ab851cd0a8"},{"author":{"_account_id":15950,"name":"Ukesh Kumar","email":"ukeshkumar@gmail.com","username":"ukeshkumar"},"change_message_id":"e0651f350f6db2b4a7d7dead9e6e925898dcc308","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Ukesh Kumar \u003cukeshkumar@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-10-06 08:51:38 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"nova.virt.libvirt.driver._get_guest_config method is nearly 400 LOC and should be broken up"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Splited _get_guest_config method into two for now. Planned to fix it in multiple-fix"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7a2fa921_260d3be8","line":7,"in_reply_to":"7a2fa921_8bc0e8e1","updated":"2015-10-08 08:45:00.000000000","message":"Done","commit_id":"ef41b999586dfdf334945f7ad801c8ab851cd0a8"},{"author":{"_account_id":16907,"name":"Diana Clarke","email":"diana.joan.clarke@gmail.com","username":"diana-clarke"},"change_message_id":"f3e120a191c6de9add41963f42f05fdbb8d623ca","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"nova.virt.libvirt.driver._get_guest_config method is nearly 400 LOC and should be broken up"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Splited _get_guest_config method into two for now. Planned to fix it in multiple-fix"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Partial-Bug: #1494374"},{"line_number":12,"context_line":"Change-Id: Id741dfc769c02a5544691a7db49a7dbff6b11376"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7a2fa921_2b3c34e1","line":9,"updated":"2015-10-07 21:20:09.000000000","message":"And the subsequent lines should be wrapped at 72 characters, though I don\u0027t know how strictly this is enforced. This line is 80+ characters.\n\nA detailed description of the ideal commit message format can be found here: https://wiki.openstack.org/wiki/GitCommitMessages#Summary_of_Git_commit_message_structure","commit_id":"ef41b999586dfdf334945f7ad801c8ab851cd0a8"},{"author":{"_account_id":15950,"name":"Ukesh Kumar","email":"ukeshkumar@gmail.com","username":"ukeshkumar"},"change_message_id":"e0651f350f6db2b4a7d7dead9e6e925898dcc308","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"nova.virt.libvirt.driver._get_guest_config method is nearly 400 LOC and should be broken up"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Splited _get_guest_config method into two for now. Planned to fix it in multiple-fix"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Partial-Bug: #1494374"},{"line_number":12,"context_line":"Change-Id: Id741dfc769c02a5544691a7db49a7dbff6b11376"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7a2fa921_e6fbc3bf","line":9,"in_reply_to":"7a2fa921_2b3c34e1","updated":"2015-10-08 08:45:00.000000000","message":"Done","commit_id":"ef41b999586dfdf334945f7ad801c8ab851cd0a8"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"d07e06502e35aa527ea1cba6bf5ca9fd74ae7447","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Ukesh Kumar \u003cukeshkumar@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-10-08 07:20:46 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"nova.../driver/_get_guest_config method broken up"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Splited _get_guest_config method into two for now."},{"line_number":10,"context_line":"Planned to fix it in multiple-fix"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7a2fa921_c6d18e24","line":7,"updated":"2015-10-09 17:31:26.000000000","message":"Neither this commit summary or the commit message itself is very useful. Try to describe what specifically is being done in the patch and why.\n\nHow about something like this instead?\n\n Move watchdog device handling out of _get_guest_config\n \n This patch series reduces the length and complexity of the\n _get_guest_config() method in the libvirt driver.py module. The\n first step is to pull the watchdog device handling into its own method.","commit_id":"bf0ac2c42e8398cabffaaa2f0a6d455dd5244553"},{"author":{"_account_id":15950,"name":"Ukesh Kumar","email":"ukeshkumar@gmail.com","username":"ukeshkumar"},"change_message_id":"de1f31244730234317d87f12177109f81d05227e","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Ukesh Kumar \u003cukeshkumar@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-10-08 07:20:46 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"nova.../driver/_get_guest_config method broken up"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Splited _get_guest_config method into two for now."},{"line_number":10,"context_line":"Planned to fix it in multiple-fix"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7a2fa921_0b1ae317","line":7,"in_reply_to":"7a2fa921_c6d18e24","updated":"2015-10-13 01:25:22.000000000","message":"Done","commit_id":"bf0ac2c42e8398cabffaaa2f0a6d455dd5244553"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"d07e06502e35aa527ea1cba6bf5ca9fd74ae7447","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"nova.../driver/_get_guest_config method broken up"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Splited _get_guest_config method into two for now."},{"line_number":10,"context_line":"Planned to fix it in multiple-fix"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Partial-Bug: #1494374"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7a2fa921_469edeb9","line":9,"updated":"2015-10-09 17:31:26.000000000","message":"s/Splited/Splits/","commit_id":"bf0ac2c42e8398cabffaaa2f0a6d455dd5244553"},{"author":{"_account_id":15950,"name":"Ukesh Kumar","email":"ukeshkumar@gmail.com","username":"ukeshkumar"},"change_message_id":"de1f31244730234317d87f12177109f81d05227e","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"nova.../driver/_get_guest_config method broken up"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Splited _get_guest_config method into two for now."},{"line_number":10,"context_line":"Planned to fix it in multiple-fix"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Partial-Bug: #1494374"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7a2fa921_ebd76721","line":9,"in_reply_to":"7a2fa921_469edeb9","updated":"2015-10-13 01:25:22.000000000","message":"Done","commit_id":"bf0ac2c42e8398cabffaaa2f0a6d455dd5244553"}],"nova/virt/libvirt/driver.py":[{"author":{"_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},"change_message_id":"29cd538ba623b4bd8095385881c0653f44bead19","unresolved":false,"context_lines":[{"line_number":3898,"context_line":"            video.vram \u003d video_ram * units.Mi / units.Ki"},{"line_number":3899,"context_line":"        guest.add_device(video)"},{"line_number":3900,"context_line":""},{"line_number":3901,"context_line":"    def _add_watchdog_device(self, guest, instance, image_meta, flavor):"},{"line_number":3902,"context_line":"        if \u0027hw_watchdog_action\u0027 in flavor.extra_specs:"},{"line_number":3903,"context_line":"            LOG.warn(_LW(\u0027Old property name \"hw_watchdog_action\" is now \u0027"},{"line_number":3904,"context_line":"                         \u0027deprecated and will be removed in the next release. \u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a2ca52d_350da337","line":3901,"updated":"2015-10-14 16:19:02.000000000","message":"We could also do something similar to what was done with the Guest class https://review.openstack.org/#/c/174313 and move these out into a separate class/module that transforms Instance objects to libvirt config objects.\n\nI am ok but slightly unimpressed by this. it\u0027s easier to test sure but also more difficult to read.","commit_id":"bf0ac2c42e8398cabffaaa2f0a6d455dd5244553"}]}