)]}'
{"nova/virt/hardware.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"6111928394519980248c2695f924ea57a2de4139","unresolved":false,"context_lines":[{"line_number":730,"context_line":""},{"line_number":731,"context_line":"    if host_cell.siblings:"},{"line_number":732,"context_line":"        # Try to pack the instance cell in one core"},{"line_number":733,"context_line":"        largest_free_sibling_set \u003d sorted("},{"line_number":734,"context_line":"            host_cell.free_siblings, key\u003dlen)[-1]"},{"line_number":735,"context_line":"        if len(instance_cell.cpuset) \u003c\u003d len(largest_free_sibling_set):"},{"line_number":736,"context_line":"            return _pack_instance_onto_cores("}],"source_content_type":"text/x-python","patch_set":6,"id":"9a8ffd7b_c7b53ded","line":733,"updated":"2015-12-02 22:19:30.000000000","message":"We already attempt to pack into the largest free set of sibling and then work down from there all the way to n single sibling (L698 above). This seems superfluous.","commit_id":"a9d78284d96af45d612103d1bdf4f9b0e2181ad4"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"4a5e82f20a9c5333b7ab90e8aebd31336d0a8c62","unresolved":false,"context_lines":[{"line_number":730,"context_line":""},{"line_number":731,"context_line":"    if host_cell.siblings:"},{"line_number":732,"context_line":"        # Try to pack the instance cell in one core"},{"line_number":733,"context_line":"        largest_free_sibling_set \u003d sorted("},{"line_number":734,"context_line":"            host_cell.free_siblings, key\u003dlen)[-1]"},{"line_number":735,"context_line":"        if len(instance_cell.cpuset) \u003c\u003d len(largest_free_sibling_set):"},{"line_number":736,"context_line":"            return _pack_instance_onto_cores("}],"source_content_type":"text/x-python","patch_set":6,"id":"7a740942_78260e18","line":733,"in_reply_to":"7a740942_28f2779b","updated":"2015-12-03 16:56:46.000000000","message":"That\u0027s fair","commit_id":"a9d78284d96af45d612103d1bdf4f9b0e2181ad4"},{"author":{"_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},"change_message_id":"42dd3b524ef205e866fc5707a9dec44924f014de","unresolved":false,"context_lines":[{"line_number":730,"context_line":""},{"line_number":731,"context_line":"    if host_cell.siblings:"},{"line_number":732,"context_line":"        # Try to pack the instance cell in one core"},{"line_number":733,"context_line":"        largest_free_sibling_set \u003d sorted("},{"line_number":734,"context_line":"            host_cell.free_siblings, key\u003dlen)[-1]"},{"line_number":735,"context_line":"        if len(instance_cell.cpuset) \u003c\u003d len(largest_free_sibling_set):"},{"line_number":736,"context_line":"            return _pack_instance_onto_cores("}],"source_content_type":"text/x-python","patch_set":6,"id":"7a740942_28f2779b","line":733,"in_reply_to":"7a740942_ee3b1f9b","updated":"2015-12-03 16:19:15.000000000","message":"Actually I can\u0027t fix it in this patch because the bug I fix in the next patch will affect the way we calculate the cpu topology. I can however remove it in the next patch which I am going to do.\n\nstill a good catch though","commit_id":"a9d78284d96af45d612103d1bdf4f9b0e2181ad4"},{"author":{"_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},"change_message_id":"4b62a39075eafe91654a45f1669c4cf42aaa420e","unresolved":false,"context_lines":[{"line_number":730,"context_line":""},{"line_number":731,"context_line":"    if host_cell.siblings:"},{"line_number":732,"context_line":"        # Try to pack the instance cell in one core"},{"line_number":733,"context_line":"        largest_free_sibling_set \u003d sorted("},{"line_number":734,"context_line":"            host_cell.free_siblings, key\u003dlen)[-1]"},{"line_number":735,"context_line":"        if len(instance_cell.cpuset) \u003c\u003d len(largest_free_sibling_set):"},{"line_number":736,"context_line":"            return _pack_instance_onto_cores("}],"source_content_type":"text/x-python","patch_set":6,"id":"7a740942_ee3b1f9b","line":733,"in_reply_to":"9a8ffd7b_c7b53ded","updated":"2015-12-03 14:59:57.000000000","message":"Yeah nice catch!","commit_id":"a9d78284d96af45d612103d1bdf4f9b0e2181ad4"}]}