)]}'
{"nova/objects/fields.py":[{"author":{"_account_id":16929,"name":"Giridhar Jayavelu","email":"gjayavelu@vmware.com","username":"gjayavelu"},"change_message_id":"61fcc07c6dd5e6d9833a5c20117ad082c6f8d7d2","unresolved":false,"context_lines":[{"line_number":431,"context_line":"    LVM \u003d \"lvm\""},{"line_number":432,"context_line":"    QCOW2 \u003d \"qcow2\""},{"line_number":433,"context_line":"    RAW \u003d \"raw\""},{"line_number":434,"context_line":"    PLOOP \u003d \"ploop\""},{"line_number":435,"context_line":""},{"line_number":436,"context_line":"    ALL \u003d (RBD, LVM, QCOW2, RAW, PLOOP)"},{"line_number":437,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9a1a9d01_8ff85b4b","line":434,"updated":"2015-10-01 18:05:02.000000000","message":"don\u0027t we need iso, vhd, ari, aki, vmdk as well?\nplease ensure all supported formats are covered or I guess we could leave it to drivers to catch for unsupported formats.","commit_id":"9343c075496427c1cbea3c5dae4823b7ae989d90"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"75ec219e33fdd606e63eeb77da982cb5e11afa0b","unresolved":false,"context_lines":[{"line_number":431,"context_line":"    LVM \u003d \"lvm\""},{"line_number":432,"context_line":"    QCOW2 \u003d \"qcow2\""},{"line_number":433,"context_line":"    RAW \u003d \"raw\""},{"line_number":434,"context_line":"    PLOOP \u003d \"ploop\""},{"line_number":435,"context_line":""},{"line_number":436,"context_line":"    ALL \u003d (RBD, LVM, QCOW2, RAW, PLOOP)"},{"line_number":437,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9a1a9d01_06ff3b35","line":434,"in_reply_to":"9a1a9d01_8ff85b4b","updated":"2015-10-02 10:08:52.000000000","message":"will update it ,thx","commit_id":"9343c075496427c1cbea3c5dae4823b7ae989d90"},{"author":{"_account_id":11803,"name":"Ryan Rossiter","email":"rlrossit@us.ibm.com","username":"rlrossiter"},"change_message_id":"5241c8eb2ca13be1995b29fadaec50db71fa376c","unresolved":false,"context_lines":[{"line_number":427,"context_line":""},{"line_number":428,"context_line":""},{"line_number":429,"context_line":"class DiskFormat(Enum):"},{"line_number":430,"context_line":"    RBD \u003d \"rbd\""},{"line_number":431,"context_line":"    LVM \u003d \"lvm\""},{"line_number":432,"context_line":"    QCOW2 \u003d \"qcow2\""},{"line_number":433,"context_line":"    RAW \u003d \"raw\""}],"source_content_type":"text/x-python","patch_set":4,"id":"da85f559_0392104c","line":430,"updated":"2015-11-12 15:00:01.000000000","message":"In Ic7ee6d2beef0935e2d28e7fdbfe191ed776ae748 you add a NONE variable. You should do that in this change when you add the enum.","commit_id":"bd6c8ff84dde379a473c7fced88e6a24c951f3fa"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"4b888c0bfdc730728b3eb93f41673113aad49230","unresolved":false,"context_lines":[{"line_number":427,"context_line":""},{"line_number":428,"context_line":""},{"line_number":429,"context_line":"class DiskFormat(Enum):"},{"line_number":430,"context_line":"    RBD \u003d \"rbd\""},{"line_number":431,"context_line":"    LVM \u003d \"lvm\""},{"line_number":432,"context_line":"    QCOW2 \u003d \"qcow2\""},{"line_number":433,"context_line":"    RAW \u003d \"raw\""}],"source_content_type":"text/x-python","patch_set":4,"id":"da85f559_116b2d86","line":430,"in_reply_to":"da85f559_0392104c","updated":"2015-11-12 19:03:47.000000000","message":"ok, that make sense","commit_id":"bd6c8ff84dde379a473c7fced88e6a24c951f3fa"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"b67620f9a31ec23db5e97bff79946fc25d0e5db1","unresolved":false,"context_lines":[{"line_number":415,"context_line":""},{"line_number":416,"context_line":""},{"line_number":417,"context_line":"class DiskFormat(Enum):"},{"line_number":418,"context_line":"    NONE \u003d \"\""},{"line_number":419,"context_line":"    RBD \u003d \"rbd\""},{"line_number":420,"context_line":"    LVM \u003d \"lvm\""},{"line_number":421,"context_line":"    QCOW2 \u003d \"qcow2\""}],"source_content_type":"text/x-python","patch_set":9,"id":"7a740942_0da2ea4b","line":418,"updated":"2015-12-10 13:23:28.000000000","message":"Do we really need this ?  I would rather expect the field to simply be unset rather than set to \"\"","commit_id":"807631ad7338dcd98fec1768f2cd4ca548949552"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"8d03bb2fac07e01dad0f5f31361273bc0a2af5b1","unresolved":false,"context_lines":[{"line_number":415,"context_line":""},{"line_number":416,"context_line":""},{"line_number":417,"context_line":"class DiskFormat(Enum):"},{"line_number":418,"context_line":"    NONE \u003d \"\""},{"line_number":419,"context_line":"    RBD \u003d \"rbd\""},{"line_number":420,"context_line":"    LVM \u003d \"lvm\""},{"line_number":421,"context_line":"    QCOW2 \u003d \"qcow2\""}],"source_content_type":"text/x-python","patch_set":9,"id":"7a740942_b875c098","line":418,"in_reply_to":"7a740942_0da2ea4b","updated":"2015-12-11 19:46:24.000000000","message":"ok, thanks","commit_id":"807631ad7338dcd98fec1768f2cd4ca548949552"},{"author":{"_account_id":12408,"name":"Maxim Nestratov","email":"mnestratov@virtuozzo.com","username":"mnestratov"},"change_message_id":"8f828244e0c2819ce21d6bf73d4efbaa119c8fa5","unresolved":false,"context_lines":[{"line_number":421,"context_line":"    QCOW2 \u003d \"qcow2\""},{"line_number":422,"context_line":"    RAW \u003d \"raw\""},{"line_number":423,"context_line":"    PLOOP \u003d \"ploop\""},{"line_number":424,"context_line":"    PARALLELS \u003d \"parallels\""},{"line_number":425,"context_line":"    VHD \u003d \"vhd\""},{"line_number":426,"context_line":"    VMDK \u003d \"vmdk\""},{"line_number":427,"context_line":"    VDI \u003d \"vdi\""}],"source_content_type":"text/x-python","patch_set":9,"id":"7a740942_21232da9","line":424,"updated":"2015-12-10 14:11:27.000000000","message":"don\u0027t get why we need both ploop and parallels. They effectively mean the same. In OpenStack we use \"ploop\" name for parallels image types.","commit_id":"807631ad7338dcd98fec1768f2cd4ca548949552"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"8d03bb2fac07e01dad0f5f31361273bc0a2af5b1","unresolved":false,"context_lines":[{"line_number":421,"context_line":"    QCOW2 \u003d \"qcow2\""},{"line_number":422,"context_line":"    RAW \u003d \"raw\""},{"line_number":423,"context_line":"    PLOOP \u003d \"ploop\""},{"line_number":424,"context_line":"    PARALLELS \u003d \"parallels\""},{"line_number":425,"context_line":"    VHD \u003d \"vhd\""},{"line_number":426,"context_line":"    VMDK \u003d \"vmdk\""},{"line_number":427,"context_line":"    VDI \u003d \"vdi\""}],"source_content_type":"text/x-python","patch_set":9,"id":"7a740942_1846544f","line":424,"in_reply_to":"7a740942_21232da9","updated":"2015-12-11 19:46:24.000000000","message":"right, will change it","commit_id":"807631ad7338dcd98fec1768f2cd4ca548949552"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"b67620f9a31ec23db5e97bff79946fc25d0e5db1","unresolved":false,"context_lines":[{"line_number":428,"context_line":"    ISO \u003d \"iso\""},{"line_number":429,"context_line":"    AKI \u003d \"aki\""},{"line_number":430,"context_line":"    ARI \u003d \"ari\""},{"line_number":431,"context_line":"    AMI \u003d \"ami\""},{"line_number":432,"context_line":""},{"line_number":433,"context_line":"    ALL \u003d (NONE, RBD, LVM, QCOW2, RAW, PLOOP, PARALLELS, VHD, VMDK,"},{"line_number":434,"context_line":"           VDI, ISO, AKI, ARI, AMI)"}],"source_content_type":"text/x-python","patch_set":9,"id":"7a740942_cd59425d","line":431,"updated":"2015-12-10 13:23:28.000000000","message":"These last three aren\u0027t really disk formats AFAIK - they are all RAW formats - they\u0027re just specific semantic interpretations of the content","commit_id":"807631ad7338dcd98fec1768f2cd4ca548949552"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"8d03bb2fac07e01dad0f5f31361273bc0a2af5b1","unresolved":false,"context_lines":[{"line_number":428,"context_line":"    ISO \u003d \"iso\""},{"line_number":429,"context_line":"    AKI \u003d \"aki\""},{"line_number":430,"context_line":"    ARI \u003d \"ari\""},{"line_number":431,"context_line":"    AMI \u003d \"ami\""},{"line_number":432,"context_line":""},{"line_number":433,"context_line":"    ALL \u003d (NONE, RBD, LVM, QCOW2, RAW, PLOOP, PARALLELS, VHD, VMDK,"},{"line_number":434,"context_line":"           VDI, ISO, AKI, ARI, AMI)"}],"source_content_type":"text/x-python","patch_set":9,"id":"7a740942_38431044","line":431,"in_reply_to":"7a740942_cd59425d","updated":"2015-12-11 19:46:24.000000000","message":"ok, will remove them","commit_id":"807631ad7338dcd98fec1768f2cd4ca548949552"}],"nova/tests/unit/objects/test_fields.py":[{"author":{"_account_id":11803,"name":"Ryan Rossiter","email":"rlrossit@us.ibm.com","username":"rlrossiter"},"change_message_id":"1d2ecaaeb28f0b866523b2005a046262157e510b","unresolved":false,"context_lines":[{"line_number":586,"context_line":"    def setUp(self):"},{"line_number":587,"context_line":"        super(TestDiskFormat, self).setUp()"},{"line_number":588,"context_line":"        self.field \u003d fields.DiskFormatField()"},{"line_number":589,"context_line":"        self.coerce_good_values \u003d [(\u0027qcow2\u0027, \u0027qcow2\u0027),"},{"line_number":590,"context_line":"                                   (\u0027raw\u0027, \u0027raw\u0027),"},{"line_number":591,"context_line":"                                   (\u0027lvm\u0027, \u0027lvm\u0027),"},{"line_number":592,"context_line":"                                   (\u0027rbd\u0027, \u0027rbd\u0027),"}],"source_content_type":"text/x-python","patch_set":5,"id":"da85f559_dd481ccf","line":589,"updated":"2015-11-13 19:39:48.000000000","message":"Since \"\" is now a good value too, you should add it to this list.","commit_id":"3e5391d4c650b8325011211091cbe1fd9b736b25"}]}