)]}'
{"nova/tests/unit/virt/ironic/test_driver.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"cfc9b2a80423480c1942cf26ed6387f640a2961b","unresolved":false,"context_lines":[{"line_number":278,"context_line":"            props_dict \u003d instance_info"},{"line_number":279,"context_line":"        else:"},{"line_number":280,"context_line":"            cpus_key \u003d \u0027cpus\u0027"},{"line_number":281,"context_line":"            props_dict \u003d props"},{"line_number":282,"context_line":"        self.assertEqual(props_dict[cpus_key], result[\u0027vcpus\u0027])"},{"line_number":283,"context_line":"        self.assertEqual(props_dict[cpus_key], result[\u0027vcpus_used\u0027])"},{"line_number":284,"context_line":"        self.assertEqual(props_dict[\u0027memory_mb\u0027], result[\u0027memory_mb\u0027])"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a1a9d01_591bbb80","line":281,"updated":"2015-10-02 18:54:28.000000000","message":"FWIW, I think it would be clearer to just do this:\n\n if has_inst_info:\n     expected_cpus \u003d instance_info[\u0027vcpus\u0027]\n else:\n     expected_cpus \u003d props[\u0027cpus\u0027]","commit_id":"c24ef7a7261faddda26c82be6830d05f4f25542a"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"cfc9b2a80423480c1942cf26ed6387f640a2961b","unresolved":false,"context_lines":[{"line_number":279,"context_line":"        else:"},{"line_number":280,"context_line":"            cpus_key \u003d \u0027cpus\u0027"},{"line_number":281,"context_line":"            props_dict \u003d props"},{"line_number":282,"context_line":"        self.assertEqual(props_dict[cpus_key], result[\u0027vcpus\u0027])"},{"line_number":283,"context_line":"        self.assertEqual(props_dict[cpus_key], result[\u0027vcpus_used\u0027])"},{"line_number":284,"context_line":"        self.assertEqual(props_dict[\u0027memory_mb\u0027], result[\u0027memory_mb\u0027])"},{"line_number":285,"context_line":"        self.assertEqual(props_dict[\u0027memory_mb\u0027], result[\u0027memory_mb_used\u0027])"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a1a9d01_d907cb1b","line":282,"updated":"2015-10-02 18:54:28.000000000","message":"And then check against expected_cpus here","commit_id":"c24ef7a7261faddda26c82be6830d05f4f25542a"}],"nova/virt/ironic/driver.py":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"1688ba5248aa57918a95333ad6b6666994b3ed70","unresolved":false,"context_lines":[{"line_number":270,"context_line":"        in Ironic while an instance was deployed.\"\"\""},{"line_number":271,"context_line":"        instance_info \u003d {}"},{"line_number":272,"context_line":""},{"line_number":273,"context_line":"        # add this key because it\u0027s different in instance_info for some reason"},{"line_number":274,"context_line":"        props[\u0027vcpus\u0027] \u003d props[\u0027cpus\u0027]"},{"line_number":275,"context_line":"        for prop in (\u0027vcpus\u0027, \u0027memory_mb\u0027, \u0027local_gb\u0027):"},{"line_number":276,"context_line":"            original \u003d props[prop]"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a1a9d01_f48176fc","line":273,"updated":"2015-10-02 19:06:03.000000000","message":"nit: the \u0027for some reason\u0027 is IMHO not needed but fair enough","commit_id":"c25e2fa3e669cc9e6c9c2567e45ea0798c431e2d"}]}