)]}'
{"nova/compute/manager.py":[{"author":{"_account_id":360,"name":"Dan Prince","email":"dprince@redhat.com","username":"dan-prince"},"change_message_id":"86343242793e15d3b352a04f7f442ba932a1a28a","unresolved":false,"context_lines":[{"line_number":1569,"context_line":"                                             vm_state\u003dvm_states.ACTIVE,"},{"line_number":1570,"context_line":"                                             task_state\u003dNone)"},{"line_number":1571,"context_line":"        except exception.InstanceNotFound:"},{"line_number":1572,"context_line":"            LOG.warn(_(\"instance disappeared during reboot\"),"},{"line_number":1573,"context_line":"                     context\u003dcontext, instance\u003dinstance)"},{"line_number":1574,"context_line":""},{"line_number":1575,"context_line":"        self._notify_about_instance_usage(context, instance, \"reboot.end\")"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAN3%2F%2F%2FUc%3D","line":1572,"updated":"2013-03-04 14:37:39.000000000","message":"Minor nit: Could we make this \u0027Instance disappeared during reboot.\u0027 (with a period).","commit_id":"4e06981ebb029eecd2f6846489035e8dd51cbfc1"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"928aee9428fd4589c9880ea54e159ffc2697ec65","unresolved":false,"context_lines":[{"line_number":1572,"context_line":"            LOG.warn(_(\"instance disappeared during reboot\"),"},{"line_number":1573,"context_line":"                     context\u003dcontext, instance\u003dinstance)"},{"line_number":1574,"context_line":""},{"line_number":1575,"context_line":"        self._notify_about_instance_usage(context, instance, \"reboot.end\")"},{"line_number":1576,"context_line":""},{"line_number":1577,"context_line":"    @exception.wrap_exception(notifier\u003dnotifier, publisher_id\u003dpublisher_id())"},{"line_number":1578,"context_line":"    @reverts_task_state"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAANH%2F%2F9io%3D","line":1575,"updated":"2013-03-01 13:06:27.000000000","message":"is the notify still going to be sane?","commit_id":"4e06981ebb029eecd2f6846489035e8dd51cbfc1"},{"author":{"_account_id":4468,"name":"Wangpan","email":"hzwangpan@corp.netease.com","username":"hzwangpan"},"change_message_id":"2874f384c5edaec37f68032a65c1fd1012b90f72","unresolved":false,"context_lines":[{"line_number":1572,"context_line":"            LOG.warn(_(\"instance disappeared during reboot\"),"},{"line_number":1573,"context_line":"                     context\u003dcontext, instance\u003dinstance)"},{"line_number":1574,"context_line":""},{"line_number":1575,"context_line":"        self._notify_about_instance_usage(context, instance, \"reboot.end\")"},{"line_number":1576,"context_line":""},{"line_number":1577,"context_line":"    @exception.wrap_exception(notifier\u003dnotifier, publisher_id\u003dpublisher_id())"},{"line_number":1578,"context_line":"    @reverts_task_state"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAN3%2F%2F99c%3D","line":1575,"in_reply_to":"AAAAN3%2F%2F%2FUU%3D","updated":"2013-03-05 01:35:26.000000000","message":"In my opinion, the \u0027reboot.end\u0027 notification just represent this instance has been rebooted, and doesn\u0027t relate to the deleting operation, so this \u0027reboot.end\u0027 should be notified.","commit_id":"4e06981ebb029eecd2f6846489035e8dd51cbfc1"},{"author":{"_account_id":360,"name":"Dan Prince","email":"dprince@redhat.com","username":"dan-prince"},"change_message_id":"86343242793e15d3b352a04f7f442ba932a1a28a","unresolved":false,"context_lines":[{"line_number":1572,"context_line":"            LOG.warn(_(\"instance disappeared during reboot\"),"},{"line_number":1573,"context_line":"                     context\u003dcontext, instance\u003dinstance)"},{"line_number":1574,"context_line":""},{"line_number":1575,"context_line":"        self._notify_about_instance_usage(context, instance, \"reboot.end\")"},{"line_number":1576,"context_line":""},{"line_number":1577,"context_line":"    @exception.wrap_exception(notifier\u003dnotifier, publisher_id\u003dpublisher_id())"},{"line_number":1578,"context_line":"    @reverts_task_state"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAN3%2F%2F%2FUU%3D","line":1575,"in_reply_to":"AAAAN3%2F%2F%2Fz0%3D","updated":"2013-03-04 14:37:39.000000000","message":"Since the instance has been deleted the \u0027reboot.end\u0027 notification should be a mute point anyway right?","commit_id":"4e06981ebb029eecd2f6846489035e8dd51cbfc1"},{"author":{"_account_id":4468,"name":"Wangpan","email":"hzwangpan@corp.netease.com","username":"hzwangpan"},"change_message_id":"a414087f37286790eed327e64147c06d09d87663","unresolved":false,"context_lines":[{"line_number":1572,"context_line":"            LOG.warn(_(\"instance disappeared during reboot\"),"},{"line_number":1573,"context_line":"                     context\u003dcontext, instance\u003dinstance)"},{"line_number":1574,"context_line":""},{"line_number":1575,"context_line":"        self._notify_about_instance_usage(context, instance, \"reboot.end\")"},{"line_number":1576,"context_line":""},{"line_number":1577,"context_line":"    @exception.wrap_exception(notifier\u003dnotifier, publisher_id\u003dpublisher_id())"},{"line_number":1578,"context_line":"    @reverts_task_state"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAN3%2F%2F%2Fz0%3D","line":1575,"in_reply_to":"AAAANH%2F%2F9io%3D","updated":"2013-03-04 02:28:25.000000000","message":"Hi Sean, I have tried this under inline debug, when InstanceNotFound raised in _instance_update, the notification of \"reboot.end\" is notified normally as well as \"reboot.start\".\n$ sudo amqp-get --server\u003dlocalhost:5672 --username\u003dguest --password\u003dcloud -q notifications.info\n{\"_context_roles\": [\"admin\"], \"_context_request_id\": \"req-23f33dda-52e3-4e51-83de-98ae948e1149\", \"_context_quota_class\": null, \"event_type\": \"compute.instance.reboot.end\",...","commit_id":"4e06981ebb029eecd2f6846489035e8dd51cbfc1"}]}